tenkuma/jamfish
tenkuma/jamfish
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fixed a force close because of inconsistent unique ids.

Browse source
This commit is contained in:
Karim Abou Zeid 2016-03-24 17:59:58 +01:00
commit 06096ca8f5
2 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

5
app/src/main/java/com/kabouzeid/gramophone/adapter/song/PlaylistSongAdapter.java
View file

@ -38,6 +38,11 @@ public class PlaylistSongAdapter extends SongAdapter implements DraggableItemAda
this.onMoveItemListener = onMoveItemListener; this.onMoveItemListener = onMoveItemListener;
} }
@Override
public long getItemId(int position) {
return ((ArrayList<PlaylistSong>) (List) dataSet).get(position).idInPlayList; // important!
}
@Override @Override
protected SongAdapter.ViewHolder createViewHolder(View view) { protected SongAdapter.ViewHolder createViewHolder(View view) {
return new ViewHolder(view); return new ViewHolder(view);

5
app/src/main/java/com/kabouzeid/gramophone/adapter/song/SmartPlaylistSongAdapter.java
View file

@ -22,11 +22,6 @@ public class SmartPlaylistSongAdapter extends SongAdapter {
public static final String TAG = SmartPlaylistSongAdapter.class.getSimpleName(); public static final String TAG = SmartPlaylistSongAdapter.class.getSimpleName();
@Override
public long getItemId(int position) {
return dataSet.get(position).id;
}
public SmartPlaylistSongAdapter(AppCompatActivity activity, @NonNull ArrayList<Song> dataSet, @LayoutRes int itemLayoutRes, boolean usePalette, @Nullable CabHolder cabHolder) { public SmartPlaylistSongAdapter(AppCompatActivity activity, @NonNull ArrayList<Song> dataSet, @LayoutRes int itemLayoutRes, boolean usePalette, @Nullable CabHolder cabHolder) {
super(activity, dataSet, itemLayoutRes, usePalette, cabHolder); super(activity, dataSet, itemLayoutRes, usePalette, cabHolder);
overrideMultiSelectMenuRes(R.menu.menu_cannot_delete_single_songs_playlist_songs_selection); overrideMultiSelectMenuRes(R.menu.menu_cannot_delete_single_songs_playlist_songs_selection);