tenkuma/jamfish
tenkuma/jamfish
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix a bunch of lint warnings

Browse source
This commit is contained in:
dkanada 2021-05-23 22:38:44 +09:00
commit 06c40d3733
25 changed files with 21 additions and 71 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/src/main/java/com/dkanada/gramophone/activities/AboutActivity.java
View file

@ -3,7 +3,6 @@ package com.dkanada.gramophone.activities;
import android.content.Context;
import android.content.pm.PackageManager;
import android.os.Bundle;
import android.view.MenuItem;
import android.view.View;
import androidx.annotation.NonNull;
@ -18,7 +17,6 @@ import com.dkanada.gramophone.databinding.CardSupportDevelopmentBinding;
import com.dkanada.gramophone.R;
import com.dkanada.gramophone.activities.base.AbsBaseActivity;
@SuppressWarnings("FieldCanBeLocal")
public class AboutActivity extends AbsBaseActivity implements View.OnClickListener {
private ActivityAboutBinding binding;

3
app/src/main/java/com/dkanada/gramophone/activities/LoginActivity.java
View file

@ -4,12 +4,9 @@ import android.content.Context;
import android.content.Intent;
import android.os.Bundle;
import android.text.TextUtils;
import android.view.MenuItem;
import android.view.View;
import android.widget.Toast;
import androidx.annotation.NonNull;
import com.dkanada.gramophone.App;
import com.dkanada.gramophone.R;
import com.dkanada.gramophone.databinding.ActivityLoginBinding;

10
app/src/main/java/com/dkanada/gramophone/activities/SelectActivity.java
View file

@ -3,10 +3,7 @@ package com.dkanada.gramophone.activities;
import android.content.Context;
import android.content.Intent;
import android.os.Bundle;
import android.view.MenuItem;
import android.view.View;
import androidx.annotation.NonNull;
import androidx.recyclerview.widget.LinearLayoutManager;
import com.dkanada.gramophone.App;
@ -34,11 +31,8 @@ public class SelectActivity extends AbsBaseActivity {
binding.recyclerView.setAdapter(adapter);
binding.recyclerView.setLayoutManager(new LinearLayoutManager(this));
binding.add.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View v) {
startActivity(new Intent(context, LoginActivity.class));
}
binding.add.setOnClickListener(v -> {
startActivity(new Intent(context, LoginActivity.class));
});
setDrawUnderStatusBar();

1
app/src/main/java/com/dkanada/gramophone/activities/base/AbsMusicContentActivity.java
View file

@ -4,7 +4,6 @@ import android.content.BroadcastReceiver;
import android.content.Context;
import android.content.Intent;
import android.content.IntentFilter;
import android.net.ConnectivityManager;
import android.os.Bundle;
import androidx.annotation.NonNull;

2
app/src/main/java/com/dkanada/gramophone/adapter/song/AbsOffsetSongAdapter.java
View file

@ -31,7 +31,7 @@ public abstract class AbsOffsetSongAdapter extends SongAdapter {
@NonNull
@Override
public SongAdapter.ViewHolder onCreateViewHolder(ViewGroup parent, int viewType) {
public SongAdapter.ViewHolder onCreateViewHolder(@NonNull ViewGroup parent, int viewType) {
if (viewType == OFFSET_ITEM) {
View view = LayoutInflater.from(activity).inflate(R.layout.item_list_single_row, parent, false);
return createViewHolder(view);

2
app/src/main/java/com/dkanada/gramophone/adapter/song/OrderablePlaylistSongAdapter.java
View file

@ -20,7 +20,7 @@ import com.dkanada.gramophone.util.ViewUtil;
import java.util.List;
public class OrderablePlaylistSongAdapter extends PlaylistSongAdapter implements DraggableItemAdapter<OrderablePlaylistSongAdapter.ViewHolder> {
private OrderableListener onMoveItemListener;
private final OrderableListener onMoveItemListener;
public OrderablePlaylistSongAdapter(@NonNull AppCompatActivity activity, @NonNull List<Song> dataSet, @LayoutRes int itemLayoutRes, boolean usePalette, @Nullable CabHolder cabHolder, @Nullable OrderableListener onMoveItemListener) {
super(activity, dataSet, itemLayoutRes, usePalette, cabHolder);

7
app/src/main/java/com/dkanada/gramophone/adapter/song/PlayingQueueAdapter.java
View file

@ -152,10 +152,9 @@ public class PlayingQueueAdapter extends SongAdapter implements DraggableItemAda
@Override
protected boolean onSongMenuItemClick(MenuItem item) {
switch (item.getItemId()) {
case R.id.action_remove_from_queue:
MusicPlayerRemote.removeFromQueue(getBindingAdapterPosition());
return true;
if (item.getItemId() == R.id.action_remove_from_queue) {
MusicPlayerRemote.removeFromQueue(getBindingAdapterPosition());
return true;
}
return super.onSongMenuItemClick(item);

1
app/src/main/java/com/dkanada/gramophone/dialogs/AddToPlaylistDialog.java
View file

@ -8,7 +8,6 @@ import androidx.fragment.app.DialogFragment;
import com.afollestad.materialdialogs.MaterialDialog;
import com.dkanada.gramophone.R;
import com.dkanada.gramophone.interfaces.MediaCallback;
import com.dkanada.gramophone.model.Playlist;
import com.dkanada.gramophone.model.Song;
import com.dkanada.gramophone.util.PlaylistUtil;

2
app/src/main/java/com/dkanada/gramophone/dialogs/CreatePlaylistDialog.java
View file

@ -58,4 +58,4 @@ public class CreatePlaylistDialog extends DialogFragment {
})
.build();
}
}
}

1
app/src/main/java/com/dkanada/gramophone/dialogs/DeletePlaylistDialog.java
View file

@ -40,7 +40,6 @@ public class DeletePlaylistDialog extends DialogFragment {
final List<Playlist> playlists = getArguments().getParcelableArrayList("playlists");
int title;
CharSequence content;
// noinspection ConstantConditions
if (playlists.size() > 1) {
title = R.string.delete_playlists_title;
content = Html.fromHtml(getString(R.string.delete_x_playlists, playlists.size()));

4
app/src/main/java/com/dkanada/gramophone/dialogs/RenamePlaylistDialog.java
View file

@ -29,7 +29,7 @@ public class RenamePlaylistDialog extends DialogFragment {
@NonNull
@Override
public Dialog onCreateDialog(Bundle savedInstanceState) {
return new MaterialDialog.Builder(requireContext())
return new MaterialDialog.Builder(requireActivity())
.title(R.string.rename_playlist_title)
.positiveText(R.string.rename_action)
.negativeText(android.R.string.cancel)
@ -44,4 +44,4 @@ public class RenamePlaylistDialog extends DialogFragment {
})
.build();
}
}
}

4
app/src/main/java/com/dkanada/gramophone/fragments/mainactivity/AbsMainActivityFragment.java
View file

@ -12,8 +12,8 @@ public abstract class AbsMainActivityFragment extends Fragment {
}
@Override
public void onActivityCreated(Bundle savedInstanceState) {
super.onActivityCreated(savedInstanceState);
public void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setHasOptionsMenu(true);
}
}

4
app/src/main/java/com/dkanada/gramophone/fragments/mainactivity/library/pager/AbsLibraryPagerFragment.java
View file

@ -11,8 +11,8 @@ public class AbsLibraryPagerFragment extends AbsMusicServiceFragment {
}
@Override
public void onActivityCreated(Bundle savedInstanceState) {
super.onActivityCreated(savedInstanceState);
public void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setHasOptionsMenu(true);
}
}

7
app/src/main/java/com/dkanada/gramophone/fragments/mainactivity/library/pager/AlbumsFragment.java
View file

@ -1,7 +1,5 @@
package com.dkanada.gramophone.fragments.mainactivity.library.pager;
import android.os.Bundle;
import androidx.annotation.NonNull;
import androidx.recyclerview.widget.GridLayoutManager;
@ -23,11 +21,6 @@ import java.util.ArrayList;
import java.util.List;
public class AlbumsFragment extends AbsLibraryPagerRecyclerViewCustomGridSizeFragment<AlbumAdapter, GridLayoutManager, ItemQuery> {
@Override
public void onActivityCreated(Bundle savedInstanceState) {
super.onActivityCreated(savedInstanceState);
}
@NonNull
@Override
protected GridLayoutManager createLayoutManager() {

7
app/src/main/java/com/dkanada/gramophone/fragments/mainactivity/library/pager/ArtistsFragment.java
View file

@ -1,7 +1,5 @@
package com.dkanada.gramophone.fragments.mainactivity.library.pager;
import android.os.Bundle;
import androidx.annotation.LayoutRes;
import androidx.annotation.NonNull;
import androidx.recyclerview.widget.GridLayoutManager;
@ -25,11 +23,6 @@ import java.util.ArrayList;
import java.util.List;
public class ArtistsFragment extends AbsLibraryPagerRecyclerViewCustomGridSizeFragment<ArtistAdapter, GridLayoutManager, ArtistsQuery> {
@Override
public void onActivityCreated(Bundle savedInstanceState) {
super.onActivityCreated(savedInstanceState);
}
@NonNull
@Override
protected GridLayoutManager createLayoutManager() {

4
app/src/main/java/com/dkanada/gramophone/fragments/mainactivity/library/pager/FavoritesFragment.java
View file

@ -1,10 +1,6 @@
package com.dkanada.gramophone.fragments.mainactivity.library.pager;
import androidx.annotation.NonNull;
import com.dkanada.gramophone.App;
import com.dkanada.gramophone.util.PreferenceUtil;
import com.dkanada.gramophone.util.QueryUtil;
import org.jellyfin.apiclient.model.querying.ItemFields;
import org.jellyfin.apiclient.model.querying.ItemFilter;
import org.jellyfin.apiclient.model.querying.ItemQuery;

7
app/src/main/java/com/dkanada/gramophone/fragments/mainactivity/library/pager/GenresFragment.java
View file

@ -1,7 +1,5 @@
package com.dkanada.gramophone.fragments.mainactivity.library.pager;
import android.os.Bundle;
import androidx.annotation.NonNull;
import androidx.recyclerview.widget.LinearLayoutManager;
@ -21,11 +19,6 @@ import java.util.ArrayList;
import java.util.List;
public class GenresFragment extends AbsLibraryPagerRecyclerViewFragment<GenreAdapter, LinearLayoutManager, ItemsByNameQuery> {
@Override
public void onActivityCreated(Bundle savedInstanceState) {
super.onActivityCreated(savedInstanceState);
}
@NonNull
@Override
protected LinearLayoutManager createLayoutManager() {

7
app/src/main/java/com/dkanada/gramophone/fragments/mainactivity/library/pager/PlaylistsFragment.java
View file

@ -1,7 +1,5 @@
package com.dkanada.gramophone.fragments.mainactivity.library.pager;
import android.os.Bundle;
import androidx.annotation.NonNull;
import androidx.recyclerview.widget.LinearLayoutManager;
@ -21,11 +19,6 @@ import java.util.ArrayList;
import java.util.List;
public class PlaylistsFragment extends AbsLibraryPagerRecyclerViewFragment<PlaylistAdapter, LinearLayoutManager, ItemQuery> {
@Override
public void onActivityCreated(Bundle savedInstanceState) {
super.onActivityCreated(savedInstanceState);
}
@NonNull
@Override
protected LinearLayoutManager createLayoutManager() {

7
app/src/main/java/com/dkanada/gramophone/fragments/mainactivity/library/pager/SongsFragment.java
View file

@ -1,7 +1,5 @@
package com.dkanada.gramophone.fragments.mainactivity.library.pager;
import android.os.Bundle;
import androidx.annotation.NonNull;
import androidx.recyclerview.widget.GridLayoutManager;
@ -25,11 +23,6 @@ import java.util.ArrayList;
import java.util.List;
public class SongsFragment extends AbsLibraryPagerRecyclerViewCustomGridSizeFragment<SongAdapter, GridLayoutManager, ItemQuery> {
@Override
public void onActivityCreated(Bundle savedInstanceState) {
super.onActivityCreated(savedInstanceState);
}
@NonNull
@Override
protected GridLayoutManager createLayoutManager() {

1
app/src/main/java/com/dkanada/gramophone/fragments/player/card/CardPlayerPlaybackControlsFragment.java
View file

@ -173,6 +173,7 @@ public class CardPlayerPlaybackControlsFragment extends AbsMusicServiceFragment
case MusicService.SHUFFLE_MODE_SHUFFLE:
binding.playerShuffleButton.setColorFilter(lastPlaybackControlsColor, PorterDuff.Mode.SRC_IN);
break;
case MusicService.SHUFFLE_MODE_NONE:
default:
binding.playerShuffleButton.setColorFilter(lastDisabledPlaybackControlsColor, PorterDuff.Mode.SRC_IN);
break;

1
app/src/main/java/com/dkanada/gramophone/fragments/player/flat/FlatPlayerPlaybackControlsFragment.java
View file

@ -182,6 +182,7 @@ public class FlatPlayerPlaybackControlsFragment extends AbsMusicServiceFragment
case MusicService.SHUFFLE_MODE_SHUFFLE:
binding.playerShuffleButton.setColorFilter(lastPlaybackControlsColor, PorterDuff.Mode.SRC_IN);
break;
case MusicService.SHUFFLE_MODE_NONE:
default:
binding.playerShuffleButton.setColorFilter(lastDisabledPlaybackControlsColor, PorterDuff.Mode.SRC_IN);
break;

2
app/src/main/java/com/dkanada/gramophone/helper/StackBlur.java
View file

@ -324,7 +324,7 @@ public class StackBlur {
}
@Override
public Void call() throws Exception {
public Void call() {
blurIteration(_src, _w, _h, _radius, _totalCores, _coreIndex, _round);
return null;
}

1
app/src/main/java/com/dkanada/gramophone/service/playback/LocalPlayer.java
View file

@ -35,6 +35,7 @@ public class LocalPlayer implements Playback {
private PlaybackCallbacks callbacks;
@SuppressWarnings("FieldCanBeLocal")
private final EventListener eventListener = new EventListener() {
@Override
public void onPlayWhenReadyChanged(boolean playWhenReady, int reason) {

1
app/src/main/java/com/dkanada/gramophone/service/playback/UnknownMediaSourceFactory.kt
View file

@ -59,6 +59,7 @@ class UnknownMediaSourceFactory(dataSourceFactory: DataSource.Factory) : MediaSo
return sourceFactory.createMediaSource(mediaItem)
}
@Suppress("BlockingMethodInNonBlockingContext")
private suspend fun httpGet(url: String?): String? {
return withContext(Dispatchers.IO) {
val request = URL(url)

4
app/src/main/res/layout/navigation_drawer_header.xml
View file

@ -1,4 +1,4 @@
<androidx.percentlayout.widget.PercentFrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
android:id="@+id/header"
android:layout_width="match_parent"
@ -55,4 +55,4 @@
</LinearLayout>
</androidx.percentlayout.widget.PercentFrameLayout>
</FrameLayout>