tenkuma/jamfish
tenkuma/jamfish
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Removed unnecessary statusbar elevation in the now playing view

Browse source
This commit is contained in:
Karim Abou Zeid 2015-08-16 23:27:33 +02:00
commit 0f083270ba
2 changed files with 15 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/src/main/assets/changelog.html
View file

@ -45,6 +45,8 @@
</li> </li>
<li><b>FIX:</b> Album and artist list not scrolling when trying to drag from their title bar. <li><b>FIX:</b> Album and artist list not scrolling when trying to drag from their title bar.
</li> </li>
<li><b>FIX:</b> Removed unnecessary statusbar elevation in the now playing view.
</li>
</ol> </ol>
<h3>Version 0.9.43 beta1</h3> <h3>Version 0.9.43 beta1</h3>

14
app/src/main/java/com/kabouzeid/gramophone/ui/activities/base/AbsSlidingMusicPanelActivity.java
View file

@ -181,6 +181,7 @@ public abstract class AbsSlidingMusicPanelActivity extends AbsMusicServiceActivi
setUpMusicControllers(); setUpMusicControllers();
setUpAlbumArtViews(); setUpAlbumArtViews();
setUpPlayerToolbar(); setUpPlayerToolbar();
setUpPlayerStatusBarElevation();
progressViewsUpdateHandler = new MusicProgressViewsUpdateHandler(this); progressViewsUpdateHandler = new MusicProgressViewsUpdateHandler(this);
@ -248,9 +249,8 @@ public abstract class AbsSlidingMusicPanelActivity extends AbsMusicServiceActivi
// do not break here // do not break here
case PreferenceUtil.OPAQUE_TOOLBAR_NOW_PLAYING: case PreferenceUtil.OPAQUE_TOOLBAR_NOW_PLAYING:
opaqueToolBar = opaqueStatusBar && PreferenceUtil.getInstance(this).opaqueToolbarNowPlaying(); opaqueToolBar = opaqueStatusBar && PreferenceUtil.getInstance(this).opaqueToolbarNowPlaying();
if (lastFooterColor != -1) { setUpPlayerStatusBarElevation();
animateColorChange(lastFooterColor); animateColorChange(lastFooterColor);
}
if (opaqueStatusBar) { if (opaqueStatusBar) {
if (opaqueToolBar) { if (opaqueToolBar) {
alignAlbumArtToToolbar(); alignAlbumArtToToolbar();
@ -720,6 +720,16 @@ public abstract class AbsSlidingMusicPanelActivity extends AbsMusicServiceActivi
playerToolbar.setOnMenuItemClickListener(this); playerToolbar.setOnMenuItemClickListener(this);
} }
private void setUpPlayerStatusBarElevation() {
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
if (opaqueToolBar) {
playerStatusbar.setElevation(getResources().getDimensionPixelSize(R.dimen.toolbar_elevation));
} else {
playerStatusbar.setElevation(0);
}
}
}
private void updatePlayerMenu() { private void updatePlayerMenu() {
boolean isFavorite = MusicUtil.isFavorite(this, song); boolean isFavorite = MusicUtil.isFavorite(this, song);
playerToolbar.getMenu().findItem(R.id.action_toggle_favorite) playerToolbar.getMenu().findItem(R.id.action_toggle_favorite)