From 67a6732640f3279e2a82c3fe7d90f51b588e5354 Mon Sep 17 00:00:00 2001
From: bgaesslein <benjamin.gaesslein@gmail.com>
Date: Thu, 10 Feb 2022 21:36:55 +0100
Subject: [PATCH] Move setHasOptionsMenu to onCreateView

Commit 06c40d3 replaced the deprecated onActivityCreated with onCreate.
Apparently this leads to issues like backgrounds turning white on
screen rotation.
Fix: use onCreateView() instead, move to AbsMainActivityFragment and
LibraryFragment respectively because onCreateView gets overridden there

Should fix #167
---
 .../fragments/library/AbsLibraryPagerFragment.java        | 8 --------
 .../library/AbsLibraryPagerRecyclerViewFragment.java      | 1 +
 .../fragments/main/AbsMainActivityFragment.java           | 8 --------
 .../gramophone/fragments/main/LibraryFragment.java        | 1 +
 4 files changed, 2 insertions(+), 16 deletions(-)

diff --git a/app/src/main/java/com/dkanada/gramophone/fragments/library/AbsLibraryPagerFragment.java b/app/src/main/java/com/dkanada/gramophone/fragments/library/AbsLibraryPagerFragment.java
index 3a23b4fd..ae74bfe0 100644
--- a/app/src/main/java/com/dkanada/gramophone/fragments/library/AbsLibraryPagerFragment.java
+++ b/app/src/main/java/com/dkanada/gramophone/fragments/library/AbsLibraryPagerFragment.java
@@ -1,7 +1,5 @@
 package com.dkanada.gramophone.fragments.library;
 
-import android.os.Bundle;
-
 import com.dkanada.gramophone.fragments.AbsMusicServiceFragment;
 import com.dkanada.gramophone.fragments.main.LibraryFragment;
 
@@ -9,10 +7,4 @@ public class AbsLibraryPagerFragment extends AbsMusicServiceFragment {
     public LibraryFragment getLibraryFragment() {
         return (LibraryFragment) getParentFragment();
     }
-
-    @Override
-    public void onCreate(Bundle savedInstanceState) {
-        super.onCreate(savedInstanceState);
-        setHasOptionsMenu(true);
-    }
 }
diff --git a/app/src/main/java/com/dkanada/gramophone/fragments/library/AbsLibraryPagerRecyclerViewFragment.java b/app/src/main/java/com/dkanada/gramophone/fragments/library/AbsLibraryPagerRecyclerViewFragment.java
index b39d3e73..46c61c91 100644
--- a/app/src/main/java/com/dkanada/gramophone/fragments/library/AbsLibraryPagerRecyclerViewFragment.java
+++ b/app/src/main/java/com/dkanada/gramophone/fragments/library/AbsLibraryPagerRecyclerViewFragment.java
@@ -31,6 +31,7 @@ public abstract class AbsLibraryPagerRecyclerViewFragment<A extends RecyclerView
 
     @Override
     public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
+        setHasOptionsMenu(true);
         binding = FragmentMainActivityRecyclerViewBinding.inflate(getLayoutInflater(), container, false);
 
         return binding.getRoot();
diff --git a/app/src/main/java/com/dkanada/gramophone/fragments/main/AbsMainActivityFragment.java b/app/src/main/java/com/dkanada/gramophone/fragments/main/AbsMainActivityFragment.java
index 0210be87..c0331084 100644
--- a/app/src/main/java/com/dkanada/gramophone/fragments/main/AbsMainActivityFragment.java
+++ b/app/src/main/java/com/dkanada/gramophone/fragments/main/AbsMainActivityFragment.java
@@ -1,7 +1,5 @@
 package com.dkanada.gramophone.fragments.main;
 
-import android.os.Bundle;
-
 import androidx.fragment.app.Fragment;
 
 import com.dkanada.gramophone.activities.MainActivity;
@@ -10,10 +8,4 @@ public abstract class AbsMainActivityFragment extends Fragment {
     public MainActivity getMainActivity() {
         return (MainActivity) getActivity();
     }
-
-    @Override
-    public void onCreate(Bundle savedInstanceState) {
-        super.onCreate(savedInstanceState);
-        setHasOptionsMenu(true);
-    }
 }
diff --git a/app/src/main/java/com/dkanada/gramophone/fragments/main/LibraryFragment.java b/app/src/main/java/com/dkanada/gramophone/fragments/main/LibraryFragment.java
index bf03f86d..8ed52903 100644
--- a/app/src/main/java/com/dkanada/gramophone/fragments/main/LibraryFragment.java
+++ b/app/src/main/java/com/dkanada/gramophone/fragments/main/LibraryFragment.java
@@ -47,6 +47,7 @@ public class LibraryFragment extends AbsMainActivityFragment implements ViewPage
 
     @Override
     public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
+        setHasOptionsMenu(true);
         binding = FragmentLibraryBinding.inflate(inflater);
 
         return binding.getRoot();