diff --git a/app/src/main/java/com/kabouzeid/gramophone/adapter/PlaylistAdapter.java b/app/src/main/java/com/kabouzeid/gramophone/adapter/PlaylistAdapter.java index 0675ebc7..13633ad8 100644 --- a/app/src/main/java/com/kabouzeid/gramophone/adapter/PlaylistAdapter.java +++ b/app/src/main/java/com/kabouzeid/gramophone/adapter/PlaylistAdapter.java @@ -109,7 +109,7 @@ public class PlaylistAdapter extends AbsMultiSelectAdapter glideAnimation) { super.onResourceReady(resource, glideAnimation); - onColorReady(PhonographColorUtil.getColor(resource.getPalette(), getDefaultBarColor())); + onColorReady(PhonographColorUtil.getColor(resource.getPalette(), getDefaultFooterColor())); } - protected int getDefaultBarColor() { - return ATHUtil.resolveColor(getView().getContext(), R.attr.default_bar_color); + protected int getDefaultFooterColor() { + return ATHUtil.resolveColor(getView().getContext(), R.attr.defaultFooterColor); } public abstract void onColorReady(int color); diff --git a/app/src/main/java/com/kabouzeid/gramophone/ui/activities/AboutActivity.java b/app/src/main/java/com/kabouzeid/gramophone/ui/activities/AboutActivity.java index c0eb3bd4..a2c6fc89 100644 --- a/app/src/main/java/com/kabouzeid/gramophone/ui/activities/AboutActivity.java +++ b/app/src/main/java/com/kabouzeid/gramophone/ui/activities/AboutActivity.java @@ -10,13 +10,11 @@ import android.support.v7.widget.AppCompatButton; import android.support.v7.widget.Toolbar; import android.view.MenuItem; import android.view.View; -import android.widget.ImageView; import android.widget.LinearLayout; import android.widget.TextView; import com.afollestad.materialdialogs.internal.ThemeSingleton; import com.kabouzeid.appthemehelper.ThemeStore; -import com.kabouzeid.appthemehelper.util.ATHUtil; import com.kabouzeid.gramophone.R; import com.kabouzeid.gramophone.dialogs.ChangelogDialog; import com.kabouzeid.gramophone.dialogs.DonationDialog; @@ -94,35 +92,6 @@ public class AboutActivity extends AbsBaseActivity implements View.OnClickListen @Bind(R.id.aleksandar_tesic_google_plus) AppCompatButton aleksandarTesicGooglePlus; - @Bind(R.id.icon_info) - ImageView iconInfo; - @Bind(R.id.icon_changelog) - ImageView iconChangelog; - @Bind(R.id.icon_intro) - ImageView iconIntro; - @Bind(R.id.icon_licenses) - ImageView iconLicenses; - @Bind(R.id.icon_bug_report) - ImageView iconBugReport; - @Bind(R.id.icon_google_plus_community) - ImageView iconGooglePlusCommunity; - @Bind(R.id.icon_flag) - ImageView iconFlag; - @Bind(R.id.icon_rate) - ImageView iconRate; - @Bind(R.id.icon_donate) - ImageView iconDonate; - @Bind(R.id.icon_author) - ImageView iconAuthor; - @Bind(R.id.icon_google_plus) - ImageView iconGooglePlus; - @Bind(R.id.icon_twitter) - ImageView iconTwitter; - @Bind(R.id.icon_github) - ImageView iconGithub; - @Bind(R.id.icon_website) - ImageView iconWebsite; - @Override protected void onCreate(Bundle savedInstanceState) { super.onCreate(savedInstanceState); @@ -140,7 +109,6 @@ public class AboutActivity extends AbsBaseActivity implements View.OnClickListen private void setUpViews() { setUpToolbar(); setUpAppVersion(); - setUpIconTint(); setUpOnClickListeners(); } @@ -176,24 +144,6 @@ public class AboutActivity extends AbsBaseActivity implements View.OnClickListen aleksandarTesicGooglePlus.setOnClickListener(this); } - private void setUpIconTint() { - int iconColor = ATHUtil.resolveColor(this, R.attr.icon_color, ThemeStore.textColorSecondary(this)); - iconInfo.setColorFilter(iconColor); - iconChangelog.setColorFilter(iconColor); - iconIntro.setColorFilter(iconColor); - iconLicenses.setColorFilter(iconColor); - iconBugReport.setColorFilter(iconColor); - iconGooglePlusCommunity.setColorFilter(iconColor); - iconFlag.setColorFilter(iconColor); - iconRate.setColorFilter(iconColor); - iconDonate.setColorFilter(iconColor); - iconAuthor.setColorFilter(iconColor); - iconGooglePlus.setColorFilter(iconColor); - iconTwitter.setColorFilter(iconColor); - iconGithub.setColorFilter(iconColor); - iconWebsite.setColorFilter(iconColor); - } - @Override public boolean onOptionsItemSelected(@NonNull MenuItem item) { if (item.getItemId() == android.R.id.home) { diff --git a/app/src/main/java/com/kabouzeid/gramophone/ui/activities/AlbumDetailActivity.java b/app/src/main/java/com/kabouzeid/gramophone/ui/activities/AlbumDetailActivity.java index ff7b98eb..4894d265 100644 --- a/app/src/main/java/com/kabouzeid/gramophone/ui/activities/AlbumDetailActivity.java +++ b/app/src/main/java/com/kabouzeid/gramophone/ui/activities/AlbumDetailActivity.java @@ -131,7 +131,7 @@ public class AlbumDetailActivity extends AbsSlidingMusicPanelActivity implements private void setUpObservableListViewParams() { albumArtViewHeight = getResources().getDimensionPixelSize(R.dimen.header_image_height); - toolbarColor = DialogUtils.resolveColor(this, R.attr.default_bar_color); + toolbarColor = DialogUtils.resolveColor(this, R.attr.defaultFooterColor); int toolbarHeight = Util.getActionBarSize(this); titleViewHeight = getResources().getDimensionPixelSize(R.dimen.title_view_height); headerOffset = toolbarHeight; diff --git a/app/src/main/java/com/kabouzeid/gramophone/ui/activities/ArtistDetailActivity.java b/app/src/main/java/com/kabouzeid/gramophone/ui/activities/ArtistDetailActivity.java index b0bdcf2b..58ec3e2e 100644 --- a/app/src/main/java/com/kabouzeid/gramophone/ui/activities/ArtistDetailActivity.java +++ b/app/src/main/java/com/kabouzeid/gramophone/ui/activities/ArtistDetailActivity.java @@ -148,7 +148,7 @@ public class ArtistDetailActivity extends AbsSlidingMusicPanelActivity implement private void setUpObservableListViewParams() { artistImageViewHeight = getResources().getDimensionPixelSize(R.dimen.header_image_height); - toolbarColor = DialogUtils.resolveColor(this, R.attr.default_bar_color); + toolbarColor = DialogUtils.resolveColor(this, R.attr.defaultFooterColor); int toolbarHeight = Util.getActionBarSize(this); titleViewHeight = getResources().getDimensionPixelSize(R.dimen.title_view_height); headerOffset = toolbarHeight; diff --git a/app/src/main/java/com/kabouzeid/gramophone/ui/activities/MainActivity.java b/app/src/main/java/com/kabouzeid/gramophone/ui/activities/MainActivity.java index 21f3b911..9a821cbd 100644 --- a/app/src/main/java/com/kabouzeid/gramophone/ui/activities/MainActivity.java +++ b/app/src/main/java/com/kabouzeid/gramophone/ui/activities/MainActivity.java @@ -188,7 +188,7 @@ public class MainActivity extends AbsSlidingMusicPanelActivity navigationView.setCheckedItem(R.id.nav_library); int accentColor = ThemeStore.accentColor(this); - NavigationViewUtil.setItemIconColors(navigationView, ATHUtil.resolveColor(this, R.attr.icon_color, ThemeStore.textColorSecondary(this)), accentColor); + NavigationViewUtil.setItemIconColors(navigationView, ATHUtil.resolveColor(this, R.attr.iconColor, ThemeStore.textColorSecondary(this)), accentColor); NavigationViewUtil.setItemTextColors(navigationView, ThemeStore.textColorPrimary(this), accentColor); navigationView.setNavigationItemSelectedListener(new NavigationView.OnNavigationItemSelectedListener() { diff --git a/app/src/main/java/com/kabouzeid/gramophone/ui/activities/tageditor/AlbumTagEditorActivity.java b/app/src/main/java/com/kabouzeid/gramophone/ui/activities/tageditor/AlbumTagEditorActivity.java index 577a00e7..06ee068c 100644 --- a/app/src/main/java/com/kabouzeid/gramophone/ui/activities/tageditor/AlbumTagEditorActivity.java +++ b/app/src/main/java/com/kabouzeid/gramophone/ui/activities/tageditor/AlbumTagEditorActivity.java @@ -95,7 +95,7 @@ public class AlbumTagEditorActivity extends AbsTagEditorActivity implements Text @Override protected void loadCurrentImage() { Bitmap bitmap = getAlbumArt(); - setImageBitmap(bitmap, PhonographColorUtil.getColor(PhonographColorUtil.generatePalette(bitmap), ATHUtil.resolveColor(this, R.attr.default_bar_color))); + setImageBitmap(bitmap, PhonographColorUtil.getColor(PhonographColorUtil.generatePalette(bitmap), ATHUtil.resolveColor(this, R.attr.defaultFooterColor))); deleteAlbumArt = false; } @@ -131,7 +131,7 @@ public class AlbumTagEditorActivity extends AbsTagEditorActivity implements Text @Override public void onResourceReady(BitmapPaletteWrapper resource, GlideAnimation glideAnimation) { albumArtBitmap = getResizedAlbumCover(resource.getBitmap(), 2048); - setImageBitmap(albumArtBitmap, PhonographColorUtil.getColor(resource.getPalette(), ATHUtil.resolveColor(AlbumTagEditorActivity.this, R.attr.default_bar_color))); + setImageBitmap(albumArtBitmap, PhonographColorUtil.getColor(resource.getPalette(), ATHUtil.resolveColor(AlbumTagEditorActivity.this, R.attr.defaultFooterColor))); deleteAlbumArt = false; dataChanged(); setResult(RESULT_OK); @@ -162,7 +162,7 @@ public class AlbumTagEditorActivity extends AbsTagEditorActivity implements Text @Override protected void deleteImage() { - setImageBitmap(BitmapFactory.decodeResource(getResources(), R.drawable.default_album_art), ATHUtil.resolveColor(this, R.attr.default_bar_color)); + setImageBitmap(BitmapFactory.decodeResource(getResources(), R.drawable.default_album_art), ATHUtil.resolveColor(this, R.attr.defaultFooterColor)); deleteAlbumArt = true; dataChanged(); } @@ -228,7 +228,7 @@ public class AlbumTagEditorActivity extends AbsTagEditorActivity implements Text public void onResourceReady(BitmapPaletteWrapper resource, GlideAnimation glideAnimation) { PhonographColorUtil.getColor(resource.getPalette(), Color.TRANSPARENT); albumArtBitmap = getResizedAlbumCover(resource.getBitmap(), 2048); - setImageBitmap(albumArtBitmap, PhonographColorUtil.getColor(resource.getPalette(), ATHUtil.resolveColor(AlbumTagEditorActivity.this, R.attr.default_bar_color))); + setImageBitmap(albumArtBitmap, PhonographColorUtil.getColor(resource.getPalette(), ATHUtil.resolveColor(AlbumTagEditorActivity.this, R.attr.defaultFooterColor))); deleteAlbumArt = false; dataChanged(); setResult(RESULT_OK); diff --git a/app/src/main/java/com/kabouzeid/gramophone/ui/fragments/player/MiniPlayerFragment.java b/app/src/main/java/com/kabouzeid/gramophone/ui/fragments/player/MiniPlayerFragment.java index 2f8db166..16b1b549 100644 --- a/app/src/main/java/com/kabouzeid/gramophone/ui/fragments/player/MiniPlayerFragment.java +++ b/app/src/main/java/com/kabouzeid/gramophone/ui/fragments/player/MiniPlayerFragment.java @@ -16,15 +16,12 @@ import android.widget.TextView; import com.kabouzeid.appthemehelper.ThemeStore; import com.kabouzeid.appthemehelper.util.ATHUtil; -import com.kabouzeid.appthemehelper.util.ColorUtil; -import com.kabouzeid.appthemehelper.util.MaterialValueHelper; import com.kabouzeid.gramophone.R; import com.kabouzeid.gramophone.helper.MusicPlayerRemote; import com.kabouzeid.gramophone.helper.MusicProgressViewUpdateHelper; import com.kabouzeid.gramophone.helper.PlayPauseButtonOnClickHandler; import com.kabouzeid.gramophone.interfaces.MusicServiceEventListener; import com.kabouzeid.gramophone.ui.activities.base.AbsMusicServiceActivity; -import com.kabouzeid.gramophone.util.Util; import com.kabouzeid.gramophone.views.PlayPauseDrawable; import butterknife.Bind; @@ -97,24 +94,14 @@ public class MiniPlayerFragment extends Fragment implements MusicServiceEventLis } private void setUpMiniPlayer() { - setMiniPlayerColor(ATHUtil.resolveColor(activity, R.attr.cardBackgroundColor)); - miniPlayerImage.setImageDrawable(Util.getTintedDrawable(activity, R.drawable.ic_keyboard_arrow_up_white_24dp, - ATHUtil.resolveColor(activity, R.attr.icon_color, ThemeStore.textColorSecondary(getActivity())))); setUpPlayPauseButton(); - progressBar.setProgressTintList(ColorStateList.valueOf(ThemeStore.accentColor(activity))); } - public void setMiniPlayerColor(int color) { - if (getView() == null) return; - getView().setBackgroundColor(color); - miniPlayerTitle.setTextColor(MaterialValueHelper.getPrimaryTextColor(activity, ColorUtil.isColorLight(color))); - } - private void setUpPlayPauseButton() { updatePlayPauseDrawableState(false); miniPlayerPlayPauseButton.setImageDrawable(miniPlayerPlayPauseDrawable); - miniPlayerPlayPauseButton.setColorFilter(ATHUtil.resolveColor(activity, R.attr.icon_color, ThemeStore.textColorSecondary(getActivity())), PorterDuff.Mode.SRC_IN); + miniPlayerPlayPauseButton.setColorFilter(ATHUtil.resolveColor(activity, R.attr.iconColor, ThemeStore.textColorSecondary(getActivity())), PorterDuff.Mode.SRC_IN); miniPlayerPlayPauseButton.setOnClickListener(new PlayPauseButtonOnClickHandler()); } diff --git a/app/src/main/java/com/kabouzeid/gramophone/ui/fragments/player/PlayerFragment.java b/app/src/main/java/com/kabouzeid/gramophone/ui/fragments/player/PlayerFragment.java index d01f40d7..3f2e8c74 100644 --- a/app/src/main/java/com/kabouzeid/gramophone/ui/fragments/player/PlayerFragment.java +++ b/app/src/main/java/com/kabouzeid/gramophone/ui/fragments/player/PlayerFragment.java @@ -385,7 +385,7 @@ public class PlayerFragment extends AbsPlayerFragment implements PlayerAlbumCove currentSongViewHolder.separator.setVisibility(View.VISIBLE); currentSongViewHolder.shortSeparator.setVisibility(View.GONE); currentSongViewHolder.image.setScaleType(ImageView.ScaleType.CENTER); - currentSongViewHolder.image.setImageDrawable(Util.getTintedDrawable(fragment.getActivity(), R.drawable.ic_volume_up_white_24dp, ATHUtil.resolveColor(fragment.getActivity(), R.attr.icon_color, ThemeStore.textColorSecondary(fragment.getActivity())))); + currentSongViewHolder.image.setImageDrawable(Util.getTintedDrawable(fragment.getActivity(), R.drawable.ic_volume_up_white_24dp, ATHUtil.resolveColor(fragment.getActivity(), R.attr.iconColor, ThemeStore.textColorSecondary(fragment.getActivity())))); currentSongViewHolder.itemView.setOnClickListener(new View.OnClickListener() { @Override public void onClick(View v) { diff --git a/app/src/main/res/layout/activity_album_detail.xml b/app/src/main/res/layout/activity_album_detail.xml index b51f0d06..34bea92f 100644 --- a/app/src/main/res/layout/activity_album_detail.xml +++ b/app/src/main/res/layout/activity_album_detail.xml @@ -38,7 +38,7 @@ android:layout_width="match_parent" android:layout_height="@dimen/title_view_height" android:height="@dimen/title_view_height" - android:background="?default_bar_color" + android:background="?attr/defaultFooterColor" android:elevation="@dimen/toolbar_elevation" android:fontFamily="sans-serif-medium" android:gravity="center_vertical" diff --git a/app/src/main/res/layout/activity_artist_detail.xml b/app/src/main/res/layout/activity_artist_detail.xml index 2c372647..25cbf3d7 100644 --- a/app/src/main/res/layout/activity_artist_detail.xml +++ b/app/src/main/res/layout/activity_artist_detail.xml @@ -37,7 +37,7 @@ android:layout_width="match_parent" android:layout_height="@dimen/title_view_height" android:height="@dimen/title_view_height" - android:background="?default_bar_color" + android:background="?attr/defaultFooterColor" android:elevation="@dimen/toolbar_elevation" android:fontFamily="sans-serif-medium" android:gravity="center_vertical" diff --git a/app/src/main/res/layout/artist_detail_header.xml b/app/src/main/res/layout/artist_detail_header.xml index 303840ec..ed4e6262 100644 --- a/app/src/main/res/layout/artist_detail_header.xml +++ b/app/src/main/res/layout/artist_detail_header.xml @@ -14,6 +14,6 @@ android:layout_width="match_parent" android:layout_height="1dp" android:layout_marginTop="-8dp" - android:background="?divider_color" /> + android:background="?attr/dividerColor" /> \ No newline at end of file diff --git a/app/src/main/res/layout/card_about_app.xml b/app/src/main/res/layout/card_about_app.xml index 3f92f1e6..0f89b519 100644 --- a/app/src/main/res/layout/card_about_app.xml +++ b/app/src/main/res/layout/card_about_app.xml @@ -41,7 +41,7 @@ + android:tint="?attr/iconColor" + android:tintMode="src_in" + tools:ignore="ContentDescription,UnusedAttribute" /> + android:tint="?attr/iconColor" + android:tintMode="src_in" + tools:ignore="ContentDescription,UnusedAttribute" /> + android:tint="?attr/iconColor" + android:tintMode="src_in" + tools:ignore="ContentDescription,UnusedAttribute" /> + android:tint="?attr/iconColor" + android:tintMode="src_in" + tools:ignore="ContentDescription,UnusedAttribute" /> + android:tint="?attr/iconColor" + android:tintMode="src_in" + tools:ignore="ContentDescription,UnusedAttribute" /> + android:tint="?attr/iconColor" + android:tintMode="src_in" + tools:ignore="ContentDescription,UnusedAttribute" /> + android:tint="?attr/iconColor" + android:tintMode="src_in" + tools:ignore="ContentDescription,UnusedAttribute" /> + android:tint="?attr/iconColor" + android:tintMode="src_in" + tools:ignore="ContentDescription,UnusedAttribute" /> + android:tint="?attr/iconColor" + android:tintMode="src_in" + tools:ignore="ContentDescription,UnusedAttribute" /> + android:tint="?attr/iconColor" + android:tintMode="src_in" + tools:ignore="ContentDescription,UnusedAttribute" /> + android:tint="?attr/iconColor" + android:tintMode="src_in" + tools:ignore="ContentDescription,UnusedAttribute" /> + android:tint="?attr/iconColor" + android:tintMode="src_in" + tools:ignore="ContentDescription,UnusedAttribute" /> + android:tint="?attr/iconColor" + android:tintMode="src_in" + tools:ignore="ContentDescription,UnusedAttribute" /> + android:tint="?attr/iconColor" + android:tintMode="src_in" + tools:ignore="ContentDescription,UnusedAttribute" /> @@ -23,6 +24,9 @@ android:layout_gravity="center_vertical" android:layout_margin="16dp" android:scaleType="centerCrop" + android:src="@drawable/ic_keyboard_arrow_up_white_24dp" + android:tint="?attr/iconColor" + android:tintMode="src_in" tools:ignore="ContentDescription" /> @@ -79,7 +79,7 @@ android:layout_marginStart="-8dp" android:layout_toEndOf="@+id/dummy_fab" android:layout_toRightOf="@+id/dummy_fab" - android:background="?round_selector" + android:background="?attr/roundSelector" android:padding="22dp" android:scaleType="fitCenter" android:src="@drawable/ic_skip_next_white_36dp" /> @@ -93,7 +93,7 @@ android:layout_centerVertical="true" android:layout_marginLeft="16dp" android:layout_marginStart="16dp" - android:background="?round_selector" + android:background="?attr/roundSelector" android:padding="22dp" android:scaleType="fitCenter" android:src="@drawable/ic_repeat_white_36dp" /> @@ -107,7 +107,7 @@ android:layout_centerVertical="true" android:layout_marginEnd="16dp" android:layout_marginRight="16dp" - android:background="?round_selector" + android:background="?attr/roundSelector" android:padding="22dp" android:scaleType="fitCenter" android:src="@drawable/ic_shuffle_white_36dp" /> diff --git a/app/src/main/res/layout/item_donation_option.xml b/app/src/main/res/layout/item_donation_option.xml index 0016e144..ae5004d1 100644 --- a/app/src/main/res/layout/item_donation_option.xml +++ b/app/src/main/res/layout/item_donation_option.xml @@ -2,7 +2,7 @@ + android:foreground="?attr/rectSelector"> @@ -97,7 +97,7 @@ android:layout_width="match_parent" android:layout_height="1dp" android:layout_gravity="bottom" - android:background="?divider_color" + android:background="?attr/dividerColor" android:visibility="gone" /> + android:background="?attr/dividerColor" /> \ No newline at end of file diff --git a/app/src/main/res/layout/item_list_single_row.xml b/app/src/main/res/layout/item_list_single_row.xml index 47deed32..96fbf1e6 100644 --- a/app/src/main/res/layout/item_list_single_row.xml +++ b/app/src/main/res/layout/item_list_single_row.xml @@ -3,7 +3,7 @@ xmlns:tools="http://schemas.android.com/tools" android:layout_width="match_parent" android:layout_height="64dp" - android:foreground="?rect_selector" + android:foreground="?attr/rectSelector" tools:ignore="UnusedAttribute"> @@ -82,7 +82,7 @@ android:layout_width="match_parent" android:layout_height="1dp" android:layout_gravity="bottom" - android:background="?divider_color" + android:background="?attr/dividerColor" android:visibility="gone" /> + android:background="?attr/dividerColor" /> \ No newline at end of file diff --git a/app/src/main/res/layout/navigation_drawer_header.xml b/app/src/main/res/layout/navigation_drawer_header.xml index 30471b05..18753f20 100644 --- a/app/src/main/res/layout/navigation_drawer_header.xml +++ b/app/src/main/res/layout/navigation_drawer_header.xml @@ -5,7 +5,7 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:clickable="true" - android:foreground="?rect_selector"> + android:foreground="?attr/rectSelector"> - - \ No newline at end of file diff --git a/app/src/main/res/values/attrs.xml b/app/src/main/res/values/attrs.xml index 4e44979f..09e8c2fe 100644 --- a/app/src/main/res/values/attrs.xml +++ b/app/src/main/res/values/attrs.xml @@ -1,16 +1,14 @@ - + + - - - - + - - + + \ No newline at end of file diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml index 043352e0..95e0c7d1 100644 --- a/app/src/main/res/values/styles.xml +++ b/app/src/main/res/values/styles.xml @@ -10,14 +10,24 @@ @@ -90,13 +86,13 @@