From 1a8d20bde4bc7c557ce4542f4b02f2f8da81f8ba Mon Sep 17 00:00:00 2001 From: Karim Abou Zeid Date: Mon, 20 Apr 2015 00:08:02 +0200 Subject: [PATCH] Hopefully fixed the bitmap recycled issue by setting noCache() in playing notification and widget --- .../com/kabouzeid/gramophone/appwidget/MusicPlayerWidget.java | 1 + .../gramophone/helper/PlayingNotificationHelper.java | 1 + .../java/com/kabouzeid/gramophone/service/MusicService.java | 1 + .../gramophone/ui/activities/AlbumDetailActivity.java | 4 +--- .../gramophone/ui/activities/ArtistDetailActivity.java | 3 +-- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/app/src/main/java/com/kabouzeid/gramophone/appwidget/MusicPlayerWidget.java b/app/src/main/java/com/kabouzeid/gramophone/appwidget/MusicPlayerWidget.java index 23dd91e3..93a0cedb 100644 --- a/app/src/main/java/com/kabouzeid/gramophone/appwidget/MusicPlayerWidget.java +++ b/app/src/main/java/com/kabouzeid/gramophone/appwidget/MusicPlayerWidget.java @@ -62,6 +62,7 @@ public class MusicPlayerWidget extends AppWidgetProvider { if (albumArtTask != null) albumArtTask.cancel(); albumArtTask = Ion.with(context) .load(MusicUtil.getAlbumArtUri(song.albumId).toString()) + .noCache() .asBitmap() .setCallback(new FutureCallback() { @Override diff --git a/app/src/main/java/com/kabouzeid/gramophone/helper/PlayingNotificationHelper.java b/app/src/main/java/com/kabouzeid/gramophone/helper/PlayingNotificationHelper.java index 354c8f83..fa91ae85 100644 --- a/app/src/main/java/com/kabouzeid/gramophone/helper/PlayingNotificationHelper.java +++ b/app/src/main/java/com/kabouzeid/gramophone/helper/PlayingNotificationHelper.java @@ -155,6 +155,7 @@ public class PlayingNotificationHelper { if (albumArtTask != null) albumArtTask.cancel(); albumArtTask = Ion.with(service) .load(MusicUtil.getAlbumArtUri(song.albumId).toString()) + .noCache() .asBitmap() .setCallback(new FutureCallback() { @Override diff --git a/app/src/main/java/com/kabouzeid/gramophone/service/MusicService.java b/app/src/main/java/com/kabouzeid/gramophone/service/MusicService.java index c1dac3d9..a262b4cb 100644 --- a/app/src/main/java/com/kabouzeid/gramophone/service/MusicService.java +++ b/app/src/main/java/com/kabouzeid/gramophone/service/MusicService.java @@ -354,6 +354,7 @@ public class MusicService extends Service implements MediaPlayer.OnPreparedListe if (remoteControlClientAlbumArtTask != null) remoteControlClientAlbumArtTask.cancel(); remoteControlClientAlbumArtTask = Ion.with(this) .load(MusicUtil.getAlbumArtUri(song.albumId).toString()) + .noCache() .asBitmap() .setCallback(new FutureCallback() { @Override diff --git a/app/src/main/java/com/kabouzeid/gramophone/ui/activities/AlbumDetailActivity.java b/app/src/main/java/com/kabouzeid/gramophone/ui/activities/AlbumDetailActivity.java index 35834cc4..632257e8 100644 --- a/app/src/main/java/com/kabouzeid/gramophone/ui/activities/AlbumDetailActivity.java +++ b/app/src/main/java/com/kabouzeid/gramophone/ui/activities/AlbumDetailActivity.java @@ -175,10 +175,8 @@ public class AlbumDetailActivity extends AbsFabActivity implements PaletteColorH public void run() { Ion.with(AlbumDetailActivity.this) .load(MusicUtil.getAlbumArtUri(album.id).toString()) - .noCache() .withBitmap() - .resize(albumArtImageView.getWidth(), albumArtImageView.getHeight()) - .centerCrop() + .smartSize(false) .asBitmap() .setCallback(new FutureCallback() { @TargetApi(Build.VERSION_CODES.LOLLIPOP) diff --git a/app/src/main/java/com/kabouzeid/gramophone/ui/activities/ArtistDetailActivity.java b/app/src/main/java/com/kabouzeid/gramophone/ui/activities/ArtistDetailActivity.java index f49f7144..926aa6dd 100644 --- a/app/src/main/java/com/kabouzeid/gramophone/ui/activities/ArtistDetailActivity.java +++ b/app/src/main/java/com/kabouzeid/gramophone/ui/activities/ArtistDetailActivity.java @@ -271,8 +271,7 @@ public class ArtistDetailActivity extends AbsFabActivity implements PaletteColor Ion.with(ArtistDetailActivity.this) .load(url) .withBitmap() - .resize(artistImage.getWidth(), artistImage.getHeight()) - .centerCrop() + .smartSize(false) .asBitmap() .setCallback(new FutureCallback() { @Override