diff --git a/app/src/main/java/com/kabouzeid/gramophone/loader/LastAddedLoader.java b/app/src/main/java/com/kabouzeid/gramophone/loader/LastAddedLoader.java index b9540c19..40621a47 100644 --- a/app/src/main/java/com/kabouzeid/gramophone/loader/LastAddedLoader.java +++ b/app/src/main/java/com/kabouzeid/gramophone/loader/LastAddedLoader.java @@ -18,7 +18,7 @@ public class LastAddedLoader { } public static Cursor makeLastAddedCursor(@NonNull final Context context) { - long cutoff = PreferenceUtil.getInstance(context).getLastAddedCutoffTimeSecs(); + long cutoff = PreferenceUtil.getInstance(context).getLastAddedCutoff(); return SongLoader.makeSongCursor( context, diff --git a/app/src/main/java/com/kabouzeid/gramophone/loader/TopAndRecentlyPlayedTracksLoader.java b/app/src/main/java/com/kabouzeid/gramophone/loader/TopAndRecentlyPlayedTracksLoader.java index c3cd27f0..21a02f9d 100644 --- a/app/src/main/java/com/kabouzeid/gramophone/loader/TopAndRecentlyPlayedTracksLoader.java +++ b/app/src/main/java/com/kabouzeid/gramophone/loader/TopAndRecentlyPlayedTracksLoader.java @@ -26,7 +26,6 @@ import androidx.annotation.Nullable; import com.kabouzeid.gramophone.model.Song; import com.kabouzeid.gramophone.provider.HistoryStore; import com.kabouzeid.gramophone.provider.SongPlayCountStore; -import com.kabouzeid.gramophone.util.PreferenceUtil; import java.util.ArrayList; @@ -38,23 +37,6 @@ public class TopAndRecentlyPlayedTracksLoader { return SongLoader.getSongs(makeRecentTracksCursorAndClearUpDatabase(context)); } - @NonNull - public static ArrayList getNotRecentlyPlayedTracks -(@NonNull Context context) { - ArrayList allSongs = SongLoader.getSongs( - SongLoader.makeSongCursor( - context, - null, null, - MediaStore.Audio.Media.DATE_ADDED + " ASC")); - - ArrayList recentlyPlayedSongs = SongLoader.getSongs( - makeRecentTracksCursorAndClearUpDatabase(context)); - - allSongs.removeAll(recentlyPlayedSongs); - - return allSongs; - } - @NonNull public static ArrayList getTopTracks(@NonNull Context context) { return SongLoader.getSongs(makeTopTracksCursorAndClearUpDatabase(context)); @@ -95,8 +77,7 @@ public class TopAndRecentlyPlayedTracksLoader { @Nullable private static SortedLongCursor makeRecentTracksCursorImpl(@NonNull final Context context) { // first get the top results ids from the internal database - final long cutoff = PreferenceUtil.getInstance(context).getRecentlyPlayedCutoffTimeMillis(); - Cursor songs = HistoryStore.getInstance(context).queryRecentIds(cutoff); + Cursor songs = HistoryStore.getInstance(context).queryRecentIds(); try { return makeSortedCursor(context, songs, diff --git a/app/src/main/java/com/kabouzeid/gramophone/model/smartplaylist/NotRecentlyPlayedPlaylist.java b/app/src/main/java/com/kabouzeid/gramophone/model/smartplaylist/NotRecentlyPlayedPlaylist.java deleted file mode 100644 index f66da6f4..00000000 --- a/app/src/main/java/com/kabouzeid/gramophone/model/smartplaylist/NotRecentlyPlayedPlaylist.java +++ /dev/null @@ -1,68 +0,0 @@ -package com.kabouzeid.gramophone.model.smartplaylist; - -import android.content.Context; -import android.os.Parcel; -import androidx.annotation.NonNull; - -import com.kabouzeid.gramophone.R; -import com.kabouzeid.gramophone.loader.TopAndRecentlyPlayedTracksLoader; -import com.kabouzeid.gramophone.model.Song; -import com.kabouzeid.gramophone.util.MusicUtil; -import com.kabouzeid.gramophone.util.PreferenceUtil; - -import java.util.ArrayList; - -/** - * @author SC (soncaokim) - */ -public class NotRecentlyPlayedPlaylist extends AbsSmartPlaylist { - - public NotRecentlyPlayedPlaylist(@NonNull Context context) { - super(context.getString(R.string.not_recently_played), R.drawable.ic_watch_later_white_24dp); - } - - @NonNull - @Override - public String getInfoString(@NonNull Context context) { - String cutoff = PreferenceUtil.getInstance(context).getRecentlyPlayedCutoffText(context); - - return MusicUtil.buildInfoString( - cutoff, - super.getInfoString(context) - ); - } - - @NonNull - @Override - public ArrayList getSongs(@NonNull Context context) { - return TopAndRecentlyPlayedTracksLoader.getNotRecentlyPlayedTracks(context); - } - - @Override - public void clear(@NonNull Context context) { - } - - @Override - public boolean isClearable() { - return false; - } - - @Override - public int describeContents() { - return 0; - } - - protected NotRecentlyPlayedPlaylist(Parcel in) { - super(in); - } - - public static final Creator CREATOR = new Creator() { - public NotRecentlyPlayedPlaylist createFromParcel(Parcel source) { - return new NotRecentlyPlayedPlaylist(source); - } - - public NotRecentlyPlayedPlaylist[] newArray(int size) { - return new NotRecentlyPlayedPlaylist[size]; - } - }; -} diff --git a/app/src/main/java/com/kabouzeid/gramophone/provider/HistoryStore.java b/app/src/main/java/com/kabouzeid/gramophone/provider/HistoryStore.java index e099c7e2..af5b02da 100644 --- a/app/src/main/java/com/kabouzeid/gramophone/provider/HistoryStore.java +++ b/app/src/main/java/com/kabouzeid/gramophone/provider/HistoryStore.java @@ -25,7 +25,7 @@ import androidx.annotation.NonNull; import androidx.annotation.Nullable; public class HistoryStore extends SQLiteOpenHelper { - private static final int MAX_ITEMS_IN_DB = 5000; + private static final int MAX_ITEMS_IN_DB = 100; public static final String DATABASE_NAME = "history.db"; private static final int VERSION = 1; @@ -136,14 +136,10 @@ public class HistoryStore extends SQLiteOpenHelper { return containsId; } - public Cursor queryRecentIds(long cutoff) { + public Cursor queryRecentIds() { final SQLiteDatabase database = getReadableDatabase(); - return database.query(RecentStoreColumns.NAME, - new String[]{RecentStoreColumns.ID}, - RecentStoreColumns.TIME_PLAYED + ">?", - new String[]{String.valueOf(cutoff)}, - null, null, + new String[]{RecentStoreColumns.ID}, null, null, null, null, RecentStoreColumns.TIME_PLAYED + " DESC"); } diff --git a/app/src/main/java/com/kabouzeid/gramophone/ui/fragments/mainactivity/library/pager/PlaylistsFragment.java b/app/src/main/java/com/kabouzeid/gramophone/ui/fragments/mainactivity/library/pager/PlaylistsFragment.java index b71de632..54a92413 100644 --- a/app/src/main/java/com/kabouzeid/gramophone/ui/fragments/mainactivity/library/pager/PlaylistsFragment.java +++ b/app/src/main/java/com/kabouzeid/gramophone/ui/fragments/mainactivity/library/pager/PlaylistsFragment.java @@ -16,7 +16,6 @@ import com.kabouzeid.gramophone.model.Playlist; import com.kabouzeid.gramophone.model.smartplaylist.HistoryPlaylist; import com.kabouzeid.gramophone.model.smartplaylist.LastAddedPlaylist; import com.kabouzeid.gramophone.model.smartplaylist.MyTopTracksPlaylist; -import com.kabouzeid.gramophone.model.smartplaylist.NotRecentlyPlayedPlaylist; import java.util.ArrayList; @@ -81,7 +80,6 @@ public class PlaylistsFragment extends AbsLibraryPagerRecyclerViewFragmentIgnore Media Store covers Gapless playback Reduce volume on focus loss - Recently played playlist interval Last added playlist interval Show synchronized lyrics Remember last tab @@ -176,7 +175,6 @@ Last added Recently played My top tracks - Not recently played Remove cover Download from Last.fm Pick from local storage diff --git a/app/src/main/res/values/strings_activity_settings.xml b/app/src/main/res/values/strings_activity_settings.xml index 53990342..986a09da 100644 --- a/app/src/main/res/values/strings_activity_settings.xml +++ b/app/src/main/res/values/strings_activity_settings.xml @@ -24,28 +24,9 @@ never - - @string/today - @string/this_week - @string/past_seven_days - @string/this_month - @string/past_three_months - @string/this_year - - - - today - this_week - past_seven_days - this_month - past_three_months - this_year - - @string/today @string/this_week - @string/past_seven_days @string/this_month @string/past_three_months @string/this_year @@ -54,7 +35,6 @@ today this_week - past_seven_days this_month past_three_months this_year diff --git a/app/src/main/res/xml/pref_playlists.xml b/app/src/main/res/xml/pref_playlists.xml index 231dafe9..83f4c68e 100644 --- a/app/src/main/res/xml/pref_playlists.xml +++ b/app/src/main/res/xml/pref_playlists.xml @@ -4,16 +4,6 @@ - -