From dc551fc6cc20288e757ef60c92adaf5dfbb2db85 Mon Sep 17 00:00:00 2001 From: Karim Abou Zeid Date: Sat, 5 Sep 2015 13:04:45 +0200 Subject: [PATCH 1/4] Even though the Last.fm app and webpage say something is scrobbling, the scrobble doesn't actually get saved at the end. Fixes #59 --- app/src/main/assets/changelog.html | 3 +++ .../java/com/kabouzeid/gramophone/service/MusicService.java | 1 + 2 files changed, 4 insertions(+) diff --git a/app/src/main/assets/changelog.html b/app/src/main/assets/changelog.html index db61ef8d..4f8cb45c 100644 --- a/app/src/main/assets/changelog.html +++ b/app/src/main/assets/changelog.html @@ -29,6 +29,9 @@
  1. FIX: Fixed the plural typo in the artist list.
    2. +
  2. FIX: Even though the Last.fm app and webpage say something is scrobbling, the + scrobble doesn't actually get saved at the end. Thank Tim Malseed for that. +

Version 0.9.44 beta5

diff --git a/app/src/main/java/com/kabouzeid/gramophone/service/MusicService.java b/app/src/main/java/com/kabouzeid/gramophone/service/MusicService.java index bc4f635f..8df6cd85 100644 --- a/app/src/main/java/com/kabouzeid/gramophone/service/MusicService.java +++ b/app/src/main/java/com/kabouzeid/gramophone/service/MusicService.java @@ -822,6 +822,7 @@ public class MusicService extends Service implements SharedPreferences.OnSharedP internalIntent.putExtra("artist", currentSong.artistName); internalIntent.putExtra("album", currentSong.albumName); internalIntent.putExtra("track", currentSong.title); + internalIntent.putExtra("duration", currentSong.duration); } internalIntent.putExtra("playing", isPlaying()); sendStickyBroadcast(internalIntent); From 17e1e4165517461e41e013e6b0548b8b1f5311fb Mon Sep 17 00:00:00 2001 From: Karim Abou Zeid Date: Sat, 5 Sep 2015 13:29:23 +0200 Subject: [PATCH 2/4] Typo --- app/src/main/assets/changelog.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/assets/changelog.html b/app/src/main/assets/changelog.html index 4f8cb45c..e6abb02c 100644 --- a/app/src/main/assets/changelog.html +++ b/app/src/main/assets/changelog.html @@ -30,7 +30,7 @@
  1. FIX: Fixed the plural typo in the artist list.
  2. FIX: Even though the Last.fm app and webpage say something is scrobbling, the - scrobble doesn't actually get saved at the end. Thank Tim Malseed for that. + scrobble doesn't actually get saved at the end. Thanks to Tim Malseed for that.
From 64f6f0959560777d58659c7b24b11667bfa63c57 Mon Sep 17 00:00:00 2001 From: Karim Abou Zeid Date: Sat, 5 Sep 2015 13:43:55 +0200 Subject: [PATCH 3/4] Cleaned up the changelog. --- app/src/main/assets/changelog.html | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/app/src/main/assets/changelog.html b/app/src/main/assets/changelog.html index e6abb02c..406d7b4d 100644 --- a/app/src/main/assets/changelog.html +++ b/app/src/main/assets/changelog.html @@ -28,10 +28,10 @@

Version 0.9.44 beta6

    -
  1. FIX: Fixed the plural typo in the artist list.
    2. -
  2. FIX: Even though the Last.fm app and webpage say something is scrobbling, the - scrobble doesn't actually get saved at the end. Thanks to Tim Malseed for that. +
  3. FIX: Even though the Last.fm app and web page say something is scrobbling, the + scrobble doesn't actually get saved at the end. Thanks to Tim Malseed for that.
    4. +
  4. FIX: Fixed the plural typo in the artist list.

Version 0.9.44 beta5

@@ -41,8 +41,8 @@
  • FIX: Song detail dialog padding.
  • FIX: Sleep timer dialog retains its current time on rotate.
  • IMPROVEMENT: No longer "consume" purchases. This means that your donations are saved - from now on. I made this, so that just in case I make a paid version onetime in future, I - know who has already donated before so I can unlock the paid version for them. + from now on. I made this, so that just in case I make a paid version onetime in future, I + know who has already donated before so I can unlock the paid version for them.
    • @@ -70,8 +70,8 @@
      -
    1. IMPROVEMENT: Completely rewritten color chooser. Had great help from Aidan Follestad here once again. +
    2. IMPROVEMENT: Completely rewritten color chooser. Had great help from Aidan Follestad here once again.
    3. IMPROVEMENT: Increased album cover quality when selecting the "ignore media store covers" option. @@ -82,10 +82,8 @@
    4. FIX: Favorites playlist heart icon not showing up when initially added until restart.
      5. -
    5. FIX: Hopefully fixed the bug where the alternative progress slider always stayed - black on some devices. Please report if the bug is fixed at the Google+ - Community. +
    6. FIX: Fixed the bug where the alternative progress slider always stayed + black on some devices.
    From 767f6f0300212722ca3d77c61b7e07a1798f78da Mon Sep 17 00:00:00 2001 From: Karim Abou Zeid Date: Sat, 5 Sep 2015 14:11:44 +0200 Subject: [PATCH 4/4] Fixed missing toolbar shadow in the playlist view. --- app/src/main/assets/changelog.html | 1 + app/src/main/res/layout/activity_playlist_detail.xml | 1 + 2 files changed, 2 insertions(+) diff --git a/app/src/main/assets/changelog.html b/app/src/main/assets/changelog.html index 406d7b4d..22298fe2 100644 --- a/app/src/main/assets/changelog.html +++ b/app/src/main/assets/changelog.html @@ -32,6 +32,7 @@ scrobble doesn't actually get saved at the end. Thanks to Tim Malseed for that.
  • FIX: Fixed the plural typo in the artist list.
    • +
  • FIX: Toolbar had no shadow in the playlist view.

    • Version 0.9.44 beta5

    diff --git a/app/src/main/res/layout/activity_playlist_detail.xml b/app/src/main/res/layout/activity_playlist_detail.xml index e819800f..d94b68c7 100644 --- a/app/src/main/res/layout/activity_playlist_detail.xml +++ b/app/src/main/res/layout/activity_playlist_detail.xml @@ -13,6 +13,7 @@