diff --git a/app/src/main/java/com/dkanada/gramophone/preferences/NowPlayingScreenPreferenceDialog.java b/app/src/main/java/com/dkanada/gramophone/preferences/NowPlayingScreenPreferenceDialog.java index 7557ba7a..045e2a18 100644 --- a/app/src/main/java/com/dkanada/gramophone/preferences/NowPlayingScreenPreferenceDialog.java +++ b/app/src/main/java/com/dkanada/gramophone/preferences/NowPlayingScreenPreferenceDialog.java @@ -99,7 +99,7 @@ public class NowPlayingScreenPreferenceDialog extends DialogFragment implements ImageView image = layout.findViewById(R.id.image); TextView title = layout.findViewById(R.id.title); - image.setImageResource(nowPlayingScreen.drawableResId); + image.setImageResource(nowPlayingScreen.drawableRes); title.setText(nowPlayingScreen.titleRes); return layout; diff --git a/app/src/main/java/com/dkanada/gramophone/ui/fragments/AbsMusicServiceFragment.java b/app/src/main/java/com/dkanada/gramophone/ui/fragments/AbsMusicServiceFragment.java index d741cede..2697ce13 100644 --- a/app/src/main/java/com/dkanada/gramophone/ui/fragments/AbsMusicServiceFragment.java +++ b/app/src/main/java/com/dkanada/gramophone/ui/fragments/AbsMusicServiceFragment.java @@ -13,7 +13,7 @@ public class AbsMusicServiceFragment extends Fragment implements MusicServiceEve private AbsMusicServiceActivity activity; @Override - public void onAttach(Context context) { + public void onAttach(@NonNull Context context) { super.onAttach(context); try { activity = (AbsMusicServiceActivity) context; diff --git a/app/src/main/java/com/dkanada/gramophone/ui/fragments/mainactivity/library/LibraryFragment.java b/app/src/main/java/com/dkanada/gramophone/ui/fragments/mainactivity/library/LibraryFragment.java index ff21f7ec..e8ad8b20 100644 --- a/app/src/main/java/com/dkanada/gramophone/ui/fragments/mainactivity/library/LibraryFragment.java +++ b/app/src/main/java/com/dkanada/gramophone/ui/fragments/mainactivity/library/LibraryFragment.java @@ -56,7 +56,6 @@ import java.util.ArrayList; import java.util.List; public class LibraryFragment extends AbsMainActivityFragment implements CabHolder, MainActivity.MainActivityFragmentCallbacks, ViewPager.OnPageChangeListener, SharedPreferences.OnSharedPreferenceChangeListener { - private FragmentLibraryBinding binding; private MusicLibraryPagerAdapter pagerAdapter; @@ -70,7 +69,7 @@ public class LibraryFragment extends AbsMainActivityFragment implements CabHolde } @Override - public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { + public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { binding = FragmentLibraryBinding.inflate(inflater); return binding.getRoot(); @@ -84,7 +83,7 @@ public class LibraryFragment extends AbsMainActivityFragment implements CabHolde } @Override - public void onViewCreated(View view, @Nullable Bundle savedInstanceState) { + public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceState) { PreferenceUtil.getInstance(getActivity()).registerOnSharedPreferenceChangedListener(this); getMainActivity().setStatusbarColorAuto(); getMainActivity().setNavigationbarColorAuto(); @@ -110,27 +109,27 @@ public class LibraryFragment extends AbsMainActivityFragment implements CabHolde } private void setUpToolbar() { - int primaryColor = ThemeStore.primaryColor(getActivity()); + int primaryColor = ThemeStore.primaryColor(requireActivity()); binding.appbar.setBackgroundColor(primaryColor); binding.toolbar.setBackgroundColor(primaryColor); binding.toolbar.setNavigationIcon(R.drawable.ic_menu_white_24dp); - getActivity().setTitle(R.string.app_name); + requireActivity().setTitle(R.string.app_name); getMainActivity().setSupportActionBar(binding.toolbar); } private void setUpViewPager() { - pagerAdapter = new MusicLibraryPagerAdapter(getActivity(), getChildFragmentManager()); + pagerAdapter = new MusicLibraryPagerAdapter(requireActivity(), getChildFragmentManager()); binding.pager.setAdapter(pagerAdapter); binding.pager.setOffscreenPageLimit(pagerAdapter.getCount() - 1); binding.tabs.setupWithViewPager(binding.pager); - int primaryColor = ThemeStore.primaryColor(getActivity()); - int normalColor = ToolbarContentTintHelper.toolbarSubtitleColor(getActivity(), primaryColor); - int selectedColor = ToolbarContentTintHelper.toolbarTitleColor(getActivity(), primaryColor); + int primaryColor = ThemeStore.primaryColor(requireActivity()); + int normalColor = ToolbarContentTintHelper.toolbarSubtitleColor(requireActivity(), primaryColor); + int selectedColor = ToolbarContentTintHelper.toolbarTitleColor(requireActivity(), primaryColor); TabLayoutUtil.setTabIconColors(binding.tabs, normalColor, selectedColor); binding.tabs.setTabTextColors(normalColor, selectedColor); - binding.tabs.setSelectedTabIndicatorColor(ThemeStore.accentColor(getActivity())); + binding.tabs.setSelectedTabIndicatorColor(ThemeStore.accentColor(requireActivity())); updateTabVisibility(); @@ -161,7 +160,7 @@ public class LibraryFragment extends AbsMainActivityFragment implements CabHolde cab = new MaterialCab(getMainActivity(), R.id.cab_stub) .setMenu(menuRes) .setCloseDrawableRes(R.drawable.ic_close_white_24dp) - .setBackgroundColor(ThemeUtil.shiftBackgroundColorForLightText(ThemeStore.primaryColor(getActivity()))) + .setBackgroundColor(ThemeUtil.shiftBackgroundColorForLightText(ThemeStore.primaryColor(requireActivity()))) .start(callback); return cab; @@ -180,7 +179,7 @@ public class LibraryFragment extends AbsMainActivityFragment implements CabHolde } @Override - public void onCreateOptionsMenu(Menu menu, MenuInflater inflater) { + public void onCreateOptionsMenu(@NonNull Menu menu, @NonNull MenuInflater inflater) { super.onCreateOptionsMenu(menu, inflater); inflater.inflate(R.menu.menu_main, menu); if (isPlaylistPage()) { @@ -222,7 +221,7 @@ public class LibraryFragment extends AbsMainActivityFragment implements CabHolde } @Override - public void onPrepareOptionsMenu(Menu menu) { + public void onPrepareOptionsMenu(@NonNull Menu menu) { super.onPrepareOptionsMenu(menu); Activity activity = getActivity(); if (activity == null) return; @@ -256,7 +255,7 @@ public class LibraryFragment extends AbsMainActivityFragment implements CabHolde int id = item.getItemId(); switch (id) { case R.id.action_shuffle_all: - MusicPlayerRemote.openAndShuffleQueue(SongLoader.getAllSongs(getActivity()), true); + MusicPlayerRemote.openAndShuffleQueue(SongLoader.getAllSongs(requireActivity()), true); return true; case R.id.action_new_playlist: CreatePlaylistDialog.create().show(getChildFragmentManager(), "CREATE_PLAYLIST"); diff --git a/app/src/main/java/com/dkanada/gramophone/ui/fragments/mainactivity/library/pager/AbsLibraryPagerRecyclerViewCustomGridSizeFragment.java b/app/src/main/java/com/dkanada/gramophone/ui/fragments/mainactivity/library/pager/AbsLibraryPagerRecyclerViewCustomGridSizeFragment.java index 3814a2db..7ce7daa6 100644 --- a/app/src/main/java/com/dkanada/gramophone/ui/fragments/mainactivity/library/pager/AbsLibraryPagerRecyclerViewCustomGridSizeFragment.java +++ b/app/src/main/java/com/dkanada/gramophone/ui/fragments/mainactivity/library/pager/AbsLibraryPagerRecyclerViewCustomGridSizeFragment.java @@ -124,7 +124,7 @@ public abstract class AbsLibraryPagerRecyclerViewCustomGridSizeFragment= 21) { - return res.getDrawable(resId, theme); - } - - return VectorDrawableCompat.create(res, resId, theme); + return ResourcesCompat.getDrawable(res, resId, theme); } public static Drawable getTintedVectorDrawable(@NonNull Resources res, @DrawableRes int resId, @Nullable Resources.Theme theme, @ColorInt int color) { return TintHelper.createTintedDrawable(getVectorDrawable(res, resId, theme), color); } - public static Drawable getTintedVectorDrawable(@NonNull Context context, @DrawableRes int id, @ColorInt int color) { - return TintHelper.createTintedDrawable(getVectorDrawable(context.getResources(), id, context.getTheme()), color); + public static Drawable getTintedVectorDrawable(@NonNull Context context, @DrawableRes int resId, @ColorInt int color) { + return TintHelper.createTintedDrawable(getVectorDrawable(context.getResources(), resId, context.getTheme()), color); } - public static Drawable getVectorDrawable(@NonNull Context context, @DrawableRes int id) { - return getVectorDrawable(context.getResources(), id, context.getTheme()); + public static Drawable getVectorDrawable(@NonNull Context context, @DrawableRes int resId) { + return getVectorDrawable(context.getResources(), resId, context.getTheme()); } public static Drawable resolveDrawable(@NonNull Context context, @AttrRes int drawableAttr) { diff --git a/app/src/main/java/com/dkanada/gramophone/util/PreferenceUtil.java b/app/src/main/java/com/dkanada/gramophone/util/PreferenceUtil.java index e32cf56b..39cf523d 100644 --- a/app/src/main/java/com/dkanada/gramophone/util/PreferenceUtil.java +++ b/app/src/main/java/com/dkanada/gramophone/util/PreferenceUtil.java @@ -221,7 +221,7 @@ public final class PreferenceUtil { public void setAlbumSortOrder(final String sortOrder) { final SharedPreferences.Editor editor = mPreferences.edit(); editor.putString(ALBUM_SORT_ORDER, sortOrder); - editor.commit(); + editor.apply(); } public final String getSongSortOrder() { @@ -231,7 +231,7 @@ public final class PreferenceUtil { public void setSongSortOrder(final String sortOrder) { final SharedPreferences.Editor editor = mPreferences.edit(); editor.putString(SONG_SORT_ORDER, sortOrder); - editor.commit(); + editor.apply(); } public final String getAlbumSortMethod() { @@ -241,7 +241,7 @@ public final class PreferenceUtil { public void setAlbumSortMethod(final String sortMethod) { final SharedPreferences.Editor editor = mPreferences.edit(); editor.putString(ALBUM_SORT_METHOD, sortMethod); - editor.commit(); + editor.apply(); } public final String getSongSortMethod() { @@ -251,7 +251,7 @@ public final class PreferenceUtil { public void setSongSortMethod(final String sortMethod) { final SharedPreferences.Editor editor = mPreferences.edit(); editor.putString(SONG_SORT_METHOD, sortMethod); - editor.commit(); + editor.apply(); } public int getLastSleepTimerValue() {