From 94f6ed894578eeae6a48cba0e76cd185598b3958 Mon Sep 17 00:00:00 2001 From: bgaesslein Date: Thu, 10 Feb 2022 11:23:56 +0100 Subject: [PATCH] Prioritize artist over album artist for songs Currently, the album artist is used if set. IMHO this is the wrong choice as it will lead to "Various Artists" or similar being shown when playing tracks from a compilation. Changed the code to use first look for the artist tag instead. --- app/src/main/java/com/dkanada/gramophone/model/Song.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/src/main/java/com/dkanada/gramophone/model/Song.java b/app/src/main/java/com/dkanada/gramophone/model/Song.java index c983066a..3dbcb538 100644 --- a/app/src/main/java/com/dkanada/gramophone/model/Song.java +++ b/app/src/main/java/com/dkanada/gramophone/model/Song.java @@ -65,12 +65,12 @@ public class Song implements Parcelable { this.albumId = itemDto.getAlbumId(); this.albumName = itemDto.getAlbum(); - if (itemDto.getAlbumArtists().size() != 0) { - this.artistId = itemDto.getAlbumArtists().get(0).getId(); - this.artistName = itemDto.getAlbumArtists().get(0).getName(); - } else if (itemDto.getArtistItems().size() != 0) { + if (itemDto.getArtistItems().size() != 0) { this.artistId = itemDto.getArtistItems().get(0).getId(); this.artistName = itemDto.getArtistItems().get(0).getName(); + } else if (itemDto.getAlbumArtists().size() != 0) { + this.artistId = itemDto.getAlbumArtists().get(0).getId(); + this.artistName = itemDto.getAlbumArtists().get(0).getName(); } this.primary = itemDto.getAlbumPrimaryImageTag() != null ? albumId : null;