tenkuma/jamfish
tenkuma/jamfish
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

remove unused methods from base activity

Browse source
This commit is contained in:
dkanada 2021-04-24 18:13:06 +09:00
commit 469b99fd90
2 changed files with 2 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

22
app/src/main/java/com/dkanada/gramophone/activities/base/AbsBaseActivity.java
View file

@ -53,29 +53,11 @@ public abstract class AbsBaseActivity extends AbsThemeActivity {
if (hasPermissions != hadPermissions) {
hadPermissions = hasPermissions;
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
onHasPermissionsChanged(hasPermissions);
super.recreate();
}
}
}
protected void onHasPermissionsChanged(boolean hasPermissions) {
// implemented by sub classes
}
@Override
public boolean dispatchKeyEvent(@NonNull KeyEvent event) {
if (event.getKeyCode() == KeyEvent.KEYCODE_MENU && event.getAction() == KeyEvent.ACTION_UP) {
showOverflowMenu();
return true;
}
return super.dispatchKeyEvent(event);
}
protected void showOverflowMenu() {
}
@Nullable
protected String[] getPermissionsToRequest() {
return null;
}
@ -142,7 +124,7 @@ public abstract class AbsBaseActivity extends AbsThemeActivity {
}
hadPermissions = true;
onHasPermissionsChanged(true);
super.recreate();
}
}
}

7
app/src/main/java/com/dkanada/gramophone/activities/base/AbsMusicServiceActivity.java
View file

@ -187,13 +187,6 @@ public abstract class AbsMusicServiceActivity extends AbsBaseActivity implements
}
}
@Override
protected void onHasPermissionsChanged(boolean hasPermissions) {
// TODO is this method even required
super.onHasPermissionsChanged(hasPermissions);
}
@Nullable
@Override
protected String[] getPermissionsToRequest() {
return new String[]{Manifest.permission.READ_EXTERNAL_STORAGE, Manifest.permission.WRITE_EXTERNAL_STORAGE};