tenkuma/jamfish
tenkuma/jamfish
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fixed NPE when trying to load the artist image in the SearchAdapter

Browse source
This commit is contained in:
Karim Abou Zeid 2015-06-30 03:06:36 +02:00
commit 50460a6653
1 changed files with 13 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

16
app/src/main/java/com/kabouzeid/gramophone/adapter/SearchAdapter.java
View file

@ -17,6 +17,7 @@ import com.kabouzeid.gramophone.helper.MenuItemClickHelper;
import com.kabouzeid.gramophone.helper.MusicPlayerRemote; import com.kabouzeid.gramophone.helper.MusicPlayerRemote;
import com.kabouzeid.gramophone.lastfm.rest.LastFMRestClient; import com.kabouzeid.gramophone.lastfm.rest.LastFMRestClient;
import com.kabouzeid.gramophone.lastfm.rest.model.artistinfo.ArtistInfo; import com.kabouzeid.gramophone.lastfm.rest.model.artistinfo.ArtistInfo;
import com.kabouzeid.gramophone.lastfm.rest.model.artistinfo.Image;
import com.kabouzeid.gramophone.loader.AlbumLoader; import com.kabouzeid.gramophone.loader.AlbumLoader;
import com.kabouzeid.gramophone.loader.ArtistLoader; import com.kabouzeid.gramophone.loader.ArtistLoader;
import com.kabouzeid.gramophone.loader.SongLoader; import com.kabouzeid.gramophone.loader.SongLoader;
@ -47,15 +48,17 @@ public class SearchAdapter extends RecyclerView.Adapter<SearchAdapter.ViewHolder
private static final int ARTIST = 2; private static final int ARTIST = 2;
private static final int SONG = 3; private static final int SONG = 3;
private AppCompatActivity activity; private final AppCompatActivity activity;
private List results = Collections.emptyList(); private List results = Collections.emptyList();
private String query; private String query;
private LastFMRestClient lastFMRestClient; private final LastFMRestClient lastFMRestClient;
public SearchAdapter(AppCompatActivity activity) { public SearchAdapter(AppCompatActivity activity) {
this.activity = activity; this.activity = activity;
lastFMRestClient = new LastFMRestClient(activity);
} }
@SuppressWarnings("unchecked")
public void search(String query) { public void search(String query) {
this.query = query; this.query = query;
results = new ArrayList(); results = new ArrayList();
@ -125,7 +128,14 @@ public class SearchAdapter extends RecyclerView.Adapter<SearchAdapter.ViewHolder
@Override @Override
public void success(ArtistInfo artistInfo, Response response) { public void success(ArtistInfo artistInfo, Response response) {
if (artistInfo.getArtist() != null) { if (artistInfo.getArtist() != null) {
ImageLoader.getInstance().displayImage(artistInfo.getArtist().getImage().get(0).getText(), int thumbnailIndex = 0;
List<Image> images = artistInfo.getArtist().getImage();
if (images.size() > 2) {
thumbnailIndex = 2;
} else if (images.size() > 1) {
thumbnailIndex = 1;
}
ImageLoader.getInstance().displayImage(images.get(thumbnailIndex).getText(),
holder.image, holder.image,
new DisplayImageOptions.Builder() new DisplayImageOptions.Builder()
.cacheInMemory(true) .cacheInMemory(true)