tenkuma/jamfish
tenkuma/jamfish
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Optimized AbsThemeActivity recreate. Fixed wrong divider and overflow button colors on 4.1 devices. Replaced actionbar drawer toggle with a non moving menu drawable.

Browse source
This commit is contained in:
Karim Abou Zeid 2015-08-12 22:29:19 +02:00
commit 52c405120c
16 changed files with 96 additions and 65 deletions
Download patch file Download diff file Expand all files Collapse all files

BIN
app/src/main/res/drawable-hdpi/ic_menu_white_24dp.png Normal file
View file

Binary file not shown.
Side by side

After

Width:  |  Height:  |  Size: 116 B

BIN
app/src/main/res/drawable-mdpi/ic_menu_white_24dp.png Normal file
View file

Binary file not shown.
Side by side

After

Width:  |  Height:  |  Size: 99 B

BIN
app/src/main/res/drawable-xhdpi/ic_menu_white_24dp.png Normal file
View file

Binary file not shown.
Side by side

After

Width:  |  Height:  |  Size: 135 B

BIN
app/src/main/res/drawable-xxhdpi/ic_menu_white_24dp.png Normal file
View file

Binary file not shown.
Side by side

After

Width:  |  Height:  |  Size: 183 B

BIN
app/src/main/res/drawable-xxxhdpi/ic_menu_white_24dp.png Normal file
View file

Binary file not shown.
Side by side

After

Width:  |  Height:  |  Size: 235 B

3
app/src/main/res/layout/activity_artist_detail.xml
View file

@ -13,7 +13,8 @@
android:id="@+id/artist_image_background"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:scaleType="centerCrop" />
android:scaleType="centerCrop"
tools:ignore="ContentDescription" />
<com.kabouzeid.gramophone.views.SquareIfPlaceImageView
android:id="@+id/image"

4
app/src/main/res/layout/artist_detail_header.xml
View file

@ -12,8 +12,8 @@
<View
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_height="1dp"
android:layout_marginTop="-8dp"
android:background="?dividerHorizontal" />
android:background="?divider_color" />
</LinearLayout>

4
app/src/main/res/layout/item_list.xml
View file

@ -86,7 +86,7 @@
android:layout_width="match_parent"
android:layout_height="1dp"
android:layout_gravity="bottom"
android:background="?dividerHorizontal"
android:background="?divider_color"
android:visibility="gone" />
<View
@ -96,6 +96,6 @@
android:layout_gravity="bottom"
android:layout_marginLeft="72dp"
android:layout_marginStart="72dp"
android:background="?dividerHorizontal" />
android:background="?divider_color" />
</FrameLayout>

4
app/src/main/res/layout/item_list_single_row.xml
View file

@ -72,7 +72,7 @@
android:layout_width="match_parent"
android:layout_height="1dp"
android:layout_gravity="bottom"
android:background="?dividerHorizontal"
android:background="?divider_color"
android:visibility="gone" />
<View
@ -82,6 +82,6 @@
android:layout_gravity="bottom"
android:layout_marginLeft="72dp"
android:layout_marginStart="72dp"
android:background="?dividerHorizontal" />
android:background="?divider_color" />
</FrameLayout>

3
app/src/main/res/values/attrs.xml
View file

@ -10,4 +10,7 @@
<attr name="toolbarPopupTheme" format="reference" />
<attr name="icon_color" format="color" />
<attr name="divider_color" format="color" />
</resources>

4
app/src/main/res/values/colors.xml
View file

@ -2,11 +2,11 @@
<resources>
<!--light theme-->
<color name="music_controller_container_color">@android:color/white</color>
<color name="music_controller_container_color">@color/cardview_light_background</color>
<color name="default_bar_color">@color/grey_700</color>
<!--dark theme-->
<color name="music_controller_container_color_dark">@color/grey_800</color>
<color name="music_controller_container_color_dark">@color/cardview_dark_background</color>
<color name="default_bar_color_dark">@color/grey_900</color>
</resources>

1
app/src/main/res/values/styles.xml
View file

@ -34,7 +34,6 @@
<item name="android:layout_width">match_parent</item>
<item name="android:layout_height">?attr/actionBarSize</item>
<item name="android:theme">@style/ThemeOverlay.AppCompat.Dark.ActionBar</item>
<item name="android:minHeight">@dimen/abc_action_bar_default_height_material</item>
<item name="popupTheme">?toolbarPopupTheme</item>
<item name="android:elevation" tools:ignore="NewApi">@dimen/toolbar_elevation</item>
<item name="android:transitionName" tools:ignore="NewApi">toolbar</item>

10
app/src/main/res/values/styles_parents.xml
View file

@ -18,6 +18,9 @@
<item name="default_bar_color">@color/default_bar_color_dark</item>
<item name="divider_color">@color/md_divider_white</item>
<item name="icon_color">@color/secondary_text_default_material_dark</item>
<item name="toolbarPopupTheme">@style/ThemeOverlay.AppCompat</item>
<!-- FOR EVERYWHERE WE CANT OVERRIDE THE ACCENT COLOR-->
@ -40,6 +43,9 @@
<item name="default_bar_color">@color/default_bar_color</item>
<item name="divider_color">@color/md_divider_black</item>
<item name="icon_color">@color/secondary_text_default_material_light</item>
<item name="toolbarPopupTheme">@style/ThemeOverlay.AppCompat.Light</item>
<!-- FOR EVERYWHERE WE CANT OVERRIDE THE ACCENT COLOR-->
@ -67,12 +73,12 @@
</style>
<style name="OverFlowButtonParent">
<item name="android:tint">?android:textColorSecondary</item>
<item name="android:tint">?icon_color</item>
<item name="android:src">@drawable/abc_ic_menu_moreoverflow_mtrl_alpha</item>
<item name="android:padding">12dp</item>
<item name="android:layout_width">48dp</item>
<item name="android:layout_height">48dp</item>
<item name="android:scaleType">fitXY</item>
<!--<item name="android:scaleType">fitXY</item>-->
<item name="android:background">?round_selector</item>
<item name="android:layout_centerVertical">true</item>
<item name="android:focusableInTouchMode">false</item>