From 55146753f28893442d16a3381d8b7f3337854bcf Mon Sep 17 00:00:00 2001
From: Karim Abou Zeid <karim23697@gmail.com>
Date: Sat, 28 Apr 2018 00:55:27 +0200
Subject: [PATCH] Fix artist detail activity and a landscape bug

---
 .../gramophone/ui/activities/AlbumDetailActivity.java        | 5 ++++-
 app/src/main/res/layout/activity_album_detail.xml            | 4 ++--
 app/src/main/res/values-land/dimens.xml                      | 3 ++-
 app/src/main/res/values/dimens.xml                           | 3 ++-
 4 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/app/src/main/java/com/kabouzeid/gramophone/ui/activities/AlbumDetailActivity.java b/app/src/main/java/com/kabouzeid/gramophone/ui/activities/AlbumDetailActivity.java
index cb973303..7dbc0f96 100644
--- a/app/src/main/java/com/kabouzeid/gramophone/ui/activities/AlbumDetailActivity.java
+++ b/app/src/main/java/com/kabouzeid/gramophone/ui/activities/AlbumDetailActivity.java
@@ -157,7 +157,10 @@ public class AlbumDetailActivity extends AbsSlidingMusicPanelActivity implements
 
     private void setUpObservableListViewParams() {
         toolbarColor = DialogUtils.resolveColor(this, R.attr.defaultFooterColor);
-        headerViewHeight = getResources().getDimensionPixelSize(R.dimen.title_view_height);
+        headerViewHeight = getResources().getDimensionPixelSize(R.dimen.detail_header_height);
+        if (headerViewHeight == 0) {
+            albumArtImageView.setVisibility(View.GONE);
+        }
     }
 
     private void setUpViews() {
diff --git a/app/src/main/res/layout/activity_album_detail.xml b/app/src/main/res/layout/activity_album_detail.xml
index fe367e55..bb7032df 100644
--- a/app/src/main/res/layout/activity_album_detail.xml
+++ b/app/src/main/res/layout/activity_album_detail.xml
@@ -53,7 +53,7 @@
                 <LinearLayout
                     android:id="@+id/header"
                     android:layout_width="match_parent"
-                    android:layout_height="@dimen/title_view_height"
+                    android:layout_height="@dimen/detail_header_height"
                     android:background="?attr/defaultFooterColor"
                     android:elevation="@dimen/toolbar_elevation"
                     android:orientation="horizontal"
@@ -216,7 +216,7 @@
             <View
                 android:id="@+id/header_overlay"
                 android:layout_width="match_parent"
-                android:layout_height="@dimen/title_view_height"
+                android:layout_height="@dimen/detail_header_height"
                 android:elevation="@dimen/toolbar_elevation"
                 tools:ignore="UnusedAttribute" />
         </FrameLayout>
diff --git a/app/src/main/res/values-land/dimens.xml b/app/src/main/res/values-land/dimens.xml
index b970a9ad..0262c53c 100644
--- a/app/src/main/res/values-land/dimens.xml
+++ b/app/src/main/res/values-land/dimens.xml
@@ -1,5 +1,6 @@
 <resources>
-    <dimen name="title_view_height">0dp</dimen>
+    <dimen name="detail_header_height">0dp</dimen>
+    <dimen name="title_view_height">56dp</dimen>
 
     <dimen name="header_image_height">180dp</dimen>
 
diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml
index b3179870..6292c780 100644
--- a/app/src/main/res/values/dimens.xml
+++ b/app/src/main/res/values/dimens.xml
@@ -2,7 +2,8 @@
 
     <dimen name="default_item_margin">16dp</dimen>
 
-    <dimen name="title_view_height">176dp</dimen>
+    <dimen name="detail_header_height">176dp</dimen>
+    <dimen name="title_view_height">72dp</dimen>
     <dimen name="toolbar_elevation">4dp</dimen>
     <dimen name="card_elevation">2dp</dimen>