diff --git a/app/src/main/java/com/kabouzeid/gramophone/model/smartplaylist/HistoryPlaylist.java b/app/src/main/java/com/kabouzeid/gramophone/model/smartplaylist/HistoryPlaylist.java index 02cc93c3..69fef602 100644 --- a/app/src/main/java/com/kabouzeid/gramophone/model/smartplaylist/HistoryPlaylist.java +++ b/app/src/main/java/com/kabouzeid/gramophone/model/smartplaylist/HistoryPlaylist.java @@ -37,11 +37,6 @@ public class HistoryPlaylist extends AbsSmartPlaylist { return 0; } - @Override - public void writeToParcel(Parcel dest, int flags) { - super.writeToParcel(dest, flags); - } - protected HistoryPlaylist(Parcel in) { super(in); } diff --git a/app/src/main/java/com/kabouzeid/gramophone/model/smartplaylist/LastAddedPlaylist.java b/app/src/main/java/com/kabouzeid/gramophone/model/smartplaylist/LastAddedPlaylist.java index 9009632a..23735aa1 100644 --- a/app/src/main/java/com/kabouzeid/gramophone/model/smartplaylist/LastAddedPlaylist.java +++ b/app/src/main/java/com/kabouzeid/gramophone/model/smartplaylist/LastAddedPlaylist.java @@ -35,11 +35,6 @@ public class LastAddedPlaylist extends AbsSmartPlaylist { return 0; } - @Override - public void writeToParcel(Parcel dest, int flags) { - super.writeToParcel(dest, flags); - } - protected LastAddedPlaylist(Parcel in) { super(in); } diff --git a/app/src/main/java/com/kabouzeid/gramophone/model/smartplaylist/MyTopTracksPlaylist.java b/app/src/main/java/com/kabouzeid/gramophone/model/smartplaylist/MyTopTracksPlaylist.java index 444debf1..9607649f 100644 --- a/app/src/main/java/com/kabouzeid/gramophone/model/smartplaylist/MyTopTracksPlaylist.java +++ b/app/src/main/java/com/kabouzeid/gramophone/model/smartplaylist/MyTopTracksPlaylist.java @@ -37,11 +37,6 @@ public class MyTopTracksPlaylist extends AbsSmartPlaylist { return 0; } - @Override - public void writeToParcel(Parcel dest, int flags) { - super.writeToParcel(dest, flags); - } - protected MyTopTracksPlaylist(Parcel in) { super(in); } @@ -55,4 +50,4 @@ public class MyTopTracksPlaylist extends AbsSmartPlaylist { return new MyTopTracksPlaylist[size]; } }; -} \ No newline at end of file +} diff --git a/app/src/main/java/com/kabouzeid/gramophone/model/smartplaylist/ShuffleAllPlaylist.java b/app/src/main/java/com/kabouzeid/gramophone/model/smartplaylist/ShuffleAllPlaylist.java index bf8c818d..f20b4d5c 100644 --- a/app/src/main/java/com/kabouzeid/gramophone/model/smartplaylist/ShuffleAllPlaylist.java +++ b/app/src/main/java/com/kabouzeid/gramophone/model/smartplaylist/ShuffleAllPlaylist.java @@ -32,11 +32,6 @@ public class ShuffleAllPlaylist extends AbsSmartPlaylist { return 0; } - @Override - public void writeToParcel(Parcel dest, int flags) { - super.writeToParcel(dest, flags); - } - protected ShuffleAllPlaylist(Parcel in) { super(in); } diff --git a/app/src/main/java/com/kabouzeid/gramophone/ui/activities/SearchActivity.java b/app/src/main/java/com/kabouzeid/gramophone/ui/activities/SearchActivity.java index 41ca3433..fa84abbd 100644 --- a/app/src/main/java/com/kabouzeid/gramophone/ui/activities/SearchActivity.java +++ b/app/src/main/java/com/kabouzeid/gramophone/ui/activities/SearchActivity.java @@ -92,11 +92,6 @@ public class SearchActivity extends AbsMusicServiceActivity implements SearchVie outState.putString(QUERY, query); } - @Override - protected void onRestoreInstanceState(Bundle savedInstanceState) { - super.onRestoreInstanceState(savedInstanceState); - } - private void setUpToolBar() { toolbar.setBackgroundColor(ThemeStore.primaryColor(this)); setSupportActionBar(toolbar); diff --git a/app/src/main/java/com/kabouzeid/gramophone/ui/activities/base/AbsMusicServiceActivity.java b/app/src/main/java/com/kabouzeid/gramophone/ui/activities/base/AbsMusicServiceActivity.java index 8a0a3673..e8d8165f 100644 --- a/app/src/main/java/com/kabouzeid/gramophone/ui/activities/base/AbsMusicServiceActivity.java +++ b/app/src/main/java/com/kabouzeid/gramophone/ui/activities/base/AbsMusicServiceActivity.java @@ -32,7 +32,6 @@ public abstract class AbsMusicServiceActivity extends AbsBaseActivity implements private MusicStateReceiver musicStateReceiver; private boolean receiverRegistered; - @Override protected void onCreate(Bundle savedInstanceState) { super.onCreate(savedInstanceState); diff --git a/app/src/main/java/com/kabouzeid/gramophone/ui/activities/bugreport/BugReportActivity.java b/app/src/main/java/com/kabouzeid/gramophone/ui/activities/bugreport/BugReportActivity.java index 5e683c32..1668d915 100644 --- a/app/src/main/java/com/kabouzeid/gramophone/ui/activities/bugreport/BugReportActivity.java +++ b/app/src/main/java/com/kabouzeid/gramophone/ui/activities/bugreport/BugReportActivity.java @@ -260,18 +260,12 @@ public class BugReportActivity extends AbsThemeActivity { String bugTitle = inputTitle.getText().toString(); String bugDescription = inputDescription.getText().toString(); - ExtraInfo extraInfo = new ExtraInfo(); - onSaveExtraInfo(extraInfo); - - Report report = new Report(bugTitle, bugDescription, deviceInfo, extraInfo); + Report report = new Report(bugTitle, bugDescription, deviceInfo, new ExtraInfo()); GithubTarget target = new GithubTarget("kabouzeid", "Phonograph"); ReportIssueAsyncTask.report(this, report, target, login); } - protected void onSaveExtraInfo(ExtraInfo extraInfo) { - } - @Override public boolean onOptionsItemSelected(MenuItem item) { if (item.getItemId() == android.R.id.home) { diff --git a/app/src/main/java/com/kabouzeid/gramophone/ui/activities/bugreport/model/github/GithubLogin.java b/app/src/main/java/com/kabouzeid/gramophone/ui/activities/bugreport/model/github/GithubLogin.java index 97430f36..e3713172 100644 --- a/app/src/main/java/com/kabouzeid/gramophone/ui/activities/bugreport/model/github/GithubLogin.java +++ b/app/src/main/java/com/kabouzeid/gramophone/ui/activities/bugreport/model/github/GithubLogin.java @@ -3,10 +3,9 @@ package com.kabouzeid.gramophone.ui.activities.bugreport.model.github; import android.text.TextUtils; public class GithubLogin { + private final String username; - private final String password; - private final String apiToken; public GithubLogin(String username, String password) { diff --git a/app/src/main/java/com/kabouzeid/gramophone/ui/fragments/mainactivity/library/LibraryFragment.java b/app/src/main/java/com/kabouzeid/gramophone/ui/fragments/mainactivity/library/LibraryFragment.java index 1e11b85e..d98b7eb0 100644 --- a/app/src/main/java/com/kabouzeid/gramophone/ui/fragments/mainactivity/library/LibraryFragment.java +++ b/app/src/main/java/com/kabouzeid/gramophone/ui/fragments/mainactivity/library/LibraryFragment.java @@ -137,13 +137,13 @@ public class LibraryFragment extends AbsMainActivityFragment implements CabHolde tabs.setSelectedTabIndicatorColor(ThemeStore.accentColor(getActivity())); updateTabVisibility(); - + if (PreferenceUtil.getInstance(getContext()).rememberLastTab()) { pager.setCurrentItem(PreferenceUtil.getInstance(getContext()).getLastPage()); } pager.addOnPageChangeListener(this); } - + private void updateTabVisibility() { // hide the tab bar when only a single tab is visible tabs.setVisibility(pagerAdapter.getCount() == 1 ? View.GONE : View.VISIBLE); diff --git a/app/src/main/java/com/kabouzeid/gramophone/util/MusicUtil.java b/app/src/main/java/com/kabouzeid/gramophone/util/MusicUtil.java index bbebbbec..8fb469f0 100644 --- a/app/src/main/java/com/kabouzeid/gramophone/util/MusicUtil.java +++ b/app/src/main/java/com/kabouzeid/gramophone/util/MusicUtil.java @@ -45,8 +45,7 @@ public class MusicUtil { public static final String TAG = MusicUtil.class.getSimpleName(); public static Uri getMediaStoreAlbumCoverUri(int albumId) { - final Uri sArtworkUri = Uri - .parse("content://media/external/audio/albumart"); + final Uri sArtworkUri = Uri.parse("content://media/external/audio/albumart"); return ContentUris.withAppendedId(sArtworkUri, albumId); } @@ -58,7 +57,6 @@ public class MusicUtil { @NonNull public static Intent createShareSongFileIntent(@NonNull final Song song, Context context) { try { - return new Intent() .setAction(Intent.ACTION_SEND) .putExtra(Intent.EXTRA_STREAM, FileProvider.getUriForFile(context, context.getApplicationContext().getPackageName(), new File(song.data)))