Quick fixes

This commit is contained in:
Karim Abou Zeid 2015-03-23 23:35:05 +01:00
commit 7c206f5423
10 changed files with 33 additions and 41 deletions

View file

@ -17,14 +17,14 @@ repositories {
android { android {
compileSdkVersion 22 compileSdkVersion 22
buildToolsVersion "22" buildToolsVersion "22.0.1"
defaultConfig { defaultConfig {
applicationId "com.kabouzeid.gramophone" applicationId "com.kabouzeid.gramophone"
minSdkVersion 16 minSdkVersion 16
targetSdkVersion 22 targetSdkVersion 22
versionCode 3 versionCode 4
versionName "0.9.1b" versionName "0.9.2b"
} }
compileOptions { compileOptions {
@ -64,7 +64,4 @@ dependencies {
compile('com.crashlytics.sdk.android:crashlytics:2.2.1@aar') { compile('com.crashlytics.sdk.android:crashlytics:2.2.1@aar') {
transitive = true; transitive = true;
} }
compile('com.mikepenz.aboutlibraries:library:4.5.9@aar') {
transitive = true
}
} }

View file

@ -14,6 +14,7 @@ import android.widget.Toast;
import com.kabouzeid.gramophone.R; import com.kabouzeid.gramophone.R;
import com.kabouzeid.gramophone.helper.AddToPlaylistDialogHelper; import com.kabouzeid.gramophone.helper.AddToPlaylistDialogHelper;
import com.kabouzeid.gramophone.helper.DeleteSongsDialogHelper;
import com.kabouzeid.gramophone.helper.MusicPlayerRemote; import com.kabouzeid.gramophone.helper.MusicPlayerRemote;
import com.kabouzeid.gramophone.helper.SongDetailDialogHelper; import com.kabouzeid.gramophone.helper.SongDetailDialogHelper;
import com.kabouzeid.gramophone.loader.SongFilePathLoader; import com.kabouzeid.gramophone.loader.SongFilePathLoader;
@ -65,7 +66,7 @@ public class PlayingQueueAdapter extends ArrayAdapter<Song> {
public boolean onMenuItemClick(MenuItem item) { public boolean onMenuItemClick(MenuItem item) {
switch (item.getItemId()) { switch (item.getItemId()) {
case R.id.action_delete_from_disk: case R.id.action_delete_from_disk:
Toast.makeText(activity, "This feature is not available yet", Toast.LENGTH_SHORT).show(); DeleteSongsDialogHelper.getDialog(activity, song).show();
return true; return true;
case R.id.action_add_to_playlist: case R.id.action_add_to_playlist:
AddToPlaylistDialogHelper.getDialog(activity, song).show(); AddToPlaylistDialogHelper.getDialog(activity, song).show();

View file

@ -15,6 +15,7 @@ import android.widget.Toast;
import com.kabouzeid.gramophone.R; import com.kabouzeid.gramophone.R;
import com.kabouzeid.gramophone.helper.AddToPlaylistDialogHelper; import com.kabouzeid.gramophone.helper.AddToPlaylistDialogHelper;
import com.kabouzeid.gramophone.helper.DeleteSongsDialogHelper;
import com.kabouzeid.gramophone.helper.MusicPlayerRemote; import com.kabouzeid.gramophone.helper.MusicPlayerRemote;
import com.kabouzeid.gramophone.helper.SongDetailDialogHelper; import com.kabouzeid.gramophone.helper.SongDetailDialogHelper;
import com.kabouzeid.gramophone.loader.SongFilePathLoader; import com.kabouzeid.gramophone.loader.SongFilePathLoader;
@ -91,7 +92,7 @@ public class AlbumSongAdapter extends RecyclerView.Adapter<AlbumSongAdapter.View
public boolean onMenuItemClick(MenuItem item) { public boolean onMenuItemClick(MenuItem item) {
switch (item.getItemId()) { switch (item.getItemId()) {
case R.id.action_delete_from_disk: case R.id.action_delete_from_disk:
Toast.makeText(activity, "This feature is not available yet", Toast.LENGTH_SHORT).show(); DeleteSongsDialogHelper.getDialog(activity, dataSet.get(getAdapterPosition())).show();
return true; return true;
case R.id.action_add_to_playlist: case R.id.action_add_to_playlist:
AddToPlaylistDialogHelper.getDialog(activity, dataSet.get(getAdapterPosition())).show(); AddToPlaylistDialogHelper.getDialog(activity, dataSet.get(getAdapterPosition())).show();

View file

@ -15,6 +15,7 @@ import android.widget.Toast;
import com.kabouzeid.gramophone.R; import com.kabouzeid.gramophone.R;
import com.kabouzeid.gramophone.helper.AddToPlaylistDialogHelper; import com.kabouzeid.gramophone.helper.AddToPlaylistDialogHelper;
import com.kabouzeid.gramophone.helper.DeleteSongsDialogHelper;
import com.kabouzeid.gramophone.helper.MusicPlayerRemote; import com.kabouzeid.gramophone.helper.MusicPlayerRemote;
import com.kabouzeid.gramophone.helper.SongDetailDialogHelper; import com.kabouzeid.gramophone.helper.SongDetailDialogHelper;
import com.kabouzeid.gramophone.loader.SongFilePathLoader; import com.kabouzeid.gramophone.loader.SongFilePathLoader;
@ -70,7 +71,7 @@ public class ArtistSongAdapter extends ArrayAdapter<Song> {
public boolean onMenuItemClick(MenuItem item) { public boolean onMenuItemClick(MenuItem item) {
switch (item.getItemId()) { switch (item.getItemId()) {
case R.id.action_delete_from_disk: case R.id.action_delete_from_disk:
Toast.makeText(activity, "This feature is not available yet", Toast.LENGTH_SHORT).show(); DeleteSongsDialogHelper.getDialog(activity, song).show();
return true; return true;
case R.id.action_add_to_playlist: case R.id.action_add_to_playlist:
AddToPlaylistDialogHelper.getDialog(activity, song).show(); AddToPlaylistDialogHelper.getDialog(activity, song).show();

View file

@ -15,6 +15,7 @@ import android.widget.Toast;
import com.kabouzeid.gramophone.R; import com.kabouzeid.gramophone.R;
import com.kabouzeid.gramophone.helper.AddToPlaylistDialogHelper; import com.kabouzeid.gramophone.helper.AddToPlaylistDialogHelper;
import com.kabouzeid.gramophone.helper.DeleteSongsDialogHelper;
import com.kabouzeid.gramophone.helper.MusicPlayerRemote; import com.kabouzeid.gramophone.helper.MusicPlayerRemote;
import com.kabouzeid.gramophone.helper.SongDetailDialogHelper; import com.kabouzeid.gramophone.helper.SongDetailDialogHelper;
import com.kabouzeid.gramophone.loader.SongFilePathLoader; import com.kabouzeid.gramophone.loader.SongFilePathLoader;
@ -98,7 +99,7 @@ public class PlaylistSongAdapter extends RecyclerView.Adapter<PlaylistSongAdapte
public boolean onMenuItemClick(MenuItem item) { public boolean onMenuItemClick(MenuItem item) {
switch (item.getItemId()) { switch (item.getItemId()) {
case R.id.action_delete_from_disk: case R.id.action_delete_from_disk:
Toast.makeText(activity, "This feature is not available yet", Toast.LENGTH_SHORT).show(); DeleteSongsDialogHelper.getDialog(activity, dataSet.get(getAdapterPosition())).show();
return true; return true;
case R.id.action_add_to_playlist: case R.id.action_add_to_playlist:
AddToPlaylistDialogHelper.getDialog(activity, dataSet.get(getAdapterPosition())).show(); AddToPlaylistDialogHelper.getDialog(activity, dataSet.get(getAdapterPosition())).show();

View file

@ -39,7 +39,6 @@ import com.kabouzeid.gramophone.util.NavigationUtil;
import com.kabouzeid.gramophone.util.PreferenceUtils; import com.kabouzeid.gramophone.util.PreferenceUtils;
import com.kabouzeid.gramophone.util.Util; import com.kabouzeid.gramophone.util.Util;
import com.kabouzeid.gramophone.util.ViewUtil; import com.kabouzeid.gramophone.util.ViewUtil;
import com.mikepenz.aboutlibraries.Libs;
import com.squareup.picasso.Picasso; import com.squareup.picasso.Picasso;
@ -216,7 +215,7 @@ public class MainActivity extends AbsFabActivity
getMenuInflater().inflate(R.menu.menu_playlists, menu); getMenuInflater().inflate(R.menu.menu_playlists, menu);
break; break;
default: default:
getMenuInflater().inflate(R.menu.drawer, menu); getMenuInflater().inflate(R.menu.menu_main, menu);
break; break;
} }
restoreActionBar(); restoreActionBar();
@ -237,9 +236,6 @@ public class MainActivity extends AbsFabActivity
} }
int id = item.getItemId(); int id = item.getItemId();
switch (id) { switch (id) {
case R.id.action_licenses:
new Libs.Builder().withAutoDetect(true).start(this);
return true;
case R.id.action_new_playlist: case R.id.action_new_playlist:
CreatePlaylistDialogHelper.getDialog(this).show(); CreatePlaylistDialogHelper.getDialog(this).show();
return true; return true;

View file

@ -24,6 +24,7 @@ import com.kabouzeid.gramophone.App;
import com.kabouzeid.gramophone.R; import com.kabouzeid.gramophone.R;
import com.kabouzeid.gramophone.misc.AppKeys; import com.kabouzeid.gramophone.misc.AppKeys;
import com.kabouzeid.gramophone.misc.SmallObservableScrollViewCallbacks; import com.kabouzeid.gramophone.misc.SmallObservableScrollViewCallbacks;
import com.kabouzeid.gramophone.model.DataBaseChangedEvent;
import com.kabouzeid.gramophone.util.MusicUtil; import com.kabouzeid.gramophone.util.MusicUtil;
import com.kabouzeid.gramophone.util.Util; import com.kabouzeid.gramophone.util.Util;
import com.kabouzeid.gramophone.util.ViewUtil; import com.kabouzeid.gramophone.util.ViewUtil;
@ -362,7 +363,6 @@ public abstract class AbsTagEditorActivity extends ActionBarActivity {
} }
progressDialog.dismiss(); progressDialog.dismiss();
rescanMedia(); rescanMedia();
restartApp();
} }
}).start(); }).start();
} }
@ -370,14 +370,22 @@ public abstract class AbsTagEditorActivity extends ActionBarActivity {
private void rescanMedia() { private void rescanMedia() {
String[] toBeScanned = new String[songPaths.size()]; String[] toBeScanned = new String[songPaths.size()];
toBeScanned = songPaths.toArray(toBeScanned); toBeScanned = songPaths.toArray(toBeScanned);
MediaScannerConnection.scanFile(this, toBeScanned, null, null); MediaScannerConnection.scanFile(this, toBeScanned, null, new MediaScannerConnection.OnScanCompletedListener() {
} boolean refreshed;
@Override
private void restartApp() { public void onScanCompleted(String s, Uri uri) {
Intent i = getBaseContext().getPackageManager() runOnUiThread(new Runnable() {
.getLaunchIntentForPackage(getBaseContext().getPackageName()); @Override
i.addFlags(Intent.FLAG_ACTIVITY_CLEAR_TOP); public void run() {
startActivity(i); if(!refreshed) {
App.bus.post(new DataBaseChangedEvent(DataBaseChangedEvent.DATABASE_CHANGED));
}
refreshed = true;
}
});
}
});
finish();
} }
protected int getId() { protected int getId() {

View file

@ -146,8 +146,7 @@ public class MusicUtil {
cursor.close(); cursor.close();
} }
context.getContentResolver().notifyChange(Uri.parse("content://media"), null); context.getContentResolver().notifyChange(Uri.parse("content://media"), null);
Toast.makeText(context, "Deleted " + songs.size() + " songs", Toast.LENGTH_SHORT).show(); Toast.makeText(context, "Deleted " + songs.size() + " songs", Toast.LENGTH_SHORT).show(); //TODO add resource string
//TODO add resource string App.bus.post(new DataBaseChangedEvent(DataBaseChangedEvent.DATABASE_CHANGED));
App.bus.post(new DataBaseChangedEvent(DataBaseChangedEvent.SONGS_CHANGED));
} }
} }

View file

@ -28,15 +28,9 @@
android:title="@string/action_settings" android:title="@string/action_settings"
app:showAsAction="never"/> app:showAsAction="never"/>
<item
android:orderInCategory="101"
android:id="@+id/action_licenses"
android:title="Open Source Licenses"
app:showAsAction="never"/>
<item <item
android:id="@+id/action_about" android:id="@+id/action_about"
android:orderInCategory="102" android:orderInCategory="101"
android:title="@string/action_about" android:title="@string/action_about"
app:showAsAction="never"/> app:showAsAction="never"/>
</menu> </menu>

View file

@ -31,15 +31,9 @@
android:title="@string/action_settings" android:title="@string/action_settings"
app:showAsAction="never"/> app:showAsAction="never"/>
<item
android:id="@+id/action_licenses"
android:orderInCategory="101"
android:title="Open Source Licenses"
app:showAsAction="never"/>
<item <item
android:id="@+id/action_about" android:id="@+id/action_about"
android:orderInCategory="102" android:orderInCategory="101"
android:title="@string/action_about" android:title="@string/action_about"
app:showAsAction="never"/> app:showAsAction="never"/>
</menu> </menu>