From 8485bd3f8c06235459df88c0981bd2e21f71ffae Mon Sep 17 00:00:00 2001
From: dkanada <dkanada@users.noreply.github.com>
Date: Sun, 21 Feb 2021 12:07:29 +0900
Subject: [PATCH] fix some ide warnings

---
 .../main/res/layout/activity_album_detail.xml |  4 +--
 .../res/layout/activity_artist_detail.xml     |  8 ++---
 app/src/main/res/layout/card_about_app.xml    |  6 ++--
 app/src/main/res/layout/card_author.xml       | 12 +++++---
 .../res/layout/card_support_development.xml   |  5 +++-
 ...fragment_card_player_playback_controls.xml | 30 +++++++++----------
 ...fragment_flat_player_playback_controls.xml |  9 +++---
 app/src/main/res/layout/item_grid.xml         |  2 +-
 .../res/layout/item_grid_card_horizontal.xml  |  2 +-
 9 files changed, 42 insertions(+), 36 deletions(-)

diff --git a/app/src/main/res/layout/activity_album_detail.xml b/app/src/main/res/layout/activity_album_detail.xml
index 1033de3d..8175928a 100644
--- a/app/src/main/res/layout/activity_album_detail.xml
+++ b/app/src/main/res/layout/activity_album_detail.xml
@@ -52,7 +52,7 @@
                     android:scaleType="centerCrop"
                     android:src="@drawable/default_album_art"
                     android:transitionName="@string/transition_album_image"
-                    tools:ignore="ContentDescription,UnusedAttribute" />
+                    tools:ignore="ContentDescription" />
 
                 <LinearLayout
                     android:layout_width="match_parent"
@@ -77,7 +77,7 @@
                             android:layout_marginEnd="8dp"
                             android:layout_marginStart="0dp"
                             app:srcCompat="@drawable/ic_person_white_24dp"
-                            tools:ignore="ContentDescription,UnusedAttribute" />
+                            tools:ignore="ContentDescription" />
 
                         <TextView
                             android:ellipsize="end"
diff --git a/app/src/main/res/layout/activity_artist_detail.xml b/app/src/main/res/layout/activity_artist_detail.xml
index 2a960ac1..7af297e4 100644
--- a/app/src/main/res/layout/activity_artist_detail.xml
+++ b/app/src/main/res/layout/activity_artist_detail.xml
@@ -53,7 +53,7 @@
                     android:scaleType="centerCrop"
                     android:src="@drawable/default_artist_image"
                     android:transitionName="@string/transition_artist_image"
-                    tools:ignore="ContentDescription,UnusedAttribute" />
+                    tools:ignore="ContentDescription" />
 
                 <LinearLayout
                     android:layout_width="match_parent"
@@ -78,7 +78,7 @@
                             android:layout_marginEnd="8dp"
                             android:layout_marginStart="0dp"
                             app:srcCompat="@drawable/ic_album_white_24dp"
-                            tools:ignore="ContentDescription,UnusedAttribute" />
+                            tools:ignore="ContentDescription" />
 
                         <TextView
                             android:id="@+id/album_count_text"
@@ -104,7 +104,7 @@
                             android:layout_marginEnd="8dp"
                             android:layout_marginStart="0dp"
                             app:srcCompat="@drawable/ic_music_note_white_24dp"
-                            tools:ignore="ContentDescription,UnusedAttribute" />
+                            tools:ignore="ContentDescription" />
 
                         <TextView
                             android:id="@+id/song_count_text"
@@ -130,7 +130,7 @@
                             android:layout_marginEnd="8dp"
                             android:layout_marginStart="0dp"
                             app:srcCompat="@drawable/ic_timer_white_24dp"
-                            tools:ignore="ContentDescription,UnusedAttribute" />
+                            tools:ignore="ContentDescription" />
 
                         <TextView
                             android:id="@+id/duration_text"
diff --git a/app/src/main/res/layout/card_about_app.xml b/app/src/main/res/layout/card_about_app.xml
index 2fe3eca6..a53ba8f7 100644
--- a/app/src/main/res/layout/card_about_app.xml
+++ b/app/src/main/res/layout/card_about_app.xml
@@ -43,6 +43,7 @@
             android:layout_height="wrap_content"
             android:background="?attr/rectSelector"
             android:clickable="true"
+            android:focusable="true"
             android:gravity="center_vertical"
             android:minHeight="@dimen/md_listitem_height"
             android:orientation="horizontal"
@@ -54,7 +55,7 @@
                 android:layout_width="24dp"
                 android:layout_height="24dp"
                 app:srcCompat="@drawable/ic_info_outline_white_24dp"
-                tools:ignore="ContentDescription,UnusedAttribute" />
+                tools:ignore="ContentDescription" />
 
             <LinearLayout
                 android:layout_width="match_parent"
@@ -88,6 +89,7 @@
             android:layout_height="wrap_content"
             android:background="?attr/rectSelector"
             android:clickable="true"
+            android:focusable="true"
             android:gravity="center_vertical"
             android:minHeight="@dimen/md_listitem_height"
             android:orientation="horizontal"
@@ -99,7 +101,7 @@
                 android:layout_width="24dp"
                 android:layout_height="24dp"
                 app:srcCompat="@drawable/ic_github_circle_white_24dp"
-                tools:ignore="ContentDescription,UnusedAttribute" />
+                tools:ignore="ContentDescription" />
 
             <TextView
                 android:layout_width="wrap_content"
diff --git a/app/src/main/res/layout/card_author.xml b/app/src/main/res/layout/card_author.xml
index 9f0bbdf1..6b96b067 100644
--- a/app/src/main/res/layout/card_author.xml
+++ b/app/src/main/res/layout/card_author.xml
@@ -31,6 +31,7 @@
             android:layout_height="wrap_content"
             android:background="?attr/rectSelector"
             android:clickable="true"
+            android:focusable="true"
             android:gravity="center_vertical"
             android:minHeight="@dimen/md_listitem_height"
             android:orientation="horizontal"
@@ -42,7 +43,7 @@
                 android:layout_width="24dp"
                 android:layout_height="24dp"
                 app:srcCompat="@drawable/ic_person_white_24dp"
-                tools:ignore="ContentDescription,UnusedAttribute" />
+                tools:ignore="ContentDescription" />
 
             <LinearLayout
                 android:layout_width="match_parent"
@@ -75,6 +76,7 @@
             android:layout_height="wrap_content"
             android:background="?attr/rectSelector"
             android:clickable="true"
+            android:focusable="true"
             android:visibility="gone"
             android:gravity="center_vertical"
             android:minHeight="@dimen/md_listitem_height"
@@ -87,7 +89,7 @@
                 android:layout_width="24dp"
                 android:layout_height="24dp"
                 app:srcCompat="@drawable/ic_email_white_24dp"
-                tools:ignore="ContentDescription,UnusedAttribute" />
+                tools:ignore="ContentDescription" />
 
             <TextView
                 android:layout_width="wrap_content"
@@ -106,6 +108,7 @@
             android:layout_height="wrap_content"
             android:background="?attr/rectSelector"
             android:clickable="true"
+            android:focusable="true"
             android:visibility="gone"
             android:gravity="center_vertical"
             android:minHeight="@dimen/md_listitem_height"
@@ -118,7 +121,7 @@
                 android:layout_width="24dp"
                 android:layout_height="24dp"
                 app:srcCompat="@drawable/ic_twitter_white_24dp"
-                tools:ignore="ContentDescription,UnusedAttribute" />
+                tools:ignore="ContentDescription" />
 
             <TextView
                 android:layout_width="wrap_content"
@@ -137,6 +140,7 @@
             android:layout_height="wrap_content"
             android:background="?attr/rectSelector"
             android:clickable="true"
+            android:focusable="true"
             android:gravity="center_vertical"
             android:minHeight="@dimen/md_listitem_height"
             android:orientation="horizontal"
@@ -148,7 +152,7 @@
                 android:layout_width="24dp"
                 android:layout_height="24dp"
                 app:srcCompat="@drawable/ic_open_in_browser_white_24dp"
-                tools:ignore="ContentDescription,UnusedAttribute" />
+                tools:ignore="ContentDescription" />
 
             <TextView
                 android:layout_width="wrap_content"
diff --git a/app/src/main/res/layout/card_support_development.xml b/app/src/main/res/layout/card_support_development.xml
index 07a7ec08..3b1750f2 100644
--- a/app/src/main/res/layout/card_support_development.xml
+++ b/app/src/main/res/layout/card_support_development.xml
@@ -43,7 +43,7 @@
                 android:layout_width="24dp"
                 android:layout_height="24dp"
                 app:srcCompat="@drawable/ic_bug_report_white_24dp"
-                tools:ignore="ContentDescription,UnusedAttribute" />
+                tools:ignore="ContentDescription" />
 
             <LinearLayout
                 android:layout_width="match_parent"
@@ -75,6 +75,7 @@
             android:layout_height="wrap_content"
             android:background="?attr/rectSelector"
             android:clickable="true"
+            android:focusable="true"
             android:visibility="gone"
             android:gravity="center_vertical"
             android:minHeight="@dimen/md_listitem_height"
@@ -119,6 +120,7 @@
             android:layout_height="wrap_content"
             android:background="?attr/rectSelector"
             android:clickable="true"
+            android:focusable="true"
             android:visibility="gone"
             android:gravity="center_vertical"
             android:minHeight="@dimen/md_listitem_height"
@@ -163,6 +165,7 @@
             android:layout_height="wrap_content"
             android:background="?attr/rectSelector"
             android:clickable="true"
+            android:focusable="true"
             android:visibility="gone"
             android:gravity="center_vertical"
             android:minHeight="@dimen/md_listitem_height"
diff --git a/app/src/main/res/layout/fragment_card_player_playback_controls.xml b/app/src/main/res/layout/fragment_card_player_playback_controls.xml
index 5517d271..d8887091 100644
--- a/app/src/main/res/layout/fragment_card_player_playback_controls.xml
+++ b/app/src/main/res/layout/fragment_card_player_playback_controls.xml
@@ -18,13 +18,14 @@
             android:layout_height="match_parent"
             android:layout_alignParentStart="true"
             android:fontFamily="sans-serif-medium"
-            android:gravity="center_vertical|left|end"
-            android:paddingLeft="8dp"
+            android:gravity="center_vertical|start"
+            android:paddingStart="8dp"
             android:singleLine="true"
             android:textAppearance="@style/TextAppearance.AppCompat.Title"
             android:textColor="?android:textColorSecondary"
             android:textSize="12sp"
-            tools:ignore="RtlHardcoded,RtlSymmetry" />
+            tools:ignore="RtlSymmetry"
+            tools:text="0:00" />
 
         <TextView
             android:id="@+id/player_song_total_time"
@@ -32,13 +33,14 @@
             android:layout_height="match_parent"
             android:layout_alignParentEnd="true"
             android:fontFamily="sans-serif-medium"
-            android:gravity="center_vertical|right|end"
-            android:paddingRight="8dp"
+            android:gravity="center_vertical|end"
+            android:paddingEnd="8dp"
             android:singleLine="true"
             android:textAppearance="@style/TextAppearance.AppCompat.Title"
             android:textColor="?android:textColorSecondary"
             android:textSize="12sp"
-            tools:ignore="RtlHardcoded,RtlSymmetry" />
+            tools:ignore="RtlSymmetry"
+            tools:text="4:00" />
 
         <SeekBar
             android:id="@+id/player_progress_slider"
@@ -46,7 +48,7 @@
             android:layout_height="match_parent"
             android:layout_toStartOf="@id/player_song_total_time"
             android:layout_toEndOf="@id/player_song_current_progress"
-            tools:ignore="RtlHardcoded,UnusedAttribute" />
+            tools:ignore="RtlHardcoded" />
 
     </RelativeLayout>
 
@@ -55,7 +57,7 @@
         android:layout_width="match_parent"
         android:layout_height="@dimen/fab_media_controller_container_height"
         android:layoutDirection="ltr"
-        tools:ignore="ContentDescription,UnusedAttribute">
+        tools:ignore="ContentDescription">
 
         <ImageButton
             android:id="@+id/player_prev_button"
@@ -67,8 +69,7 @@
             android:background="?attr/roundSelector"
             android:padding="22dp"
             android:scaleType="fitCenter"
-            app:srcCompat="@drawable/ic_skip_previous_white_24dp"
-            tools:ignore="MissingPrefix" />
+            app:srcCompat="@drawable/ic_skip_previous_white_24dp" />
 
         <ImageButton
             android:id="@+id/player_next_button"
@@ -80,8 +81,7 @@
             android:background="?attr/roundSelector"
             android:padding="22dp"
             android:scaleType="fitCenter"
-            app:srcCompat="@drawable/ic_skip_next_white_24dp"
-            tools:ignore="MissingPrefix" />
+            app:srcCompat="@drawable/ic_skip_next_white_24dp" />
 
         <ImageButton
             android:id="@+id/player_repeat_button"
@@ -93,8 +93,7 @@
             android:background="?attr/roundSelector"
             android:padding="22dp"
             android:scaleType="fitCenter"
-            app:srcCompat="@drawable/ic_repeat_white_24dp"
-            tools:ignore="MissingPrefix" />
+            app:srcCompat="@drawable/ic_repeat_white_24dp" />
 
         <ImageButton
             android:id="@+id/player_shuffle_button"
@@ -106,8 +105,7 @@
             android:background="?attr/roundSelector"
             android:padding="22dp"
             android:scaleType="fitCenter"
-            app:srcCompat="@drawable/ic_shuffle_white_24dp"
-            tools:ignore="MissingPrefix" />
+            app:srcCompat="@drawable/ic_shuffle_white_24dp" />
 
         <Space
             android:id="@+id/dummy_fab"
diff --git a/app/src/main/res/layout/fragment_flat_player_playback_controls.xml b/app/src/main/res/layout/fragment_flat_player_playback_controls.xml
index bd3c0e24..24fa955a 100644
--- a/app/src/main/res/layout/fragment_flat_player_playback_controls.xml
+++ b/app/src/main/res/layout/fragment_flat_player_playback_controls.xml
@@ -33,13 +33,13 @@
             android:layout_height="match_parent"
             android:layout_alignParentEnd="true"
             android:fontFamily="sans-serif-medium"
-            android:gravity="center_vertical|right|end"
-            android:paddingRight="8dp"
+            android:gravity="center_vertical|end"
+            android:paddingEnd="8dp"
             android:singleLine="true"
             android:textAppearance="@style/TextAppearance.AppCompat.Title"
             android:textColor="@color/ate_primary_text_dark"
             android:textSize="12sp"
-            tools:ignore="RtlHardcoded,RtlSymmetry"
+            tools:ignore="RtlSymmetry"
             tools:text="3:14" />
 
         <SeekBar
@@ -47,8 +47,7 @@
             style="@style/MusicProgressSlider"
             android:layout_height="match_parent"
             android:layout_toStartOf="@id/player_song_total_time"
-            android:layout_toEndOf="@id/player_song_current_progress"
-            tools:ignore="RtlHardcoded,UnusedAttribute" />
+            android:layout_toEndOf="@id/player_song_current_progress" />
 
     </RelativeLayout>
 
diff --git a/app/src/main/res/layout/item_grid.xml b/app/src/main/res/layout/item_grid.xml
index f4917266..1ca49c7d 100644
--- a/app/src/main/res/layout/item_grid.xml
+++ b/app/src/main/res/layout/item_grid.xml
@@ -12,7 +12,7 @@
         android:layout_height="match_parent"
         android:gravity="center"
         android:orientation="vertical"
-        tools:ignore="UnusedAttribute,UselessParent">
+        tools:ignore="UselessParent">
 
         <com.dkanada.gramophone.views.WidthFitSquareLayout
             android:id="@+id/image_container"
diff --git a/app/src/main/res/layout/item_grid_card_horizontal.xml b/app/src/main/res/layout/item_grid_card_horizontal.xml
index a9b3457e..e18dd9af 100644
--- a/app/src/main/res/layout/item_grid_card_horizontal.xml
+++ b/app/src/main/res/layout/item_grid_card_horizontal.xml
@@ -17,7 +17,7 @@
             android:layout_width="104dp"
             android:layout_height="104dp"
             android:scaleType="centerCrop"
-            tools:ignore="ContentDescription,UnusedAttribute" />
+            tools:ignore="ContentDescription" />
 
         <LinearLayout
             android:layout_width="match_parent"