fix some ide warnings

This commit is contained in:
dkanada 2020-10-08 14:16:54 +09:00
commit 8eb4f515e3
13 changed files with 39 additions and 53 deletions

View file

@ -28,7 +28,7 @@ public class CategoryPreferenceDialog extends DialogFragment {
@NonNull
@Override
public Dialog onCreateDialog(Bundle savedInstanceState) {
View view = getActivity().getLayoutInflater().inflate(R.layout.preference_dialog_category, null);
View view = requireActivity().getLayoutInflater().inflate(R.layout.preference_dialog_category, null);
List<CategoryInfo> categories;
if (savedInstanceState != null) {
@ -45,7 +45,7 @@ public class CategoryPreferenceDialog extends DialogFragment {
adapter.attachToRecyclerView(recyclerView);
return new MaterialDialog.Builder(getContext())
return new MaterialDialog.Builder(requireActivity())
.title(R.string.library_categories)
.customView(view, false)
.positiveText(android.R.string.ok)

View file

@ -24,7 +24,7 @@ public class DirectPlayPreferenceDialog extends DialogFragment {
@NonNull
@Override
public Dialog onCreateDialog(Bundle savedInstanceState) {
View view = getActivity().getLayoutInflater().inflate(R.layout.preference_dialog_direct_play_codecs, null);
View view = requireActivity().getLayoutInflater().inflate(R.layout.preference_dialog_direct_play_codecs, null);
adapter = new DirectPlayCodecAdapter(PreferenceUtil.getInstance(getContext()).getDirectPlayCodecs());
@ -32,7 +32,7 @@ public class DirectPlayPreferenceDialog extends DialogFragment {
recyclerView.setLayoutManager(new LinearLayoutManager(getActivity()));
recyclerView.setAdapter(adapter);
return new MaterialDialog.Builder(getContext())
return new MaterialDialog.Builder(requireActivity())
.title(R.string.direct_play_codecs)
.customView(view, false)
.positiveText(android.R.string.ok)

View file

@ -36,7 +36,7 @@ public class NowPlayingScreenPreferenceDialog extends DialogFragment implements
@NonNull
@Override
public Dialog onCreateDialog(Bundle savedInstanceState) {
@SuppressLint("InflateParams") View view = LayoutInflater.from(getContext()).inflate(R.layout.preference_dialog_now_playing, null);
View view = LayoutInflater.from(getContext()).inflate(R.layout.preference_dialog_now_playing, null);
ViewPager viewPager = view.findViewById(R.id.now_playing_screen_view_pager);
viewPager.setAdapter(new NowPlayingScreenAdapter(getContext()));
viewPager.addOnPageChangeListener(this);
@ -47,7 +47,7 @@ public class NowPlayingScreenPreferenceDialog extends DialogFragment implements
pageIndicator.setViewPager(viewPager);
pageIndicator.onPageSelected(viewPager.getCurrentItem());
return new MaterialDialog.Builder(getContext())
return new MaterialDialog.Builder(requireActivity())
.title(R.string.pref_title_now_playing_screen_appearance)
.positiveText(android.R.string.ok)
.negativeText(android.R.string.cancel)
@ -62,7 +62,7 @@ public class NowPlayingScreenPreferenceDialog extends DialogFragment implements
}
@Override
public void onDismiss(DialogInterface dialog) {
public void onDismiss(@NonNull DialogInterface dialog) {
super.onDismiss(dialog);
if (whichButtonClicked == DialogAction.POSITIVE) {
PreferenceUtil.getInstance(getContext()).setNowPlayingScreen(NowPlayingScreen.values()[viewPagerPosition]);
@ -89,8 +89,8 @@ public class NowPlayingScreenPreferenceDialog extends DialogFragment implements
this.context = context;
}
@Override
@NonNull
@Override
public Object instantiateItem(@NonNull ViewGroup collection, int position) {
NowPlayingScreen nowPlayingScreen = NowPlayingScreen.values()[position];