diff --git a/app/src/main/java/com/dkanada/gramophone/activities/details/AlbumDetailActivity.java b/app/src/main/java/com/dkanada/gramophone/activities/details/AlbumDetailActivity.java index 2e0da8cf..4e59f5f2 100644 --- a/app/src/main/java/com/dkanada/gramophone/activities/details/AlbumDetailActivity.java +++ b/app/src/main/java/com/dkanada/gramophone/activities/details/AlbumDetailActivity.java @@ -210,22 +210,7 @@ public class AlbumDetailActivity extends AbsMusicContentActivity implements Pale .setMenu(menuRes) .setCloseDrawableRes(R.drawable.ic_close_white_24dp) .setBackgroundColor(ThemeUtil.shiftBackgroundColorForLightText(getPaletteColor())) - .start(new MaterialCab.Callback() { - @Override - public boolean onCabCreated(MaterialCab materialCab, Menu menu) { - return callback.onCabCreated(materialCab, menu); - } - - @Override - public boolean onCabItemClicked(MenuItem menuItem) { - return callback.onCabItemClicked(menuItem); - } - - @Override - public boolean onCabFinished(MaterialCab materialCab) { - return callback.onCabFinished(materialCab); - } - }); + .start(callback); return cab; } diff --git a/app/src/main/java/com/dkanada/gramophone/activities/details/ArtistDetailActivity.java b/app/src/main/java/com/dkanada/gramophone/activities/details/ArtistDetailActivity.java index 030d33c5..83d3167a 100644 --- a/app/src/main/java/com/dkanada/gramophone/activities/details/ArtistDetailActivity.java +++ b/app/src/main/java/com/dkanada/gramophone/activities/details/ArtistDetailActivity.java @@ -238,22 +238,7 @@ public class ArtistDetailActivity extends AbsMusicContentActivity implements Pal .setMenu(menuRes) .setCloseDrawableRes(R.drawable.ic_close_white_24dp) .setBackgroundColor(ThemeUtil.shiftBackgroundColorForLightText(getPaletteColor())) - .start(new MaterialCab.Callback() { - @Override - public boolean onCabCreated(MaterialCab materialCab, Menu menu) { - return callback.onCabCreated(materialCab, menu); - } - - @Override - public boolean onCabItemClicked(MenuItem menuItem) { - return callback.onCabItemClicked(menuItem); - } - - @Override - public boolean onCabFinished(MaterialCab materialCab) { - return callback.onCabFinished(materialCab); - } - }); + .start(callback); return cab; } diff --git a/app/src/main/java/com/dkanada/gramophone/activities/details/GenreDetailActivity.java b/app/src/main/java/com/dkanada/gramophone/activities/details/GenreDetailActivity.java index d11a6bf5..cbff21a5 100644 --- a/app/src/main/java/com/dkanada/gramophone/activities/details/GenreDetailActivity.java +++ b/app/src/main/java/com/dkanada/gramophone/activities/details/GenreDetailActivity.java @@ -74,7 +74,7 @@ public class GenreDetailActivity extends AbsMusicContentActivity implements CabH } private void setUpRecyclerView() { - ViewUtil.setUpFastScrollRecyclerViewColor(this, ((FastScrollRecyclerView) binding.recyclerView), ThemeStore.accentColor(this)); + ViewUtil.setUpFastScrollRecyclerViewColor(this, binding.recyclerView, ThemeStore.accentColor(this)); binding.recyclerView.setLayoutManager(new LinearLayoutManager(this)); adapter = new SongAdapter(this, new ArrayList<>(), R.layout.item_list, false, this); diff --git a/app/src/main/java/com/dkanada/gramophone/adapter/AlbumCoverPagerAdapter.java b/app/src/main/java/com/dkanada/gramophone/adapter/AlbumCoverPagerAdapter.java index 43db60df..3e0c1d72 100644 --- a/app/src/main/java/com/dkanada/gramophone/adapter/AlbumCoverPagerAdapter.java +++ b/app/src/main/java/com/dkanada/gramophone/adapter/AlbumCoverPagerAdapter.java @@ -17,7 +17,7 @@ import com.dkanada.gramophone.model.Song; import java.util.List; public class AlbumCoverPagerAdapter extends CustomFragmentStatePagerAdapter { - private List dataSet; + private final List dataSet; private AlbumCoverFragment.ColorReceiver currentColorReceiver; private int currentColorReceiverPosition = -1; diff --git a/app/src/main/java/com/dkanada/gramophone/adapter/MusicLibraryPagerAdapter.java b/app/src/main/java/com/dkanada/gramophone/adapter/MusicLibraryPagerAdapter.java index 980b0d44..7f5b3681 100644 --- a/app/src/main/java/com/dkanada/gramophone/adapter/MusicLibraryPagerAdapter.java +++ b/app/src/main/java/com/dkanada/gramophone/adapter/MusicLibraryPagerAdapter.java @@ -19,6 +19,8 @@ import com.dkanada.gramophone.fragments.library.PlaylistsFragment; import com.dkanada.gramophone.fragments.library.SongsFragment; import com.dkanada.gramophone.util.PreferenceUtil; +import org.jetbrains.annotations.NotNull; + import java.lang.ref.WeakReference; import java.util.ArrayList; import java.util.HashMap; @@ -31,7 +33,6 @@ public class MusicLibraryPagerAdapter extends FragmentPagerAdapter { private final List mHolderList = new ArrayList<>(); - @NonNull private final Context mContext; public MusicLibraryPagerAdapter(@NonNull final Context context, final FragmentManager fragmentManager) { @@ -99,15 +100,18 @@ public class MusicLibraryPagerAdapter extends FragmentPagerAdapter { return mFragment; } + @NotNull @Override public Fragment getItem(final int position) { final Holder mCurrentHolder = mHolderList.get(position); + return Fragment.instantiate(mContext, mCurrentHolder.mClassName, mCurrentHolder.mParams); } @Override - public void destroyItem(final ViewGroup container, final int position, final Object object) { + public void destroyItem(@NotNull ViewGroup container, int position, @NotNull Object object) { super.destroyItem(container, position, object); + final WeakReference mWeakFragment = mFragmentArray.get(position); if (mWeakFragment != null) { mWeakFragment.clear(); @@ -125,9 +129,6 @@ public class MusicLibraryPagerAdapter extends FragmentPagerAdapter { return mHolderList.get(position).title; } - /** - * Aligns the fragment cache with the current category layout. - */ private void alignCache() { if (mFragmentArray.size() == 0) return; @@ -176,7 +177,7 @@ public class MusicLibraryPagerAdapter extends FragmentPagerAdapter { } } - throw new IllegalArgumentException("Unknown music fragment " + cl); + throw new IllegalArgumentException(String.format("unknown music fragment: %s", cl)); } private static class All { diff --git a/app/src/main/java/com/dkanada/gramophone/adapter/PlaylistAdapter.java b/app/src/main/java/com/dkanada/gramophone/adapter/PlaylistAdapter.java index 67f3af6b..d1eb1f1d 100644 --- a/app/src/main/java/com/dkanada/gramophone/adapter/PlaylistAdapter.java +++ b/app/src/main/java/com/dkanada/gramophone/adapter/PlaylistAdapter.java @@ -63,11 +63,7 @@ public class PlaylistAdapter extends AbsMultiSelectAdapterSortierungsmethode Neue Wiedergabeliste Schwarz - Bilder Maximale Bitrate Warteschlange merken Maximale Listengröße @@ -170,8 +169,4 @@ Bitte update den Server auf die aktuellste Version. Die Datei konnte nicht geteilt werden. Transkodierungs-Codec - Das Feld darf nicht leer sein. - Server nicht erreichbar. - Authentifizierung fehlgeschlagen. - Keine Netzwerkverbindung verfügbar. diff --git a/app/src/main/res/values-fr/strings.xml b/app/src/main/res/values-fr/strings.xml index d15fb443..9f06c980 100644 --- a/app/src/main/res/values-fr/strings.xml +++ b/app/src/main/res/values-fr/strings.xml @@ -140,7 +140,6 @@ Année Impossible de contacter le serveur. Identifiants de connexion invalides. - Veuillez saisir l\'adresse du serveur. Une erreur inattendue s\'est produite. Ajouter à une playlist Ajouter à la liste de lecture @@ -160,7 +159,6 @@ Flat Déconnexion Nom - Images Enregistrer la liste de lecture à la fermeture de l\'application pour la conserver entre différentes utilisations. Le mode aléatoire sera conservé au choix d\'une nouvelle liste de titres pour la liste de lecture. Taille du cache @@ -177,5 +175,4 @@ Source Illimité Sélectionner tout - Veuillez saisir votre nom d\'utilisateur.