Preserve player toolbar state through all activities. Disabled double

tap to favorite.

app/src/main/java/com/kabouzeid/gramophone/ui/fragments/player/AbsPlayerFragment.java

@@ -2,6 +2,7 @@ package com.kabouzeid.gramophone.ui.fragments.player;
 
 import android.content.Context;
 import android.content.Intent;
+import android.support.annotation.Nullable;
 import android.support.v7.widget.Toolbar;
 import android.view.MenuItem;
 import android.view.View;
@@ -25,12 +26,11 @@ public abstract class AbsPlayerFragment extends AbsMusicServiceFragment implemen
     public static final String TAG = AbsPlayerFragment.class.getSimpleName();
 
     private Callbacks callbacks;
-    private boolean isToolbarVisible;
+    private static boolean isToolbarShown = true;
 
     @Override
     public void onAttach(Context context) {
         super.onAttach(context);
-        isToolbarVisible = true;
         try {
             callbacks = (Callbacks) context;
         } catch (ClassCastException e) {
@@ -91,14 +91,28 @@ public abstract class AbsPlayerFragment extends AbsMusicServiceFragment implemen
         MusicUtil.toggleFavorite(getActivity(), song);
     }
 
-    protected void toggleToolbar(final View toolbar) {
+    protected boolean isToolbarShown() {
+        return isToolbarShown;
+    }
+
+    protected void setToolbarShown(boolean toolbarShown) {
+        isToolbarShown = toolbarShown;
+    }
+
+    protected void showToolbar(@Nullable final View toolbar) {
         if (toolbar == null) return;
 
-        isToolbarVisible = !isToolbarVisible;
+        setToolbarShown(true);
-        if (isToolbarVisible) {
+
         toolbar.setVisibility(View.VISIBLE);
         toolbar.animate().alpha(1f).setDuration(PlayerAlbumCoverFragment.VISIBILITY_ANIM_DURATION);
-        } else {
+    }
+
+    protected void hideToolbar(@Nullable final View toolbar) {
+        if (toolbar == null) return;
+
+        setToolbarShown(false);
+
         toolbar.animate().alpha(0f).setDuration(PlayerAlbumCoverFragment.VISIBILITY_ANIM_DURATION).withEndAction(new Runnable() {
             @Override
             public void run() {
@@ -106,6 +120,21 @@ public abstract class AbsPlayerFragment extends AbsMusicServiceFragment implemen
             }
         });
     }
+
+    protected void toggleToolbar(@Nullable final View toolbar) {
+        if (isToolbarShown()) {
+            hideToolbar(toolbar);
+        } else {
+            showToolbar(toolbar);
+        }
+    }
+
+    protected void checkToggleToolbar(@Nullable final View toolbar) {
+        if (toolbar != null && !isToolbarShown() && toolbar.getVisibility() != View.GONE) {
+            hideToolbar(toolbar);
+        } else if (toolbar != null && isToolbarShown() && toolbar.getVisibility() != View.VISIBLE) {
+            showToolbar(toolbar);
+        }
     }
 
     protected String getUpNextAndQueueTime() {

app/src/main/java/com/kabouzeid/gramophone/ui/fragments/player/PlayerAlbumCoverFragment.java

@@ -79,15 +79,6 @@ public class PlayerAlbumCoverFragment extends AbsMusicServiceFragment implements
                     }
                     return super.onSingleTapConfirmed(e);
                 }
-
-                @Override
-                public boolean onDoubleTap(MotionEvent e) {
-                    if (callbacks != null) {
-                        callbacks.onFavoriteToggled();
-                        return true;
-                    }
-                    return super.onDoubleTap(e);
-                }
             });
 
             @Override

app/src/main/java/com/kabouzeid/gramophone/ui/fragments/player/card/CardPlayerFragment.java

@@ -171,6 +171,12 @@ public class CardPlayerFragment extends AbsPlayerFragment implements PlayerAlbum
         super.onPause();
     }
 
+    @Override
+    public void onResume() {
+        super.onResume();
+        checkToggleToolbar(toolbarContainer);
+    }
+
     @Override
     public void onServiceConnected() {
         updateQueue();

app/src/main/java/com/kabouzeid/gramophone/ui/fragments/player/flat/FlatPlayerFragment.java

@@ -166,6 +166,12 @@ public class FlatPlayerFragment extends AbsPlayerFragment implements PlayerAlbum
         super.onPause();
     }
 
+    @Override
+    public void onResume() {
+        super.onResume();
+        checkToggleToolbar(toolbarContainer);
+    }
+
     @Override
     public void onServiceConnected() {
         updateQueue();