From b500c83d321acdd7f55c6a674af08bc5d5f2faf1 Mon Sep 17 00:00:00 2001
From: dkanada <dkanada@users.noreply.github.com>
Date: Sun, 20 Jun 2021 16:07:47 +0900
Subject: [PATCH] remove references to dimensions from MaterialDialogs library

---
 app/src/main/res/layout/card_about_app.xml    |  4 ++--
 app/src/main/res/layout/card_author.xml       |  6 +++---
 .../res/layout/card_support_development.xml   |  8 ++++----
 .../preference_dialog_category_item.xml       | 20 +++++++++----------
 ...ference_dialog_direct_play_codecs_item.xml |  2 +-
 app/src/main/res/values/dimens.xml            |  6 ++++++
 6 files changed, 26 insertions(+), 20 deletions(-)

diff --git a/app/src/main/res/layout/card_about_app.xml b/app/src/main/res/layout/card_about_app.xml
index c346ac34..2594d5f7 100644
--- a/app/src/main/res/layout/card_about_app.xml
+++ b/app/src/main/res/layout/card_about_app.xml
@@ -45,7 +45,7 @@
             android:clickable="true"
             android:focusable="true"
             android:gravity="center_vertical"
-            android:minHeight="@dimen/md_listitem_height"
+            android:minHeight="@dimen/item_height"
             android:orientation="horizontal"
             android:paddingLeft="16dp"
             android:paddingRight="16dp">
@@ -90,7 +90,7 @@
             android:clickable="true"
             android:focusable="true"
             android:gravity="center_vertical"
-            android:minHeight="@dimen/md_listitem_height"
+            android:minHeight="@dimen/item_height"
             android:orientation="horizontal"
             android:paddingLeft="16dp"
             android:paddingRight="16dp">
diff --git a/app/src/main/res/layout/card_author.xml b/app/src/main/res/layout/card_author.xml
index e368321c..451baf96 100644
--- a/app/src/main/res/layout/card_author.xml
+++ b/app/src/main/res/layout/card_author.xml
@@ -33,7 +33,7 @@
             android:clickable="true"
             android:focusable="true"
             android:gravity="center_vertical"
-            android:minHeight="@dimen/md_listitem_height"
+            android:minHeight="@dimen/item_height"
             android:orientation="horizontal"
             android:paddingLeft="16dp"
             android:paddingRight="16dp">
@@ -79,7 +79,7 @@
             android:focusable="true"
             android:visibility="gone"
             android:gravity="center_vertical"
-            android:minHeight="@dimen/md_listitem_height"
+            android:minHeight="@dimen/item_height"
             android:orientation="horizontal"
             android:paddingLeft="16dp"
             android:paddingRight="16dp">
@@ -110,7 +110,7 @@
             android:clickable="true"
             android:focusable="true"
             android:gravity="center_vertical"
-            android:minHeight="@dimen/md_listitem_height"
+            android:minHeight="@dimen/item_height"
             android:orientation="horizontal"
             android:paddingLeft="16dp"
             android:paddingRight="16dp">
diff --git a/app/src/main/res/layout/card_support_development.xml b/app/src/main/res/layout/card_support_development.xml
index bd258c43..6a32ba76 100644
--- a/app/src/main/res/layout/card_support_development.xml
+++ b/app/src/main/res/layout/card_support_development.xml
@@ -34,7 +34,7 @@
             android:clickable="true"
             android:focusable="true"
             android:gravity="center_vertical"
-            android:minHeight="@dimen/md_listitem_height"
+            android:minHeight="@dimen/item_height"
             android:orientation="horizontal"
             android:paddingLeft="16dp"
             android:paddingRight="16dp">
@@ -79,7 +79,7 @@
             android:focusable="true"
             android:visibility="gone"
             android:gravity="center_vertical"
-            android:minHeight="@dimen/md_listitem_height"
+            android:minHeight="@dimen/item_height"
             android:orientation="horizontal"
             android:paddingLeft="16dp"
             android:paddingRight="16dp">
@@ -124,7 +124,7 @@
             android:focusable="true"
             android:visibility="gone"
             android:gravity="center_vertical"
-            android:minHeight="@dimen/md_listitem_height"
+            android:minHeight="@dimen/item_height"
             android:orientation="horizontal"
             android:paddingLeft="16dp"
             android:paddingRight="16dp">
@@ -169,7 +169,7 @@
             android:focusable="true"
             android:visibility="gone"
             android:gravity="center_vertical"
-            android:minHeight="@dimen/md_listitem_height"
+            android:minHeight="@dimen/item_height"
             android:orientation="horizontal"
             android:paddingLeft="16dp"
             android:paddingRight="16dp">
diff --git a/app/src/main/res/layout/preference_dialog_category_item.xml b/app/src/main/res/layout/preference_dialog_category_item.xml
index 2470fc56..0f5182f2 100644
--- a/app/src/main/res/layout/preference_dialog_category_item.xml
+++ b/app/src/main/res/layout/preference_dialog_category_item.xml
@@ -7,10 +7,10 @@
     android:descendantFocusability="blocksDescendants"
     android:focusable="true"
     android:foreground="?attr/rectSelector"
-    android:minHeight="@dimen/md_listitem_height"
+    android:minHeight="@dimen/item_height"
     android:orientation="horizontal"
-    android:paddingEnd="@dimen/md_dialog_frame_margin"
-    android:paddingStart="@dimen/md_dialog_frame_margin"
+    android:paddingEnd="@dimen/dialog_margin"
+    android:paddingStart="@dimen/dialog_margin"
     tools:ignore="UnusedAttribute"
     tools:gravity="start|center_vertical">
 
@@ -30,13 +30,13 @@
         android:layout_weight="1"
         android:ellipsize="end"
         android:gravity="center_vertical"
-        android:minHeight="@dimen/md_listitem_height"
-        android:paddingBottom="@dimen/md_listitem_vertical_margin_choice"
-        android:paddingEnd="@dimen/md_listitem_control_margin"
-        android:paddingStart="@dimen/md_listitem_control_margin"
-        android:paddingTop="@dimen/md_listitem_vertical_margin_choice"
+        android:minHeight="@dimen/item_height"
+        android:paddingBottom="@dimen/item_margin"
+        android:paddingEnd="@dimen/item_margin"
+        android:paddingStart="@dimen/item_margin"
+        android:paddingTop="@dimen/item_margin"
         android:singleLine="true"
-        android:textSize="@dimen/md_listitem_textsize"
+        android:textSize="@dimen/item_text"
         tools:text="Item" />
 
     <com.dkanada.gramophone.views.IconImageView
@@ -46,7 +46,7 @@
         android:layout_gravity="end|center_vertical"
         android:clickable="false"
         android:focusable="false"
-        android:minHeight="@dimen/md_listitem_height"
+        android:minHeight="@dimen/item_height"
         android:tint="?attr/iconColor"
         android:tintMode="src_in"
         app:srcCompat="@drawable/ic_drag_vertical_white_24dp"
diff --git a/app/src/main/res/layout/preference_dialog_direct_play_codecs_item.xml b/app/src/main/res/layout/preference_dialog_direct_play_codecs_item.xml
index 5cefdceb..51866b4e 100644
--- a/app/src/main/res/layout/preference_dialog_direct_play_codecs_item.xml
+++ b/app/src/main/res/layout/preference_dialog_direct_play_codecs_item.xml
@@ -31,7 +31,7 @@
         android:layout_margin="8dp"
         android:ellipsize="end"
         android:singleLine="true"
-        android:textSize="@dimen/md_listitem_textsize"
+        android:textSize="@dimen/item_text"
         app:layout_constraintStart_toEndOf="@id/checkbox"
         app:layout_constraintBottom_toBottomOf="parent"
         app:layout_constraintTop_toTopOf="parent"
diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml
index f5a9c6e4..d27cdb09 100644
--- a/app/src/main/res/values/dimens.xml
+++ b/app/src/main/res/values/dimens.xml
@@ -61,6 +61,12 @@ http://developer.android.com/guide/topics/appwidgets/index.html#CreatingLayout
     <dimen name="app_widget_card_buttons_width">128dp</dimen>
     <dimen name="app_widget_card_radius">4dp</dimen>
 
+    <dimen name="item_height">48dp</dimen>
+    <dimen name="item_margin">8dp</dimen>
+    <dimen name="item_text">16sp</dimen>
+
+    <dimen name="dialog_margin">24dp</dimen>
+
     <dimen name="card_on_app_bar_side_padding">8dp</dimen>
 
 </resources>