From c34407ad7fb5a9884adf8ca12640f57968e249a7 Mon Sep 17 00:00:00 2001 From: Karim Abou Zeid Date: Sat, 10 Oct 2015 16:16:12 +0200 Subject: [PATCH] Simplified a method --- .../kabouzeid/gramophone/ui/activities/MainActivity.java | 2 +- ...bsMainActivityRecyclerViewCustomGridSizeFragment.java | 2 +- .../main/java/com/kabouzeid/gramophone/util/Util.java | 9 +++++---- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/app/src/main/java/com/kabouzeid/gramophone/ui/activities/MainActivity.java b/app/src/main/java/com/kabouzeid/gramophone/ui/activities/MainActivity.java index 6c1e4d8a..ed7325d6 100644 --- a/app/src/main/java/com/kabouzeid/gramophone/ui/activities/MainActivity.java +++ b/app/src/main/java/com/kabouzeid/gramophone/ui/activities/MainActivity.java @@ -328,7 +328,7 @@ public class MainActivity extends AbsSlidingMusicPanelActivity AbsMainActivityRecyclerViewCustomGridSizeFragment absMainActivityRecyclerViewCustomGridSizeFragment = (AbsMainActivityRecyclerViewCustomGridSizeFragment) currentFragment; MenuItem gridSizeItem = menu.findItem(R.id.action_grid_size); - if (Util.isLandscape(this)) { + if (Util.isLandscape(getResources())) { gridSizeItem.setTitle(R.string.action_grid_size_land); } setUpGridSizeMenu(absMainActivityRecyclerViewCustomGridSizeFragment, gridSizeItem.getSubMenu()); diff --git a/app/src/main/java/com/kabouzeid/gramophone/ui/fragments/mainactivityfragments/AbsMainActivityRecyclerViewCustomGridSizeFragment.java b/app/src/main/java/com/kabouzeid/gramophone/ui/fragments/mainactivityfragments/AbsMainActivityRecyclerViewCustomGridSizeFragment.java index 03686c87..9d6157ed 100644 --- a/app/src/main/java/com/kabouzeid/gramophone/ui/fragments/mainactivityfragments/AbsMainActivityRecyclerViewCustomGridSizeFragment.java +++ b/app/src/main/java/com/kabouzeid/gramophone/ui/fragments/mainactivityfragments/AbsMainActivityRecyclerViewCustomGridSizeFragment.java @@ -112,6 +112,6 @@ public abstract class AbsMainActivityRecyclerViewCustomGridSizeFragment= 600; + public static boolean isTablet(@NonNull final Resources resources) { + return resources.getConfiguration().smallestScreenWidthDp >= 600; } - public static boolean isLandscape(@NonNull final Context context) { - return context.getResources().getConfiguration().orientation == Configuration.ORIENTATION_LANDSCAPE; + public static boolean isLandscape(@NonNull final Resources resources) { + return resources.getConfiguration().orientation == Configuration.ORIENTATION_LANDSCAPE; } public static Drawable resolveDrawable(@NonNull Context context, @AttrRes int drawableAttr) {