Fixed the check drawable getting black when on white background. Replaced the check drawable with lower dp. Moved two files to another package.

This commit is contained in:
Karim Abou Zeid 2015-04-22 12:41:33 +02:00
commit cc910143e1
19 changed files with 36 additions and 30 deletions

View file

@ -17,8 +17,8 @@ import com.kabouzeid.gramophone.dialogs.ColorChooserDialog;
import com.kabouzeid.gramophone.helper.MusicPlayerRemote; import com.kabouzeid.gramophone.helper.MusicPlayerRemote;
import com.kabouzeid.gramophone.misc.SmallOnGestureListener; import com.kabouzeid.gramophone.misc.SmallOnGestureListener;
import com.kabouzeid.gramophone.model.MusicRemoteEvent; import com.kabouzeid.gramophone.model.MusicRemoteEvent;
import com.kabouzeid.gramophone.ui.widget.PlayPauseDrawable;
import com.kabouzeid.gramophone.util.NavigationUtil; import com.kabouzeid.gramophone.util.NavigationUtil;
import com.kabouzeid.gramophone.views.PlayPauseDrawable;
import com.melnykov.fab.FloatingActionButton; import com.melnykov.fab.FloatingActionButton;
import com.squareup.otto.Subscribe; import com.squareup.otto.Subscribe;

View file

@ -34,7 +34,7 @@ public class CircleView extends FrameLayout {
super(context, attrs, defStyleAttr); super(context, attrs, defStyleAttr);
final int checkSize = (int) context.getResources().getDimension(R.dimen.circle_view_check); final int checkSize = (int) context.getResources().getDimension(R.dimen.circle_view_check);
mCheck = getResizedBitmap(BitmapFactory.decodeResource(context.getResources(), mCheck = getResizedBitmap(BitmapFactory.decodeResource(context.getResources(),
R.drawable.ic_check), checkSize, checkSize); R.drawable.ic_check_white_24dp), checkSize, checkSize);
borderWidth = (int) getResources().getDimension(R.dimen.circle_view_border); borderWidth = (int) getResources().getDimension(R.dimen.circle_view_border);
paint = new Paint(); paint = new Paint();
@ -55,7 +55,9 @@ public class CircleView extends FrameLayout {
Matrix matrix = new Matrix(); Matrix matrix = new Matrix();
matrix.postScale(scaleWidth, scaleHeight); matrix.postScale(scaleWidth, scaleHeight);
Bitmap resizedBitmap = Bitmap.createBitmap(bm, 0, 0, width, height, matrix, false); Bitmap resizedBitmap = Bitmap.createBitmap(bm, 0, 0, width, height, matrix, false);
if (bm != resizedBitmap) {
bm.recycle(); bm.recycle();
}
return resizedBitmap; return resizedBitmap;
} }
@ -78,6 +80,7 @@ public class CircleView extends FrameLayout {
int heightMode = MeasureSpec.getMode(heightMeasureSpec); int heightMode = MeasureSpec.getMode(heightMeasureSpec);
if (widthMode == MeasureSpec.EXACTLY && heightMode != MeasureSpec.EXACTLY) { if (widthMode == MeasureSpec.EXACTLY && heightMode != MeasureSpec.EXACTLY) {
int width = MeasureSpec.getSize(widthMeasureSpec); int width = MeasureSpec.getSize(widthMeasureSpec);
//noinspection SuspiciousNameCombination
int height = width; int height = width;
if (heightMode == MeasureSpec.AT_MOST) { if (heightMode == MeasureSpec.AT_MOST) {
height = Math.min(height, MeasureSpec.getSize(heightMeasureSpec)); height = Math.min(height, MeasureSpec.getSize(heightMeasureSpec));
@ -88,6 +91,7 @@ public class CircleView extends FrameLayout {
} }
} }
@Override @Override
protected void onDraw(Canvas canvas) { protected void onDraw(Canvas canvas) {
super.onDraw(canvas); super.onDraw(canvas);
@ -102,10 +106,12 @@ public class CircleView extends FrameLayout {
if (isActivated()) { if (isActivated()) {
final int offset = (canvasSize / 2) - (mCheck.getWidth() / 2); final int offset = (canvasSize / 2) - (mCheck.getWidth() / 2);
if (paint.getColor() == Color.WHITE && paintCheck == null) { if (paint.getColor() == Color.WHITE) {
if (paintCheck == null) {
paintCheck = new Paint(); paintCheck = new Paint();
paintCheck.setAntiAlias(true); paintCheck.setAntiAlias(true);
paintCheck.setColorFilter(new PorterDuffColorFilter(Color.BLACK, PorterDuff.Mode.SRC_IN)); paintCheck.setColorFilter(new PorterDuffColorFilter(Color.BLACK, PorterDuff.Mode.SRC_IN));
}
} else { } else {
paintCheck = null; paintCheck = null;
} }

View file

@ -1,4 +1,4 @@
package com.kabouzeid.gramophone.ui.widget; package com.kabouzeid.gramophone.views;
import android.animation.Animator; import android.animation.Animator;
import android.animation.AnimatorListenerAdapter; import android.animation.AnimatorListenerAdapter;

View file

@ -1,4 +1,4 @@
package com.kabouzeid.gramophone.ui.widget; package com.kabouzeid.gramophone.views;
import android.content.Context; import android.content.Context;
import android.util.AttributeSet; import android.util.AttributeSet;

Binary file not shown.

Before

Width:  |  Height:  |  Size: 1.1 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 248 B

Binary file not shown.

Before

Width:  |  Height:  |  Size: 613 B

Binary file not shown.

After

Width:  |  Height:  |  Size: 180 B

Binary file not shown.

Before

Width:  |  Height:  |  Size: 1.3 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 297 B

Binary file not shown.

Before

Width:  |  Height:  |  Size: 2.2 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 407 B

Binary file not shown.

After

Width:  |  Height:  |  Size: 516 B

View file

@ -15,7 +15,7 @@
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="match_parent"> android:layout_height="match_parent">
<com.kabouzeid.gramophone.ui.widget.SquareImageView <com.kabouzeid.gramophone.views.SquareImageView
android:id="@+id/image" android:id="@+id/image"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="match_parent" android:layout_height="match_parent"

View file

@ -15,7 +15,7 @@
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="match_parent"> android:layout_height="match_parent">
<com.kabouzeid.gramophone.ui.widget.SquareImageView <com.kabouzeid.gramophone.views.SquareImageView
android:id="@+id/image" android:id="@+id/image"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="match_parent" android:layout_height="match_parent"

View file

@ -15,7 +15,7 @@
android:orientation="vertical" android:orientation="vertical"
tools:ignore="UnusedAttribute,UselessParent"> tools:ignore="UnusedAttribute,UselessParent">
<com.kabouzeid.gramophone.ui.widget.SquareImageView <com.kabouzeid.gramophone.views.SquareImageView
android:id="@+id/album_art" android:id="@+id/album_art"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="match_parent" android:layout_height="match_parent"

View file

@ -12,7 +12,7 @@
android:paddingLeft="16dp" android:paddingLeft="16dp"
android:paddingStart="16dp"> android:paddingStart="16dp">
<com.kabouzeid.gramophone.ui.widget.SquareImageView <com.kabouzeid.gramophone.views.SquareImageView
android:id="@+id/album_art" android:id="@+id/album_art"
android:layout_width="40dp" android:layout_width="40dp"
android:layout_height="40dp" android:layout_height="40dp"

View file

@ -8,7 +8,7 @@
android:paddingLeft="16dp" android:paddingLeft="16dp"
android:paddingStart="16dp"> android:paddingStart="16dp">
<com.kabouzeid.gramophone.ui.widget.SquareImageView <com.kabouzeid.gramophone.views.SquareImageView
android:id="@+id/image" android:id="@+id/image"
android:layout_width="40dp" android:layout_width="40dp"
android:layout_height="40dp" android:layout_height="40dp"

View file

@ -13,7 +13,7 @@
android:paddingLeft="16dp" android:paddingLeft="16dp"
android:paddingStart="16dp"> android:paddingStart="16dp">
<com.kabouzeid.gramophone.ui.widget.SquareImageView <com.kabouzeid.gramophone.views.SquareImageView
android:id="@+id/album_art" android:id="@+id/album_art"
android:layout_width="40dp" android:layout_width="40dp"
android:layout_height="40dp" android:layout_height="40dp"