tenkuma/jamfish
tenkuma/jamfish
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor: mark TRACK_ENDED as unused (with FIXME)

Browse source
This commit is contained in:
Jakob Kukla 2021-11-15 23:55:32 +01:00
commit d59f63b0bf
1 changed files with 2 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

7
app/src/main/java/com/dkanada/gramophone/service/MusicService.java
View file

@ -103,7 +103,6 @@ public class MusicService extends Service implements SharedPreferences.OnSharedP
public static final int TRACK_CHANGED = 1; public static final int TRACK_CHANGED = 1;
public static final int TRACK_ENDED = 2; public static final int TRACK_ENDED = 2;
public static final int RELEASE_WAKELOCK = 0;
public static final int PLAY_SONG = 3; public static final int PLAY_SONG = 3;
public static final int PREPARE_NEXT = 4; public static final int PREPARE_NEXT = 4;
@ -797,6 +796,8 @@ public class MusicService extends Service implements SharedPreferences.OnSharedP
break; break;
case TRACK_ENDED: case TRACK_ENDED:
// FIXME This isn't used anywhere. This means releaseWakeLock() is never called
// if there is a timer finished, don't continue // if there is a timer finished, don't continue
if (service.pendingQuit || service.queueManager.getRepeatMode() == QueueManager.REPEAT_MODE_NONE && service.queueManager.isLastTrack()) { if (service.pendingQuit || service.queueManager.getRepeatMode() == QueueManager.REPEAT_MODE_NONE && service.queueManager.isLastTrack()) {
service.notifyChange(STATE_CHANGED); service.notifyChange(STATE_CHANGED);
@ -810,10 +811,6 @@ public class MusicService extends Service implements SharedPreferences.OnSharedP
service.playNextSong(false); service.playNextSong(false);
} }
sendEmptyMessage(RELEASE_WAKELOCK);
break;
case RELEASE_WAKELOCK:
service.releaseWakeLock(); service.releaseWakeLock();
break; break;