From d75be393d7c295452662d10f2b7d057583281dac Mon Sep 17 00:00:00 2001 From: Karim Abou Zeid Date: Sat, 30 Dec 2017 18:38:04 +0100 Subject: [PATCH] Clean up --- .../com/kabouzeid/gramophone/model/CategoryInfo.java | 2 +- .../preferences/LibraryPreferenceDialog.java | 10 +++++++--- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/app/src/main/java/com/kabouzeid/gramophone/model/CategoryInfo.java b/app/src/main/java/com/kabouzeid/gramophone/model/CategoryInfo.java index a074d43f..eebdb0dc 100644 --- a/app/src/main/java/com/kabouzeid/gramophone/model/CategoryInfo.java +++ b/app/src/main/java/com/kabouzeid/gramophone/model/CategoryInfo.java @@ -14,7 +14,7 @@ public class CategoryInfo implements Parcelable { this.visible = visible; } - public CategoryInfo(Parcel source) { + private CategoryInfo(Parcel source) { category = (Category) source.readSerializable(); visible = source.readInt() == 1; } diff --git a/app/src/main/java/com/kabouzeid/gramophone/preferences/LibraryPreferenceDialog.java b/app/src/main/java/com/kabouzeid/gramophone/preferences/LibraryPreferenceDialog.java index 9cec5581..53a808fe 100644 --- a/app/src/main/java/com/kabouzeid/gramophone/preferences/LibraryPreferenceDialog.java +++ b/app/src/main/java/com/kabouzeid/gramophone/preferences/LibraryPreferenceDialog.java @@ -29,9 +29,13 @@ public class LibraryPreferenceDialog extends DialogFragment { public Dialog onCreateDialog(Bundle savedInstanceState) { View view = getActivity().getLayoutInflater().inflate(R.layout.preference_dialog_library_categories, null); - adapter = new CategoryInfoAdapter(savedInstanceState != null ? - savedInstanceState.getParcelableArrayList(PreferenceUtil.LIBRARY_CATEGORIES) : - PreferenceUtil.getInstance(getContext()).getLibraryCategoryInfos()); + ArrayList categoryInfos; + if (savedInstanceState != null) { + categoryInfos = savedInstanceState.getParcelableArrayList(PreferenceUtil.LIBRARY_CATEGORIES); + } else { + categoryInfos = PreferenceUtil.getInstance(getContext()).getLibraryCategoryInfos(); + } + adapter = new CategoryInfoAdapter(categoryInfos); RecyclerView recyclerView = view.findViewById(R.id.recycler_view); recyclerView.setLayoutManager(new LinearLayoutManager(getActivity()));