tenkuma/jamfish
tenkuma/jamfish
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

add some comments

Browse source
This commit is contained in:
Jakob Kukla 2021-11-15 21:33:58 +01:00 • committed by jakobkukla
commit fcc612c185
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
app/src/main/java/com/dkanada/gramophone/service/MusicService.java
View file

@ -149,7 +149,7 @@ public class MusicService extends Service implements SharedPreferences.OnSharedP
@Override @Override
public void onRepeatModeChanged() { public void onRepeatModeChanged() {
notifyChange(REPEAT_MODE_CHANGED); notifyChange(REPEAT_MODE_CHANGED);
// FixMe: Not sure about this: // FIXME This call will be removed in a subsequent PR
prepareNext(); prepareNext();
} }
@ -405,7 +405,7 @@ public class MusicService extends Service implements SharedPreferences.OnSharedP
queueHandler.sendEmptyMessage(LOAD_QUEUE); queueHandler.sendEmptyMessage(LOAD_QUEUE);
} }
// FixMe: Move to QueueManager or not? // FIXME This will be refactored and partly moved to QueueManager in a subsequent PR
private synchronized void restoreQueuesAndPositionIfNecessary() { private synchronized void restoreQueuesAndPositionIfNecessary() {
if (!queuesRestored && queueManager.getPlayingQueue().isEmpty()) { if (!queuesRestored && queueManager.getPlayingQueue().isEmpty()) {
List<Song> restoredQueue = App.getDatabase().queueSongDao().getQueue(0); List<Song> restoredQueue = App.getDatabase().queueSongDao().getQueue(0);
@ -593,7 +593,7 @@ public class MusicService extends Service implements SharedPreferences.OnSharedP
uiThreadHandler.post(runnable); uiThreadHandler.post(runnable);
} }
// FixMe: Move to QueueManager or not? // FIXME This will be refactored and partly moved to QueueManager in a subsequent PR
public void openQueue(@Nullable final List<Song> playingQueue, final int startPosition, final boolean startPlaying) { public void openQueue(@Nullable final List<Song> playingQueue, final int startPosition, final boolean startPlaying) {
if (playingQueue != null && !playingQueue.isEmpty() && startPosition >= 0 && startPosition < playingQueue.size()) { if (playingQueue != null && !playingQueue.isEmpty() && startPosition >= 0 && startPosition < playingQueue.size()) {
// it is important to copy the playing queue here first as we might add or remove songs later // it is important to copy the playing queue here first as we might add or remove songs later

2
app/src/main/java/com/dkanada/gramophone/service/QueueManager.java
View file

@ -208,7 +208,7 @@ public class QueueManager {
callbacks.onQueueChanged(); callbacks.onQueueChanged();
} }
// FixMe: Remove static MusicPlayerRemote call, idk how... // FIXME This will be refactored and removed in a subsequent PR
private void reposition(int deletedPosition) { private void reposition(int deletedPosition) {
int currentPosition = getPosition(); int currentPosition = getPosition();
if (deletedPosition < currentPosition) { if (deletedPosition < currentPosition) {