Commit graph

2,182 commits

Author SHA1 Message Date
Jakob Kukla
588759c6d3 refactor: notify changes in MusicService with callbacks and reduce duplicate notifyChange() calls 2022-04-24 12:31:25 +02:00
Jakob Kukla
d59f63b0bf refactor: mark TRACK_ENDED as unused (with FIXME) 2022-04-24 12:31:25 +02:00
Jakob Kukla
a429198833 refactor: move synchronized keyword in funtion header 2022-04-24 12:31:25 +02:00
Jakob Kukla
f351429049 refactor: remove duplicate MusicServie#setPostion(int position) 2022-04-24 12:31:25 +02:00
Jakob Kukla
2c2fbb09b2 refactor: move playbackCallbacks in MusicService to own anonymous class 2022-04-24 12:31:25 +02:00
dkanada
0fe1001f70
Merge pull request #202 from bgaesslein/bugfix/move-sethasoptionsmenu-to-oncreateview
Move setHasOptionsMenu to onCreateView
2022-04-24 14:14:11 +09:00
dkanada
a2aa69de61
Merge pull request #196 from jakobkukla/remove-custom-media-factory
Remove UnknownMediaSourceFactory
2022-04-24 13:59:19 +09:00
dkanada
f7cb550991
Merge pull request #206 from Chikage0o0/patch-1
fix Chinese Translate
2022-04-24 13:13:27 +09:00
dkanada
88ac1e0286
Merge pull request #208 from jakobkukla/new-refactor-queuemanager
Refactor: Move queue management code into own class
2022-04-24 12:31:11 +09:00
Jakob Kukla
fcc612c185 add some comments 2022-03-20 19:16:09 +01:00
Jakob Kukla
a8bdd6033b refactor: move queue managing from MusicService to own class 2022-03-20 19:16:09 +01:00
jakobkukla
318f07ebd0 Fix playback if transcoding is disabled on the server 2022-03-20 19:15:30 +01:00
Jakob Kukla
5a2fa0a49d add todo 2022-03-20 19:15:30 +01:00
Jakob Kukla
fc3de93c3d remove UnknownMediaSourceFactory and infer if transcoding 2022-03-20 19:15:30 +01:00
Chikage0o0
4f9e91199f fix action_sort_order action_sort_method translate 2022-03-09 21:42:47 +08:00
Chikage0o0
3be09beb59
fix Chinese Translate 2022-03-06 22:12:52 +08:00
dkanada
458a8e2766
Merge pull request #204 from bgaesslein/bugfix/fix-artist-image
Use artist ID for primary image in constructors
2022-02-14 14:40:04 +09:00
dkanada
3e19346b49
Merge pull request #201 from bgaesslein/bugfix/prioritize-artist-over-albumartist
Prioritize artist over album artist for songs
2022-02-14 14:34:42 +09:00
dkanada
aee4fe8827
Merge pull request #197 from Zunawe/master
Expand list of illegal characters for downloaded filenames
2022-02-14 14:32:23 +09:00
bgaesslein
624407b71b Use artist ID for primary image in constructors
When using the constructor with an Album or Song, default the image to
the artist ID so the artist image always shows up when set.
Fixes #203 and has no side effects as far as I can see.
2022-02-13 14:22:39 +01:00
bgaesslein
67a6732640 Move setHasOptionsMenu to onCreateView
Commit 06c40d3 replaced the deprecated onActivityCreated with onCreate.
Apparently this leads to issues like backgrounds turning white on
screen rotation.
Fix: use onCreateView() instead, move to AbsMainActivityFragment and
LibraryFragment respectively because onCreateView gets overridden there

Should fix #167
2022-02-11 08:11:24 +01:00
bgaesslein
94f6ed8945 Prioritize artist over album artist for songs
Currently, the album artist is used if set. IMHO this is the wrong
choice as it will lead to "Various Artists" or similar being shown
when playing tracks from a compilation.
Changed the code to use first look for the artist tag instead.
2022-02-10 21:45:57 +01:00
Zunawe
43b1950f74 Expand list of illegal characters for downloaded filenames
Added "*:<>?\|
2021-11-24 04:06:42 -08:00
dkanada
03a3c9a1f7
Merge pull request #188 from MitchellWT/master
Added check for slide value
2021-10-05 20:58:54 +09:00
MitchellWT
f80adf6103
Update app/src/main/java/com/dkanada/gramophone/fragments/player/card/CardPlayerFragment.java
Co-authored-by: dkanada <dkanada@users.noreply.github.com>
2021-10-05 11:26:29 +11:00
MitchellWT
05ecc3b289 Formatted 'if' statement and added commenting 2021-10-04 13:38:34 +11:00
MitchellWT
1b3efb515c Added check for slide value 2021-09-13 19:56:50 +10:00
dkanada
cac64c53c7 add cancel action to download notification 2021-08-09 23:58:35 +09:00
dkanada
4753645805 update gitignore file 2021-08-09 14:50:15 +09:00
dkanada
76f37e4cab migrate material-cab sections to kotlin and update library 2021-08-08 17:51:24 +09:00
dkanada
ec649b5417 small changes to cab holder interface 2021-08-08 12:55:52 +09:00
dkanada
dbacad4e6c revert java version bump until android studio has better support 2021-08-07 13:11:02 +09:00
dkanada
4cf637bda1 update github workflow with new gradle version 2021-08-07 12:59:04 +09:00
dkanada
85229301fd update libraries and other tools 2021-08-07 12:55:39 +09:00
dkanada
b500c83d32 remove references to dimensions from MaterialDialogs library 2021-06-20 16:07:47 +09:00
dkanada
9367d5e697 refactor some preference dialogs 2021-06-20 16:05:37 +09:00
dkanada
bb392edc56 remove deprecated DialogUtils class usages 2021-06-20 16:04:49 +09:00
dkanada
ef93e292fc update fragment library 2021-06-20 15:43:32 +09:00
dkanada
6daf166172 remove all traces of theme helper library 2021-06-19 12:18:15 +09:00
dkanada
7fbb5b85f8 match HorizontalAlbumAdapter items to the rest of the grid styles 2021-06-16 13:20:00 +09:00
dkanada
2054f712be small code refactor within player fragments 2021-06-16 13:17:43 +09:00
dkanada
d6b4b67230 apply dark color on navigation bar to match status bar 2021-06-16 13:16:03 +09:00
dkanada
2c7113ecb9 improve theme utilities and fix issue with color drawable 2021-06-16 13:13:47 +09:00
dkanada
a7cb077cee replace all text color helper methods 2021-06-13 14:39:16 +09:00
dkanada
5ae5d3017a replace some infrequently used methods from theme library 2021-06-13 00:36:58 +09:00
dkanada
70a561e9d1 consolidate automatic styling methods into AbsThemeActivity 2021-06-12 14:49:32 +09:00
dkanada
e507495fa5 delete unused file and fix a few ide warnings 2021-06-12 14:04:23 +09:00
dkanada
aa5f0c5619 remove most ThemeStore uses for accent colors 2021-06-12 13:48:48 +09:00
dkanada
e48d5cdfd2 remove AppThemeHelper elements from xml files 2021-06-12 13:14:14 +09:00
dkanada
e5a8d536a0 update androidx dependencies 2021-06-12 00:40:57 +09:00