tenkuma/jamfish
tenkuma/jamfish
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #202 from bgaesslein/bugfix/move-sethasoptionsmenu-to-oncreateview

Browse source 
Move setHasOptionsMenu to onCreateView
This commit is contained in:
dkanada 2022-04-24 14:14:11 +09:00 • committed by GitHub
commit 0fe1001f70
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 2 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

8
app/src/main/java/com/dkanada/gramophone/fragments/library/AbsLibraryPagerFragment.java
View file

@ -1,7 +1,5 @@
package com.dkanada.gramophone.fragments.library; package com.dkanada.gramophone.fragments.library;
import android.os.Bundle;
import com.dkanada.gramophone.fragments.AbsMusicServiceFragment; import com.dkanada.gramophone.fragments.AbsMusicServiceFragment;
import com.dkanada.gramophone.fragments.main.LibraryFragment; import com.dkanada.gramophone.fragments.main.LibraryFragment;
@ -9,10 +7,4 @@ public class AbsLibraryPagerFragment extends AbsMusicServiceFragment {
public LibraryFragment getLibraryFragment() { public LibraryFragment getLibraryFragment() {
return (LibraryFragment) getParentFragment(); return (LibraryFragment) getParentFragment();
} }
@Override
public void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setHasOptionsMenu(true);
}
} }

1
app/src/main/java/com/dkanada/gramophone/fragments/library/AbsLibraryPagerRecyclerViewFragment.java
View file

@ -31,6 +31,7 @@ public abstract class AbsLibraryPagerRecyclerViewFragment<A extends RecyclerView
@Override @Override
public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
setHasOptionsMenu(true);
binding = FragmentMainActivityRecyclerViewBinding.inflate(getLayoutInflater(), container, false); binding = FragmentMainActivityRecyclerViewBinding.inflate(getLayoutInflater(), container, false);
return binding.getRoot(); return binding.getRoot();

8
app/src/main/java/com/dkanada/gramophone/fragments/main/AbsMainActivityFragment.java
View file

@ -1,7 +1,5 @@
package com.dkanada.gramophone.fragments.main; package com.dkanada.gramophone.fragments.main;
import android.os.Bundle;
import androidx.fragment.app.Fragment; import androidx.fragment.app.Fragment;
import com.dkanada.gramophone.activities.MainActivity; import com.dkanada.gramophone.activities.MainActivity;
@ -10,10 +8,4 @@ public abstract class AbsMainActivityFragment extends Fragment {
public MainActivity getMainActivity() { public MainActivity getMainActivity() {
return (MainActivity) getActivity(); return (MainActivity) getActivity();
} }
@Override
public void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setHasOptionsMenu(true);
}
} }

1
app/src/main/java/com/dkanada/gramophone/fragments/main/LibraryFragment.java
View file

@ -47,6 +47,7 @@ public class LibraryFragment extends AbsMainActivityFragment implements ViewPage
@Override @Override
public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
setHasOptionsMenu(true);
binding = FragmentLibraryBinding.inflate(inflater); binding = FragmentLibraryBinding.inflate(inflater);
return binding.getRoot(); return binding.getRoot();