tenkuma/jamfish
tenkuma/jamfish
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix artist detail activity and a landscape bug

Browse source
This commit is contained in:
Karim Abou Zeid 2018-04-28 00:55:27 +02:00
commit 55146753f2
4 changed files with 10 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

5
app/src/main/java/com/kabouzeid/gramophone/ui/activities/AlbumDetailActivity.java
View file

@ -157,7 +157,10 @@ public class AlbumDetailActivity extends AbsSlidingMusicPanelActivity implements
private void setUpObservableListViewParams() {
toolbarColor = DialogUtils.resolveColor(this, R.attr.defaultFooterColor);
headerViewHeight = getResources().getDimensionPixelSize(R.dimen.title_view_height);
headerViewHeight = getResources().getDimensionPixelSize(R.dimen.detail_header_height);
if (headerViewHeight == 0) {
albumArtImageView.setVisibility(View.GONE);
}
}
private void setUpViews() {

4
app/src/main/res/layout/activity_album_detail.xml
View file

@ -53,7 +53,7 @@
<LinearLayout
android:id="@+id/header"
android:layout_width="match_parent"
android:layout_height="@dimen/title_view_height"
android:layout_height="@dimen/detail_header_height"
android:background="?attr/defaultFooterColor"
android:elevation="@dimen/toolbar_elevation"
android:orientation="horizontal"
@ -216,7 +216,7 @@
<View
android:id="@+id/header_overlay"
android:layout_width="match_parent"
android:layout_height="@dimen/title_view_height"
android:layout_height="@dimen/detail_header_height"
android:elevation="@dimen/toolbar_elevation"
tools:ignore="UnusedAttribute" />
</FrameLayout>

3
app/src/main/res/values-land/dimens.xml
View file

@ -1,5 +1,6 @@
<resources>
<dimen name="title_view_height">0dp</dimen>
<dimen name="detail_header_height">0dp</dimen>
<dimen name="title_view_height">56dp</dimen>
<dimen name="header_image_height">180dp</dimen>

3
app/src/main/res/values/dimens.xml
View file

@ -2,7 +2,8 @@
<dimen name="default_item_margin">16dp</dimen>
<dimen name="title_view_height">176dp</dimen>
<dimen name="detail_header_height">176dp</dimen>
<dimen name="title_view_height">72dp</dimen>
<dimen name="toolbar_elevation">4dp</dimen>
<dimen name="card_elevation">2dp</dimen>