Remove redundant methods

This commit is contained in:
Eugene Cheung 2018-09-05 22:35:36 -04:00
commit 5cef335b27
No known key found for this signature in database
GPG key ID: E1FD745328866B0A
10 changed files with 6 additions and 41 deletions

View file

@ -37,11 +37,6 @@ public class HistoryPlaylist extends AbsSmartPlaylist {
return 0; return 0;
} }
@Override
public void writeToParcel(Parcel dest, int flags) {
super.writeToParcel(dest, flags);
}
protected HistoryPlaylist(Parcel in) { protected HistoryPlaylist(Parcel in) {
super(in); super(in);
} }

View file

@ -35,11 +35,6 @@ public class LastAddedPlaylist extends AbsSmartPlaylist {
return 0; return 0;
} }
@Override
public void writeToParcel(Parcel dest, int flags) {
super.writeToParcel(dest, flags);
}
protected LastAddedPlaylist(Parcel in) { protected LastAddedPlaylist(Parcel in) {
super(in); super(in);
} }

View file

@ -37,11 +37,6 @@ public class MyTopTracksPlaylist extends AbsSmartPlaylist {
return 0; return 0;
} }
@Override
public void writeToParcel(Parcel dest, int flags) {
super.writeToParcel(dest, flags);
}
protected MyTopTracksPlaylist(Parcel in) { protected MyTopTracksPlaylist(Parcel in) {
super(in); super(in);
} }
@ -55,4 +50,4 @@ public class MyTopTracksPlaylist extends AbsSmartPlaylist {
return new MyTopTracksPlaylist[size]; return new MyTopTracksPlaylist[size];
} }
}; };
} }

View file

@ -32,11 +32,6 @@ public class ShuffleAllPlaylist extends AbsSmartPlaylist {
return 0; return 0;
} }
@Override
public void writeToParcel(Parcel dest, int flags) {
super.writeToParcel(dest, flags);
}
protected ShuffleAllPlaylist(Parcel in) { protected ShuffleAllPlaylist(Parcel in) {
super(in); super(in);
} }

View file

@ -92,11 +92,6 @@ public class SearchActivity extends AbsMusicServiceActivity implements SearchVie
outState.putString(QUERY, query); outState.putString(QUERY, query);
} }
@Override
protected void onRestoreInstanceState(Bundle savedInstanceState) {
super.onRestoreInstanceState(savedInstanceState);
}
private void setUpToolBar() { private void setUpToolBar() {
toolbar.setBackgroundColor(ThemeStore.primaryColor(this)); toolbar.setBackgroundColor(ThemeStore.primaryColor(this));
setSupportActionBar(toolbar); setSupportActionBar(toolbar);

View file

@ -32,7 +32,6 @@ public abstract class AbsMusicServiceActivity extends AbsBaseActivity implements
private MusicStateReceiver musicStateReceiver; private MusicStateReceiver musicStateReceiver;
private boolean receiverRegistered; private boolean receiverRegistered;
@Override @Override
protected void onCreate(Bundle savedInstanceState) { protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState); super.onCreate(savedInstanceState);

View file

@ -260,18 +260,12 @@ public class BugReportActivity extends AbsThemeActivity {
String bugTitle = inputTitle.getText().toString(); String bugTitle = inputTitle.getText().toString();
String bugDescription = inputDescription.getText().toString(); String bugDescription = inputDescription.getText().toString();
ExtraInfo extraInfo = new ExtraInfo(); Report report = new Report(bugTitle, bugDescription, deviceInfo, new ExtraInfo());
onSaveExtraInfo(extraInfo);
Report report = new Report(bugTitle, bugDescription, deviceInfo, extraInfo);
GithubTarget target = new GithubTarget("kabouzeid", "Phonograph"); GithubTarget target = new GithubTarget("kabouzeid", "Phonograph");
ReportIssueAsyncTask.report(this, report, target, login); ReportIssueAsyncTask.report(this, report, target, login);
} }
protected void onSaveExtraInfo(ExtraInfo extraInfo) {
}
@Override @Override
public boolean onOptionsItemSelected(MenuItem item) { public boolean onOptionsItemSelected(MenuItem item) {
if (item.getItemId() == android.R.id.home) { if (item.getItemId() == android.R.id.home) {

View file

@ -3,10 +3,9 @@ package com.kabouzeid.gramophone.ui.activities.bugreport.model.github;
import android.text.TextUtils; import android.text.TextUtils;
public class GithubLogin { public class GithubLogin {
private final String username; private final String username;
private final String password; private final String password;
private final String apiToken; private final String apiToken;
public GithubLogin(String username, String password) { public GithubLogin(String username, String password) {

View file

@ -137,13 +137,13 @@ public class LibraryFragment extends AbsMainActivityFragment implements CabHolde
tabs.setSelectedTabIndicatorColor(ThemeStore.accentColor(getActivity())); tabs.setSelectedTabIndicatorColor(ThemeStore.accentColor(getActivity()));
updateTabVisibility(); updateTabVisibility();
if (PreferenceUtil.getInstance(getContext()).rememberLastTab()) { if (PreferenceUtil.getInstance(getContext()).rememberLastTab()) {
pager.setCurrentItem(PreferenceUtil.getInstance(getContext()).getLastPage()); pager.setCurrentItem(PreferenceUtil.getInstance(getContext()).getLastPage());
} }
pager.addOnPageChangeListener(this); pager.addOnPageChangeListener(this);
} }
private void updateTabVisibility() { private void updateTabVisibility() {
// hide the tab bar when only a single tab is visible // hide the tab bar when only a single tab is visible
tabs.setVisibility(pagerAdapter.getCount() == 1 ? View.GONE : View.VISIBLE); tabs.setVisibility(pagerAdapter.getCount() == 1 ? View.GONE : View.VISIBLE);

View file

@ -45,8 +45,7 @@ public class MusicUtil {
public static final String TAG = MusicUtil.class.getSimpleName(); public static final String TAG = MusicUtil.class.getSimpleName();
public static Uri getMediaStoreAlbumCoverUri(int albumId) { public static Uri getMediaStoreAlbumCoverUri(int albumId) {
final Uri sArtworkUri = Uri final Uri sArtworkUri = Uri.parse("content://media/external/audio/albumart");
.parse("content://media/external/audio/albumart");
return ContentUris.withAppendedId(sArtworkUri, albumId); return ContentUris.withAppendedId(sArtworkUri, albumId);
} }
@ -58,7 +57,6 @@ public class MusicUtil {
@NonNull @NonNull
public static Intent createShareSongFileIntent(@NonNull final Song song, Context context) { public static Intent createShareSongFileIntent(@NonNull final Song song, Context context) {
try { try {
return new Intent() return new Intent()
.setAction(Intent.ACTION_SEND) .setAction(Intent.ACTION_SEND)
.putExtra(Intent.EXTRA_STREAM, FileProvider.getUriForFile(context, context.getApplicationContext().getPackageName(), new File(song.data))) .putExtra(Intent.EXTRA_STREAM, FileProvider.getUriForFile(context, context.getApplicationContext().getPackageName(), new File(song.data)))