fix some ide warnings

This commit is contained in:
dkanada 2021-02-21 12:07:29 +09:00
commit 8485bd3f8c
9 changed files with 42 additions and 36 deletions

View file

@ -52,7 +52,7 @@
android:scaleType="centerCrop" android:scaleType="centerCrop"
android:src="@drawable/default_album_art" android:src="@drawable/default_album_art"
android:transitionName="@string/transition_album_image" android:transitionName="@string/transition_album_image"
tools:ignore="ContentDescription,UnusedAttribute" /> tools:ignore="ContentDescription" />
<LinearLayout <LinearLayout
android:layout_width="match_parent" android:layout_width="match_parent"
@ -77,7 +77,7 @@
android:layout_marginEnd="8dp" android:layout_marginEnd="8dp"
android:layout_marginStart="0dp" android:layout_marginStart="0dp"
app:srcCompat="@drawable/ic_person_white_24dp" app:srcCompat="@drawable/ic_person_white_24dp"
tools:ignore="ContentDescription,UnusedAttribute" /> tools:ignore="ContentDescription" />
<TextView <TextView
android:ellipsize="end" android:ellipsize="end"

View file

@ -53,7 +53,7 @@
android:scaleType="centerCrop" android:scaleType="centerCrop"
android:src="@drawable/default_artist_image" android:src="@drawable/default_artist_image"
android:transitionName="@string/transition_artist_image" android:transitionName="@string/transition_artist_image"
tools:ignore="ContentDescription,UnusedAttribute" /> tools:ignore="ContentDescription" />
<LinearLayout <LinearLayout
android:layout_width="match_parent" android:layout_width="match_parent"
@ -78,7 +78,7 @@
android:layout_marginEnd="8dp" android:layout_marginEnd="8dp"
android:layout_marginStart="0dp" android:layout_marginStart="0dp"
app:srcCompat="@drawable/ic_album_white_24dp" app:srcCompat="@drawable/ic_album_white_24dp"
tools:ignore="ContentDescription,UnusedAttribute" /> tools:ignore="ContentDescription" />
<TextView <TextView
android:id="@+id/album_count_text" android:id="@+id/album_count_text"
@ -104,7 +104,7 @@
android:layout_marginEnd="8dp" android:layout_marginEnd="8dp"
android:layout_marginStart="0dp" android:layout_marginStart="0dp"
app:srcCompat="@drawable/ic_music_note_white_24dp" app:srcCompat="@drawable/ic_music_note_white_24dp"
tools:ignore="ContentDescription,UnusedAttribute" /> tools:ignore="ContentDescription" />
<TextView <TextView
android:id="@+id/song_count_text" android:id="@+id/song_count_text"
@ -130,7 +130,7 @@
android:layout_marginEnd="8dp" android:layout_marginEnd="8dp"
android:layout_marginStart="0dp" android:layout_marginStart="0dp"
app:srcCompat="@drawable/ic_timer_white_24dp" app:srcCompat="@drawable/ic_timer_white_24dp"
tools:ignore="ContentDescription,UnusedAttribute" /> tools:ignore="ContentDescription" />
<TextView <TextView
android:id="@+id/duration_text" android:id="@+id/duration_text"

View file

@ -43,6 +43,7 @@
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:background="?attr/rectSelector" android:background="?attr/rectSelector"
android:clickable="true" android:clickable="true"
android:focusable="true"
android:gravity="center_vertical" android:gravity="center_vertical"
android:minHeight="@dimen/md_listitem_height" android:minHeight="@dimen/md_listitem_height"
android:orientation="horizontal" android:orientation="horizontal"
@ -54,7 +55,7 @@
android:layout_width="24dp" android:layout_width="24dp"
android:layout_height="24dp" android:layout_height="24dp"
app:srcCompat="@drawable/ic_info_outline_white_24dp" app:srcCompat="@drawable/ic_info_outline_white_24dp"
tools:ignore="ContentDescription,UnusedAttribute" /> tools:ignore="ContentDescription" />
<LinearLayout <LinearLayout
android:layout_width="match_parent" android:layout_width="match_parent"
@ -88,6 +89,7 @@
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:background="?attr/rectSelector" android:background="?attr/rectSelector"
android:clickable="true" android:clickable="true"
android:focusable="true"
android:gravity="center_vertical" android:gravity="center_vertical"
android:minHeight="@dimen/md_listitem_height" android:minHeight="@dimen/md_listitem_height"
android:orientation="horizontal" android:orientation="horizontal"
@ -99,7 +101,7 @@
android:layout_width="24dp" android:layout_width="24dp"
android:layout_height="24dp" android:layout_height="24dp"
app:srcCompat="@drawable/ic_github_circle_white_24dp" app:srcCompat="@drawable/ic_github_circle_white_24dp"
tools:ignore="ContentDescription,UnusedAttribute" /> tools:ignore="ContentDescription" />
<TextView <TextView
android:layout_width="wrap_content" android:layout_width="wrap_content"

View file

@ -31,6 +31,7 @@
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:background="?attr/rectSelector" android:background="?attr/rectSelector"
android:clickable="true" android:clickable="true"
android:focusable="true"
android:gravity="center_vertical" android:gravity="center_vertical"
android:minHeight="@dimen/md_listitem_height" android:minHeight="@dimen/md_listitem_height"
android:orientation="horizontal" android:orientation="horizontal"
@ -42,7 +43,7 @@
android:layout_width="24dp" android:layout_width="24dp"
android:layout_height="24dp" android:layout_height="24dp"
app:srcCompat="@drawable/ic_person_white_24dp" app:srcCompat="@drawable/ic_person_white_24dp"
tools:ignore="ContentDescription,UnusedAttribute" /> tools:ignore="ContentDescription" />
<LinearLayout <LinearLayout
android:layout_width="match_parent" android:layout_width="match_parent"
@ -75,6 +76,7 @@
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:background="?attr/rectSelector" android:background="?attr/rectSelector"
android:clickable="true" android:clickable="true"
android:focusable="true"
android:visibility="gone" android:visibility="gone"
android:gravity="center_vertical" android:gravity="center_vertical"
android:minHeight="@dimen/md_listitem_height" android:minHeight="@dimen/md_listitem_height"
@ -87,7 +89,7 @@
android:layout_width="24dp" android:layout_width="24dp"
android:layout_height="24dp" android:layout_height="24dp"
app:srcCompat="@drawable/ic_email_white_24dp" app:srcCompat="@drawable/ic_email_white_24dp"
tools:ignore="ContentDescription,UnusedAttribute" /> tools:ignore="ContentDescription" />
<TextView <TextView
android:layout_width="wrap_content" android:layout_width="wrap_content"
@ -106,6 +108,7 @@
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:background="?attr/rectSelector" android:background="?attr/rectSelector"
android:clickable="true" android:clickable="true"
android:focusable="true"
android:visibility="gone" android:visibility="gone"
android:gravity="center_vertical" android:gravity="center_vertical"
android:minHeight="@dimen/md_listitem_height" android:minHeight="@dimen/md_listitem_height"
@ -118,7 +121,7 @@
android:layout_width="24dp" android:layout_width="24dp"
android:layout_height="24dp" android:layout_height="24dp"
app:srcCompat="@drawable/ic_twitter_white_24dp" app:srcCompat="@drawable/ic_twitter_white_24dp"
tools:ignore="ContentDescription,UnusedAttribute" /> tools:ignore="ContentDescription" />
<TextView <TextView
android:layout_width="wrap_content" android:layout_width="wrap_content"
@ -137,6 +140,7 @@
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:background="?attr/rectSelector" android:background="?attr/rectSelector"
android:clickable="true" android:clickable="true"
android:focusable="true"
android:gravity="center_vertical" android:gravity="center_vertical"
android:minHeight="@dimen/md_listitem_height" android:minHeight="@dimen/md_listitem_height"
android:orientation="horizontal" android:orientation="horizontal"
@ -148,7 +152,7 @@
android:layout_width="24dp" android:layout_width="24dp"
android:layout_height="24dp" android:layout_height="24dp"
app:srcCompat="@drawable/ic_open_in_browser_white_24dp" app:srcCompat="@drawable/ic_open_in_browser_white_24dp"
tools:ignore="ContentDescription,UnusedAttribute" /> tools:ignore="ContentDescription" />
<TextView <TextView
android:layout_width="wrap_content" android:layout_width="wrap_content"

View file

@ -43,7 +43,7 @@
android:layout_width="24dp" android:layout_width="24dp"
android:layout_height="24dp" android:layout_height="24dp"
app:srcCompat="@drawable/ic_bug_report_white_24dp" app:srcCompat="@drawable/ic_bug_report_white_24dp"
tools:ignore="ContentDescription,UnusedAttribute" /> tools:ignore="ContentDescription" />
<LinearLayout <LinearLayout
android:layout_width="match_parent" android:layout_width="match_parent"
@ -75,6 +75,7 @@
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:background="?attr/rectSelector" android:background="?attr/rectSelector"
android:clickable="true" android:clickable="true"
android:focusable="true"
android:visibility="gone" android:visibility="gone"
android:gravity="center_vertical" android:gravity="center_vertical"
android:minHeight="@dimen/md_listitem_height" android:minHeight="@dimen/md_listitem_height"
@ -119,6 +120,7 @@
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:background="?attr/rectSelector" android:background="?attr/rectSelector"
android:clickable="true" android:clickable="true"
android:focusable="true"
android:visibility="gone" android:visibility="gone"
android:gravity="center_vertical" android:gravity="center_vertical"
android:minHeight="@dimen/md_listitem_height" android:minHeight="@dimen/md_listitem_height"
@ -163,6 +165,7 @@
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:background="?attr/rectSelector" android:background="?attr/rectSelector"
android:clickable="true" android:clickable="true"
android:focusable="true"
android:visibility="gone" android:visibility="gone"
android:gravity="center_vertical" android:gravity="center_vertical"
android:minHeight="@dimen/md_listitem_height" android:minHeight="@dimen/md_listitem_height"

View file

@ -18,13 +18,14 @@
android:layout_height="match_parent" android:layout_height="match_parent"
android:layout_alignParentStart="true" android:layout_alignParentStart="true"
android:fontFamily="sans-serif-medium" android:fontFamily="sans-serif-medium"
android:gravity="center_vertical|left|end" android:gravity="center_vertical|start"
android:paddingLeft="8dp" android:paddingStart="8dp"
android:singleLine="true" android:singleLine="true"
android:textAppearance="@style/TextAppearance.AppCompat.Title" android:textAppearance="@style/TextAppearance.AppCompat.Title"
android:textColor="?android:textColorSecondary" android:textColor="?android:textColorSecondary"
android:textSize="12sp" android:textSize="12sp"
tools:ignore="RtlHardcoded,RtlSymmetry" /> tools:ignore="RtlSymmetry"
tools:text="0:00" />
<TextView <TextView
android:id="@+id/player_song_total_time" android:id="@+id/player_song_total_time"
@ -32,13 +33,14 @@
android:layout_height="match_parent" android:layout_height="match_parent"
android:layout_alignParentEnd="true" android:layout_alignParentEnd="true"
android:fontFamily="sans-serif-medium" android:fontFamily="sans-serif-medium"
android:gravity="center_vertical|right|end" android:gravity="center_vertical|end"
android:paddingRight="8dp" android:paddingEnd="8dp"
android:singleLine="true" android:singleLine="true"
android:textAppearance="@style/TextAppearance.AppCompat.Title" android:textAppearance="@style/TextAppearance.AppCompat.Title"
android:textColor="?android:textColorSecondary" android:textColor="?android:textColorSecondary"
android:textSize="12sp" android:textSize="12sp"
tools:ignore="RtlHardcoded,RtlSymmetry" /> tools:ignore="RtlSymmetry"
tools:text="4:00" />
<SeekBar <SeekBar
android:id="@+id/player_progress_slider" android:id="@+id/player_progress_slider"
@ -46,7 +48,7 @@
android:layout_height="match_parent" android:layout_height="match_parent"
android:layout_toStartOf="@id/player_song_total_time" android:layout_toStartOf="@id/player_song_total_time"
android:layout_toEndOf="@id/player_song_current_progress" android:layout_toEndOf="@id/player_song_current_progress"
tools:ignore="RtlHardcoded,UnusedAttribute" /> tools:ignore="RtlHardcoded" />
</RelativeLayout> </RelativeLayout>
@ -55,7 +57,7 @@
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="@dimen/fab_media_controller_container_height" android:layout_height="@dimen/fab_media_controller_container_height"
android:layoutDirection="ltr" android:layoutDirection="ltr"
tools:ignore="ContentDescription,UnusedAttribute"> tools:ignore="ContentDescription">
<ImageButton <ImageButton
android:id="@+id/player_prev_button" android:id="@+id/player_prev_button"
@ -67,8 +69,7 @@
android:background="?attr/roundSelector" android:background="?attr/roundSelector"
android:padding="22dp" android:padding="22dp"
android:scaleType="fitCenter" android:scaleType="fitCenter"
app:srcCompat="@drawable/ic_skip_previous_white_24dp" app:srcCompat="@drawable/ic_skip_previous_white_24dp" />
tools:ignore="MissingPrefix" />
<ImageButton <ImageButton
android:id="@+id/player_next_button" android:id="@+id/player_next_button"
@ -80,8 +81,7 @@
android:background="?attr/roundSelector" android:background="?attr/roundSelector"
android:padding="22dp" android:padding="22dp"
android:scaleType="fitCenter" android:scaleType="fitCenter"
app:srcCompat="@drawable/ic_skip_next_white_24dp" app:srcCompat="@drawable/ic_skip_next_white_24dp" />
tools:ignore="MissingPrefix" />
<ImageButton <ImageButton
android:id="@+id/player_repeat_button" android:id="@+id/player_repeat_button"
@ -93,8 +93,7 @@
android:background="?attr/roundSelector" android:background="?attr/roundSelector"
android:padding="22dp" android:padding="22dp"
android:scaleType="fitCenter" android:scaleType="fitCenter"
app:srcCompat="@drawable/ic_repeat_white_24dp" app:srcCompat="@drawable/ic_repeat_white_24dp" />
tools:ignore="MissingPrefix" />
<ImageButton <ImageButton
android:id="@+id/player_shuffle_button" android:id="@+id/player_shuffle_button"
@ -106,8 +105,7 @@
android:background="?attr/roundSelector" android:background="?attr/roundSelector"
android:padding="22dp" android:padding="22dp"
android:scaleType="fitCenter" android:scaleType="fitCenter"
app:srcCompat="@drawable/ic_shuffle_white_24dp" app:srcCompat="@drawable/ic_shuffle_white_24dp" />
tools:ignore="MissingPrefix" />
<Space <Space
android:id="@+id/dummy_fab" android:id="@+id/dummy_fab"

View file

@ -33,13 +33,13 @@
android:layout_height="match_parent" android:layout_height="match_parent"
android:layout_alignParentEnd="true" android:layout_alignParentEnd="true"
android:fontFamily="sans-serif-medium" android:fontFamily="sans-serif-medium"
android:gravity="center_vertical|right|end" android:gravity="center_vertical|end"
android:paddingRight="8dp" android:paddingEnd="8dp"
android:singleLine="true" android:singleLine="true"
android:textAppearance="@style/TextAppearance.AppCompat.Title" android:textAppearance="@style/TextAppearance.AppCompat.Title"
android:textColor="@color/ate_primary_text_dark" android:textColor="@color/ate_primary_text_dark"
android:textSize="12sp" android:textSize="12sp"
tools:ignore="RtlHardcoded,RtlSymmetry" tools:ignore="RtlSymmetry"
tools:text="3:14" /> tools:text="3:14" />
<SeekBar <SeekBar
@ -47,8 +47,7 @@
style="@style/MusicProgressSlider" style="@style/MusicProgressSlider"
android:layout_height="match_parent" android:layout_height="match_parent"
android:layout_toStartOf="@id/player_song_total_time" android:layout_toStartOf="@id/player_song_total_time"
android:layout_toEndOf="@id/player_song_current_progress" android:layout_toEndOf="@id/player_song_current_progress" />
tools:ignore="RtlHardcoded,UnusedAttribute" />
</RelativeLayout> </RelativeLayout>

View file

@ -12,7 +12,7 @@
android:layout_height="match_parent" android:layout_height="match_parent"
android:gravity="center" android:gravity="center"
android:orientation="vertical" android:orientation="vertical"
tools:ignore="UnusedAttribute,UselessParent"> tools:ignore="UselessParent">
<com.dkanada.gramophone.views.WidthFitSquareLayout <com.dkanada.gramophone.views.WidthFitSquareLayout
android:id="@+id/image_container" android:id="@+id/image_container"

View file

@ -17,7 +17,7 @@
android:layout_width="104dp" android:layout_width="104dp"
android:layout_height="104dp" android:layout_height="104dp"
android:scaleType="centerCrop" android:scaleType="centerCrop"
tools:ignore="ContentDescription,UnusedAttribute" /> tools:ignore="ContentDescription" />
<LinearLayout <LinearLayout
android:layout_width="match_parent" android:layout_width="match_parent"